
... including "note: '[...]' was declared here" emitted since recent
commit 9695e1c23b
"Improve -Wuninitialized note location".
For those that seemed incorrect to me, I've placed XFAILed 'dg-bogus'es,
including one more instance of PR77504 etc., and several instances where
for "local variables" of reference-data-type reductions (etc.?) we emit
bogus (?) diagnostics.
For implicit data clauses (including 'firstprivate'), we seem to be missing
diagnostics, so I've placed XFAILed 'dg-warning's.
gcc/testsuite/
* c-c++-common/goacc/builtin-goacc-parlevel-id-size.c: Document
current '-Wuninitialized' diagnostics.
* c-c++-common/goacc/mdc-1.c: Likewise.
* c-c++-common/goacc/nested-reductions-1-kernels.c: Likewise.
* c-c++-common/goacc/nested-reductions-1-parallel.c: Likewise.
* c-c++-common/goacc/nested-reductions-1-routine.c: Likewise.
* c-c++-common/goacc/nested-reductions-2-kernels.c: Likewise.
* c-c++-common/goacc/nested-reductions-2-parallel.c: Likewise.
* c-c++-common/goacc/nested-reductions-2-routine.c: Likewise.
* c-c++-common/goacc/uninit-dim-clause.c: Likewise.
* c-c++-common/goacc/uninit-firstprivate-clause.c: Likewise.
* c-c++-common/goacc/uninit-if-clause.c: Likewise.
* gfortran.dg/goacc/array-with-dt-1.f90: Likewise.
* gfortran.dg/goacc/array-with-dt-2.f90: Likewise.
* gfortran.dg/goacc/array-with-dt-3.f90: Likewise.
* gfortran.dg/goacc/array-with-dt-4.f90: Likewise.
* gfortran.dg/goacc/array-with-dt-5.f90: Likewise.
* gfortran.dg/goacc/derived-chartypes-1.f90: Likewise.
* gfortran.dg/goacc/derived-chartypes-2.f90: Likewise.
* gfortran.dg/goacc/derived-chartypes-3.f90: Likewise.
* gfortran.dg/goacc/derived-chartypes-4.f90: Likewise.
* gfortran.dg/goacc/derived-classtypes-1.f95: Likewise.
* gfortran.dg/goacc/derived-types-2.f90: Likewise.
* gfortran.dg/goacc/host_data-tree.f95: Likewise.
* gfortran.dg/goacc/kernels-tree.f95: Likewise.
* gfortran.dg/goacc/modules.f95: Likewise.
* gfortran.dg/goacc/nested-reductions-1-kernels.f90: Likewise.
* gfortran.dg/goacc/nested-reductions-1-parallel.f90: Likewise.
* gfortran.dg/goacc/nested-reductions-1-routine.f90: Likewise.
* gfortran.dg/goacc/nested-reductions-2-kernels.f90: Likewise.
* gfortran.dg/goacc/nested-reductions-2-parallel.f90: Likewise.
* gfortran.dg/goacc/nested-reductions-2-routine.f90: Likewise.
* gfortran.dg/goacc/parallel-tree.f95: Likewise.
* gfortran.dg/goacc/pr93464.f90: Likewise.
* gfortran.dg/goacc/privatization-1-compute-loop.f90: Likewise.
* gfortran.dg/goacc/privatization-1-compute.f90: Likewise.
* gfortran.dg/goacc/privatization-1-routine_gang-loop.f90:
Likewise.
* gfortran.dg/goacc/privatization-1-routine_gang.f90: Likewise.
* gfortran.dg/goacc/uninit-dim-clause.f95: Likewise.
* gfortran.dg/goacc/uninit-firstprivate-clause.f95: Likewise.
* gfortran.dg/goacc/uninit-if-clause.f95: Likewise.
* gfortran.dg/goacc/uninit-use-device-clause.f95: Likewise.
* gfortran.dg/goacc/wait.f90: Likewise.
libgomp/
* testsuite/libgomp.oacc-c-c++-common/vred2d-128.c: Document
current '-Wuninitialized' diagnostics.
* testsuite/libgomp.oacc-fortran/data-5.f90: Likewise.
* testsuite/libgomp.oacc-fortran/gemm-2.f90: Likewise.
* testsuite/libgomp.oacc-fortran/gemm.f90: Likewise.
* testsuite/libgomp.oacc-fortran/optional-reduction.f90: Likewise.
* testsuite/libgomp.oacc-fortran/parallel-reduction.f90: Likewise.
* testsuite/libgomp.oacc-fortran/pr70643.f90: Likewise.
* testsuite/libgomp.oacc-fortran/pr96628-part1.f90: Likewise.
* testsuite/libgomp.oacc-fortran/privatized-ref-2.f90: Likewise.
* testsuite/libgomp.oacc-fortran/reduction-5.f90: Likewise.
* testsuite/libgomp.oacc-fortran/reduction-7.f90: Likewise.
* testsuite/libgomp.oacc-fortran/reference-reductions.f90:
Likewise.
96 lines
2.2 KiB
Fortran
96 lines
2.2 KiB
Fortran
! { dg-do run }
|
|
|
|
! { dg-additional-options -Wuninitialized }
|
|
|
|
!TODO
|
|
! { dg-xfail-run-if TODO { openacc_radeon_accel_selected && { ! __OPTIMIZE__ } } }
|
|
|
|
! subroutine reduction with private and firstprivate variables
|
|
|
|
program reduction
|
|
integer, parameter :: n = 100
|
|
integer :: i, j, vsum, cs, arr(n)
|
|
|
|
call redsub_private (cs, n, arr)
|
|
call redsub_bogus (cs, n)
|
|
call redsub_combined (cs, n, arr)
|
|
|
|
vsum = 0
|
|
|
|
! Verify the results
|
|
do i = 1, n
|
|
vsum = i
|
|
do j = 1, n
|
|
vsum = vsum + 1;
|
|
end do
|
|
if (vsum .ne. arr(i)) STOP 1
|
|
end do
|
|
end program reduction
|
|
|
|
! This subroutine tests a reduction with an explicit private variable.
|
|
|
|
subroutine redsub_private(sum, n, arr)
|
|
integer :: sum, n, arr(n)
|
|
integer :: i, j, v
|
|
|
|
!$acc parallel copyout (arr)
|
|
!$acc loop gang private (v)
|
|
do j = 1, n
|
|
v = j
|
|
|
|
!$acc loop vector reduction (+:v)
|
|
do i = 1, 100
|
|
v = v + 1
|
|
end do
|
|
|
|
arr(j) = v
|
|
end do
|
|
!$acc end parallel
|
|
|
|
! verify the results
|
|
do i = 1, 10
|
|
if (arr(i) .ne. 100+i) STOP 2
|
|
end do
|
|
end subroutine redsub_private
|
|
|
|
|
|
! Bogus reduction on a firstprivate variable. The results do
|
|
! survive the parallel region. The goal here is to ensure that gfortran
|
|
! doesn't ICE.
|
|
|
|
subroutine redsub_bogus(sum, n)
|
|
integer :: sum, n, arr(n)
|
|
integer :: i
|
|
|
|
!$acc parallel firstprivate(sum)
|
|
!$acc loop gang worker vector reduction (+:sum)
|
|
! { dg-bogus {'sum\.[0-9]+' is used uninitialized} TODO { xfail *-*-* } .-1 }
|
|
! { dg-note {'sum\.[0-9]+' was declared here} {} { target *-*-* } .-2 }
|
|
do i = 1, n
|
|
sum = sum + 1
|
|
end do
|
|
!$acc end parallel
|
|
end subroutine redsub_bogus
|
|
|
|
! This reduction involving a firstprivate variable yields legitimate results.
|
|
|
|
subroutine redsub_combined(sum, n, arr)
|
|
integer :: sum, n, arr(n)
|
|
integer :: i, j
|
|
|
|
!$acc parallel copy (arr) firstprivate(sum)
|
|
!$acc loop gang
|
|
do i = 1, n
|
|
sum = i;
|
|
|
|
!$acc loop reduction(+:sum)
|
|
! { dg-bogus {'sum\.[0-9]+' may be used uninitialized} TODO { xfail { ! __OPTIMIZE__ } } .-1 }
|
|
! { dg-note {'sum\.[0-9]+' was declared here} {} { target { ! __OPTIMIZE__ } } .-2 }
|
|
do j = 1, n
|
|
sum = sum + 1
|
|
end do
|
|
|
|
arr(i) = sum
|
|
end do
|
|
!$acc end parallel
|
|
end subroutine redsub_combined
|