34489eb2af
The current implementation of Gogo::pkgpath_for_symbol was written in
a way that allowed two distinct package paths to map to the same
symbol, which could cause collisions at link- time or compile-time.
Switch to a better mangling scheme to insure that we get a unique
packagepath symbol for each package. In the new scheme instead of having
separate mangling schemes for identifiers and package paths, the
main identifier mangler ("go_encode_id") now handles mangling of
both packagepath characters and identifier characters.
The new mangling scheme is more intrusive: "foo/bar.Baz" is mangled as
"foo..z2fbar.Baz" instead of "foo_bar.Baz". To mitigate this, this
patch also adds a demangling capability so that function names
returned from runtime.CallersFrames are converted back to their
original unmangled form.
Changing the pkgpath_for_symbol scheme requires updating a number of
//go:linkname directives and C "__asm__" directives to match the new
scheme, as well as updating the 'gotest' driver (which makes
assumptions about the correct mapping from pkgpath symbol to package
name).
Fixes golang/go#27534.
Reviewed-on: https://go-review.googlesource.com/c/135455
From-SVN: r265510
65 lines
1.6 KiB
Go
65 lines
1.6 KiB
Go
// Copyright 2011 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package debug_test
|
|
|
|
import (
|
|
. "runtime/debug"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
type T int
|
|
|
|
func (t *T) ptrmethod() []byte {
|
|
return Stack()
|
|
}
|
|
func (t T) method() []byte {
|
|
return t.ptrmethod()
|
|
}
|
|
|
|
/*
|
|
The traceback should look something like this, modulo line numbers and hex constants.
|
|
Don't worry much about the base levels, but check the ones in our own package.
|
|
|
|
goroutine 10 [running]:
|
|
runtime/debug.Stack(0x0, 0x0, 0x0)
|
|
/Users/r/go/src/runtime/debug/stack.go:28 +0x80
|
|
runtime/debug.(*T).ptrmethod(0xc82005ee70, 0x0, 0x0, 0x0)
|
|
/Users/r/go/src/runtime/debug/stack_test.go:15 +0x29
|
|
runtime/debug.T.method(0x0, 0x0, 0x0, 0x0)
|
|
/Users/r/go/src/runtime/debug/stack_test.go:18 +0x32
|
|
runtime/debug.TestStack(0xc8201ce000)
|
|
/Users/r/go/src/runtime/debug/stack_test.go:37 +0x38
|
|
testing.tRunner(0xc8201ce000, 0x664b58)
|
|
/Users/r/go/src/testing/testing.go:456 +0x98
|
|
created by testing.RunTests
|
|
/Users/r/go/src/testing/testing.go:561 +0x86d
|
|
*/
|
|
func TestStack(t *testing.T) {
|
|
b := T(0).method()
|
|
lines := strings.Split(string(b), "\n")
|
|
if len(lines) < 6 {
|
|
t.Fatal("too few lines")
|
|
}
|
|
n := 0
|
|
frame := func(line, code string) {
|
|
check(t, lines[n], code)
|
|
n++
|
|
check(t, lines[n], line)
|
|
n++
|
|
}
|
|
n++
|
|
frame("stack.go", "debug.Stack")
|
|
frame("stack_test.go", "ptrmethod")
|
|
frame("stack_test.go", "method")
|
|
frame("stack_test.go", "test.TestStack")
|
|
frame("testing.go", "")
|
|
}
|
|
|
|
func check(t *testing.T, line, has string) {
|
|
if !strings.Contains(line, has) {
|
|
t.Errorf("expected %q in %q", has, line)
|
|
}
|
|
}
|