FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

debug/107058 - gracefully handle unexpected DIE contexts

Browse source 
While the bug is persisting that LTO streaming picks up a CONST_DECL
from an attribute argument on a VAR_DECL which with -fdebug-type-section
refers to a DIE in a type unit we can handle this gracefully, at least
with -fno-checking.  Do so.  The C++ frontend nevetheless should resolve
the CONST_DECL attribute argument to a constant.

	PR debug/107058
	* dwarf2out.cc (dwarf2out_die_ref_for_decl): Gracefully
	handle unexpected but bogus DIE contexts when not checking
	enabled.

	* c-c++-common/pr107058.c: New testcase.
This commit is contained in:
Richard Biener 2024-01-23 09:51:00 +01:00
parent affef534b0
commit e2f3057fc9
2 changed files with 18 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
gcc/dwarf2out.cc
View file

@ -6061,10 +6061,17 @@ dwarf2out_die_ref_for_decl (tree decl, const char **sym,
die = die->die_parent;
/* For the containing CU DIE we compute a die_symbol in
compute_comp_unit_symbol. */
gcc_assert (die->die_tag == DW_TAG_compile_unit
&& die->die_id.die_symbol != NULL);
*sym = die->die_id.die_symbol;
return true;
if (die->die_tag == DW_TAG_compile_unit)
{
gcc_assert (die->die_id.die_symbol != NULL);
*sym = die->die_id.die_symbol;
return true;
}
/* While we can gracefully handle running into say a type unit
we don't really want and consider this a bug. */
if (flag_checking)
gcc_unreachable ();
return false;
}
/* Add a reference of kind ATTR_KIND to a DIE at SYMBOL + OFFSET to DIE. */

7
gcc/testsuite/c-c++-common/pr107058.c Normal file
View file

@ -0,0 +1,7 @@
/* { dg-do compile } */
/* { dg-require-effective-target lto } */
/* { dg-options "-g -fdebug-types-section -flto -fno-checking" } */
/* We should handle the C++ FE issue gracefully with -fno-checking. */
#include "pr50459.c"