FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

openmp: Disallow reduction with var private in containing parallel even on scope [PR102504]

Browse source 
The standard has a restriction:
"A list item that appears in a reduction clause of a scope construct must be
shared in the parallel region to which a corresponding scope region binds."
similar to the restriction for worksharing constructs, but we were checking
it only on worksharing constructs and not for scope and ICEd later on during
omp expansion.

2021-09-29  Jakub Jelinek  <jakub@redhat.com>

	PR middle-end/102504
	* gimplify.c (gimplify_scan_omp_clauses): Use omp_check_private even
	in OMP_SCOPE clauses, not just on worksharing construct clauses.

	* c-c++-common/gomp/scope-4.c: New test.
This commit is contained in:
Jakub Jelinek 2021-09-29 10:17:52 +02:00
parent c6dbe7a56d
commit d3e7bb15e2
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gcc/gimplify.c
View file

@ -10195,7 +10195,7 @@ gimplify_scan_omp_clauses (tree *list_p, gimple_seq *pre_p,
if (outer_ctx)
omp_notice_variable (outer_ctx, decl, true);
if (check_non_private
&& region_type == ORT_WORKSHARE
&& (region_type == ORT_WORKSHARE || code == OMP_SCOPE)
&& (OMP_CLAUSE_CODE (c) != OMP_CLAUSE_REDUCTION
|| decl == OMP_CLAUSE_DECL (c)
|| (TREE_CODE (OMP_CLAUSE_DECL (c)) == MEM_REF

11
gcc/testsuite/c-c++-common/gomp/scope-4.c Normal file
View file

@ -0,0 +1,11 @@
/* PR middle-end/102504 */
/* { dg-do compile } */
int
foo ()
{
int r = 0;
#pragma omp scope reduction(+:r) /* { dg-error "reduction variable 'r' is private in outer context" } */
r++;
return r;
}