From cc1d563887b1fe3183a21572b2ea63466b2bfa3a Mon Sep 17 00:00:00 2001 From: Iain Buclaw Date: Mon, 10 May 2021 12:03:19 +0200 Subject: [PATCH] d: Fix qualifier ignored in alias definition if parentheses are not present Fixes regression where the qualifier was ignored in an alias definition if parentheses were not present. Reviewed-on: https://github.com/dlang/dmd/pull/12504 gcc/d/ChangeLog: * dmd/MERGE: Merge upstream dmd b7d146c4c. --- gcc/d/dmd/MERGE | 2 +- gcc/d/dmd/dsymbolsem.c | 7 +++++-- gcc/testsuite/gdc.test/compilable/test21898.d | 7 +++++++ 3 files changed, 13 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gdc.test/compilable/test21898.d diff --git a/gcc/d/dmd/MERGE b/gcc/d/dmd/MERGE index 86fb308d759..d29d462f42f 100644 --- a/gcc/d/dmd/MERGE +++ b/gcc/d/dmd/MERGE @@ -1,4 +1,4 @@ -0450061c8de71328815da9323bd35c92b37d51d2 +b7d146c4c34469f876a63f26ff19091a7f9d54d7 The first line of this file holds the git revision number of the last merge done from the dlang/dmd repository. diff --git a/gcc/d/dmd/dsymbolsem.c b/gcc/d/dmd/dsymbolsem.c index 33f74edf6ba..7a44ed2c41d 100644 --- a/gcc/d/dmd/dsymbolsem.c +++ b/gcc/d/dmd/dsymbolsem.c @@ -4880,8 +4880,11 @@ static void aliasInstanceSemantic(TemplateInstance *tempinst, Scope *sc, Templat TemplateTypeParameter *ttp = (*tempdecl->parameters)[0]->isTemplateTypeParameter(); Type *ta = isType(tempinst->tdtypes[0]); - Declaration *d = new AliasDeclaration(tempinst->loc, ttp->ident, ta->addMod(tempdecl->onemember->isAliasDeclaration()->type->mod)); - d->storage_class |= STCtemplateparameter; + AliasDeclaration *ad = tempdecl->onemember->isAliasDeclaration(); + + // Note: qualifiers can be in both 'ad.type.mod' and 'ad.storage_class' + Declaration *d = new AliasDeclaration(tempinst->loc, ttp->ident, ta->addMod(ad->type->mod)); + d->storage_class |= STCtemplateparameter | ad->storage_class; dsymbolSemantic(d, sc); paramscope->pop(); diff --git a/gcc/testsuite/gdc.test/compilable/test21898.d b/gcc/testsuite/gdc.test/compilable/test21898.d new file mode 100644 index 00000000000..9ac18b8cb6b --- /dev/null +++ b/gcc/testsuite/gdc.test/compilable/test21898.d @@ -0,0 +1,7 @@ +// https://issues.dlang.org/show_bug.cgi?id=21898 + +alias Works(T) = immutable(T); +alias Fails(T) = immutable T; + +static assert(is(Works!int == immutable int)); +static assert(is(Fails!int == immutable int));