FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

c++: make some cp_trait_kind switch statements exhaustive

Browse source 
This replaces the unreachable default case in some cp_trait_kind
switches with an exhaustive listing of the trait codes that we don't
expect to see, so that when adding a new trait we'll get a helpful
-Wswitch warning if we forget to handle the new trait in a relevant
switch.

gcc/cp/ChangeLog:

	* semantics.cc (trait_expr_value): Make cp_trait_kind switch
	statement exhaustive.
	(finish_trait_expr): Likewise.
	(finish_trait_type): Likewise.
This commit is contained in:
Patrick Palka 2022-10-01 12:21:36 -04:00
parent ca01d25269
commit c051060ade
1 changed files with 25 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
gcc/cp/semantics.cc
View file

@ -12052,10 +12052,15 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2)
case CPTK_REF_CONVERTS_FROM_TEMPORARY:
return ref_xes_from_temporary (type1, type2, /*direct_init=*/false);
default:
gcc_unreachable ();
return false;
#define DEFTRAIT_TYPE(CODE, NAME, ARITY) \
case CPTK_##CODE:
#include "cp-trait.def"
#undef DEFTRAIT_TYPE
/* Type-yielding traits are handled in finish_trait_type. */
break;
}
gcc_unreachable ();
}
/* Returns true if TYPE meets the requirements for the specified KIND,
@ -12204,7 +12209,11 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2)
return error_mark_node;
break;
default:
#define DEFTRAIT_TYPE(CODE, NAME, ARITY) \
case CPTK_##CODE:
#include "cp-trait.def"
#undef DEFTRAIT_TYPE
/* Type-yielding traits are handled in finish_trait_type. */
gcc_unreachable ();
}
@ -12250,9 +12259,19 @@ finish_trait_type (cp_trait_kind kind, tree type1, tree type2)
if (TYPE_REF_P (type1))
type1 = TREE_TYPE (type1);
return cv_unqualified (type1);
default:
gcc_unreachable ();
#define DEFTRAIT_EXPR(CODE, NAME, ARITY) \
case CPTK_##CODE:
#include "cp-trait.def"
#undef DEFTRAIT_EXPR
/* Expression-yielding traits are handled in finish_trait_expr. */
case CPTK_BASES:
case CPTK_DIRECT_BASES:
/* BASES and DIRECT_BASES are handled in finish_bases. */
break;
}
gcc_unreachable ();
}
/* Do-nothing variants of functions to handle pragma FLOAT_CONST_DECIMAL64,