FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ipa-param-manip: Be careful about a reallocating hash_map

Browse source 
PR 103449 revealed that when I was storing result of one hash_map
lookup into another entry in the hash_map, I was still accessing the
entry in the table, which meanwhile could get reallocated, making the
accesses invalid-after-free.

Fixed with the following, which also simplifies the return statement
which must have been true even now.

gcc/ChangeLog:

2021-11-29  Martin Liska  <mliska@suse.cz>
	    Martin Jambor  <mjambor@suse.cz>

	PR ipa/103449
	* ipa-param-manipulation.c
	(ipa_param_body_adjustments::prepare_debug_expressions): Be
	careful about hash_map reallocating itself.  Simpify a return
	which always returns true.
This commit is contained in:
Martin Jambor 2021-11-30 15:35:18 +01:00
parent 26493af58a
commit b3f60112ed
No known key found for this signature in database
GPG key ID: BF63C1BC3FA43540
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gcc/ipa-param-manipulation.c
View file

@ -1279,9 +1279,10 @@ ipa_param_body_adjustments::prepare_debug_expressions (tree dead_ssa)
if (gimple_assign_copy_p (def)
&& TREE_CODE (gimple_assign_rhs1 (def)) == SSA_NAME)
{
tree *d = m_dead_ssa_debug_equiv.get (gimple_assign_rhs1 (def));
m_dead_ssa_debug_equiv.put (dead_ssa, *d);
return (*d != NULL_TREE);
tree d = *m_dead_ssa_debug_equiv.get (gimple_assign_rhs1 (def));
gcc_assert (d);
m_dead_ssa_debug_equiv.put (dead_ssa, d);
return true;
}
tree val