FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR go/59506 (net FAILs (timeout) on alpha)

Browse source 
PR go/59506

net: use DialTimeout in TestSelfConnect

Backported from master repository.

This avoids problems with systems that take a long time to
find out nothing is listening, while still testing for the
self-connect misfeature since a self-connect should be fast.
With this we may be able to remove the test for non-Linux
systems.

Tested (on GNU/Linux) by editing selfConnect in
tcpsock_posix.go to always return false and verifying that
TestSelfConnect then fails with and without this change.

Idea from Uros Bizjak.

From-SVN: r206224
This commit is contained in:
Ian Lance Taylor 2013-12-27 21:42:26 +00:00
parent 4de67111df
commit afc8adc88f
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
libgo/go/net/dial_test.go
View file

@ -147,7 +147,7 @@ func TestSelfConnect(t *testing.T) {
n = 100 n = 100
} }
for i := 0; i < n; i++ { for i := 0; i < n; i++ {
c, err := Dial("tcp", addr) c, err := DialTimeout("tcp", addr, time.Millisecond)
if err == nil { if err == nil {
c.Close() c.Close()
t.Errorf("#%d: Dial %q succeeded", i, addr) t.Errorf("#%d: Dial %q succeeded", i, addr)