fix PVS studio reported bugs

2020-04-17  Richard Biener  <rguenther@suse.de>

	PR other/94629
	* cgraphclones.c (cgraph_node::create_clone): Remove duplicate
	initialization.
	* dwarf2out.c (dw_val_equal_p): Fix pasto in
	dw_val_class_vms_delta comparison.
	* optabs.c (expand_binop_directly): Fix pasto in commutation
	check.
	* tree-ssa-sccvn.c (vn_reference_lookup_pieces): Fix pasto in
	initialization.
This commit is contained in:
Richard Biener 2020-04-17 09:19:32 +02:00
parent c41884a092
commit a64468a303
5 changed files with 15 additions and 4 deletions

View file

@ -1,3 +1,15 @@
2020-04-17 Richard Biener <rguenther@suse.de>
PR other/94629
* cgraphclones.c (cgraph_node::create_clone): Remove duplicate
initialization.
* dwarf2out.c (dw_val_equal_p): Fix pasto in
dw_val_class_vms_delta comparison.
* optabs.c (expand_binop_directly): Fix pasto in commutation
check.
* tree-ssa-sccvn.c (vn_reference_lookup_pieces): Fix pasto in
initialization.
2020-04-17 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/94618

View file

@ -404,7 +404,6 @@ cgraph_node::create_clone (tree new_decl, profile_count prof_count,
new_node->tp_first_run = tp_first_run;
new_node->tm_clone = tm_clone;
new_node->icf_merged = icf_merged;
new_node->merged_comdat = merged_comdat;
new_node->thunk = thunk;
new_node->unit_id = unit_id;
new_node->merged_comdat = merged_comdat;

View file

@ -1479,7 +1479,7 @@ dw_val_equal_p (dw_val_node *a, dw_val_node *b)
case dw_val_class_vms_delta:
return (!strcmp (a->v.val_vms_delta.lbl1, b->v.val_vms_delta.lbl1)
&& !strcmp (a->v.val_vms_delta.lbl1, b->v.val_vms_delta.lbl1));
&& !strcmp (a->v.val_vms_delta.lbl2, b->v.val_vms_delta.lbl2));
case dw_val_class_discr_value:
return (a->v.val_discr_value.pos == b->v.val_discr_value.pos

View file

@ -1050,7 +1050,7 @@ expand_binop_directly (enum insn_code icode, machine_mode mode, optab binoptab,
commutative_p = commutative_optab_p (binoptab);
if (commutative_p
&& GET_MODE (xop0) != xmode0 && GET_MODE (xop1) != xmode1
&& GET_MODE (xop0) == xmode1 && GET_MODE (xop1) == xmode1)
&& GET_MODE (xop0) == xmode1 && GET_MODE (xop1) == xmode0)
std::swap (xop0, xop1);
/* If we are optimizing, force expensive constants into a register. */

View file

@ -3446,7 +3446,7 @@ vn_reference_lookup_pieces (tree vuse, alias_set_type set,
= valueize_refs (shared_lookup_references);
vr1.type = type;
vr1.set = set;
vr1.set = base_set;
vr1.base_set = base_set;
vr1.hashcode = vn_reference_compute_hash (&vr1);
if ((cst = fully_constant_vn_reference_p (&vr1)))
return cst;