From 96deddca2e535d09db1d244a96a1efc20e24b673 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Tue, 4 May 2021 15:26:58 -0600 Subject: [PATCH] libcc1: avoid extra string copies PR c/94669 points out that a couple of spots in libcc1 take a std::string where a reference would do. This changes these spots to take a const char *, to reduce the number of copies. libcc1 PR c/94669 * compiler.hh (compiler_driver_filename): Take const char *. (compiler_triplet_regexp): Likewise. --- libcc1/compiler.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libcc1/compiler.hh b/libcc1/compiler.hh index 638f7c09f63..d10d409f9d3 100644 --- a/libcc1/compiler.hh +++ b/libcc1/compiler.hh @@ -58,7 +58,7 @@ namespace cc1_plugin char *find (const char *base, std::string &compiler) const override; - compiler_triplet_regexp (bool v, std::string triplet_regexp) + compiler_triplet_regexp (bool v, const char *triplet_regexp) : compiler (v), triplet_regexp_ (triplet_regexp) { } @@ -72,7 +72,7 @@ namespace cc1_plugin public: char *find (const char *base, std::string &compiler) const override; - compiler_driver_filename (bool v, std::string driver_filename) + compiler_driver_filename (bool v, const char *driver_filename) : compiler (v), driver_filename_ (driver_filename) { }