FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

compiler: Don't crash on invalid arithmetic ops.

Browse source 
The gofrontend would crash after hitting an unreachable state while
    trying to determine the type of an arithmetic expression involving
    non-numeric values.  Instead of crashing, it should fail gracefully
    if the relevant error is already reported.
    
    Fixes golang/go#11537.
    
    Reviewed-on: https://go-review.googlesource.com/13793

From-SVN: r227227
This commit is contained in:
Ian Lance Taylor 2015-08-26 19:18:51 +00:00
parent e4f019d316
commit 8a256400f5
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gcc/go/gofrontend/MERGE
View file

@ -1,4 +1,4 @@
d5e6af4e6dd456075a1ec1c03d0dc41cbea5eb36
cd5362c7bb0b207f484a8dfb8db229fd2bffef09
The first line of this file holds the git revision number of the last
merge done from the gofrontend repository.

6
gcc/go/gofrontend/expressions.cc
View file

@ -15150,7 +15150,11 @@ Numeric_constant::set_type(Type* type, bool issue_error, Location loc)
else if (type->complex_type() != NULL)
ret = this->check_complex_type(type->complex_type(), issue_error, loc);
else
go_unreachable();
{
ret = false;
if (issue_error)
go_assert(saw_errors());
}
if (ret)
this->type_ = type;
return ret;