FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

testsuite: Fix weak_undefined handling on Darwin

Browse source 
The patch that introduced the weak_undefined effective-target keyword
and corresponding dg-add-options support

commit 378ec7b87a
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Thu Mar 23 00:45:05 2023 -0300

    [testsuite] test for weak_undefined support and add options

badly broke the affected tests on macOS like so:

ERROR: gcc.dg/addr_equal-1.c: unknown dg option: 89 for " dg-add-options 5 weak_undefined "
ERROR: gcc.dg/addr_equal-1.c: unknown dg option: 89 for " dg-add-options 5 weak_undefined "

add_options_for_weak_undefined tries to call an non-existant proc "89".
Even after fixing this by escaping the brackets, two tests still failed to
link since they lacked the corresponding calls do dg-add-options
weak_undefined.

Tested on x86_64-apple-darwin20.6.0 and i386-pc-solaris2.11.

2023-03-27  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	gcc/testsuite:
	* lib/target-supports.exp (add_options_for_weak_undefined): Escape
	brackets.
	* gcc.dg/visibility-22.c: Add weak_undefined options.

	libgomp:
	* testsuite/libgomp.oacc-c-c++-common/routine-nohost-2.c: Add
	weak_undefined options.
This commit is contained in:
Rainer Orth 2023-03-28 10:40:05 +02:00
parent 304c7d44a2
commit 8443f42f05
3 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
gcc/testsuite/gcc.dg/visibility-22.c
View file

@ -3,6 +3,7 @@
/* { dg-require-visibility "" } */ /* { dg-require-visibility "" } */
/* { dg-require-effective-target weak_undefined } */ /* { dg-require-effective-target weak_undefined } */
/* { dg-options "-O2 -fPIC" { target fpic } } */ /* { dg-options "-O2 -fPIC" { target fpic } } */
/* { dg-add-options weak_undefined } */
extern void foo () __attribute__((weak,visibility("hidden"))); extern void foo () __attribute__((weak,visibility("hidden")));
int int

2
gcc/testsuite/lib/target-supports.exp
View file

@ -361,7 +361,7 @@ proc check_weak_available { } {
proc add_options_for_weak_undefined { flags } { proc add_options_for_weak_undefined { flags } {
if { [istarget *-*-darwin*] } { if { [istarget *-*-darwin*] } {
lappend flags "-Wl,-undefined,dynamic_lookup" lappend flags "-Wl,-undefined,dynamic_lookup"
if { [istarget *-*-darwin[89]*] } { if { [istarget *-*-darwin\[89\]*] } {
lappend flags "-Wl,-flat_namespace" lappend flags "-Wl,-flat_namespace"
} }
} }

1
libgomp/testsuite/libgomp.oacc-c-c++-common/routine-nohost-2.c
View file

@ -8,6 +8,7 @@
/* { dg-additional-sources routine-nohost-2_2.c } */ /* { dg-additional-sources routine-nohost-2_2.c } */
/* { dg-additional-options "-fno-inline" } for stable results regarding OpenACC 'routine'. */ /* { dg-additional-options "-fno-inline" } for stable results regarding OpenACC 'routine'. */
/* { dg-add-options weak_undefined } */
#include <assert.h> #include <assert.h>
#include <openacc.h> #include <openacc.h>