FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gimple: Return fnspec only for replaceable new/delete operators called from new/delete [PR98130]

Browse source 
As mentioned in the PR, we shouldn't treat non-replaceable operator
new/delete (e.g. with the placement new) as replaceable ones.

There is some pending discussion that perhaps operator delete called from
delete if not replaceable should return some other fnspec, but can we handle
that incrementally, fix this wrong-code and then deal with a missed
optimization?  I really don't know what exactly should be returned.

2020-12-04  Jakub Jelinek  <jakub@redhat.com>

	PR c++/98130
	* gimple.c (gimple_call_fnspec): Only return ".co " for replaceable
	operator delete or ".mC" for replaceable operator new called from
	new/delete.

	* g++.dg/opt/pr98130.C: New test.
This commit is contained in:
Jakub Jelinek 2020-12-04 19:10:56 +01:00
parent ac2a6962b9
commit 78c4a9fece
2 changed files with 27 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gcc/gimple.c
View file

@ -1514,11 +1514,12 @@ gimple_call_fnspec (const gcall *stmt)
such operator, then we can treat it as free. */
if (fndecl
&& DECL_IS_OPERATOR_DELETE_P (fndecl)
&& DECL_IS_REPLACEABLE_OPERATOR (fndecl)
&& gimple_call_from_new_or_delete (stmt))
return ".co ";
/* Similarly operator new can be treated as malloc. */
if (fndecl
&& DECL_IS_OPERATOR_NEW_P (fndecl)
&& DECL_IS_REPLACEABLE_OPERATOR_NEW_P (fndecl)
&& gimple_call_from_new_or_delete (stmt))
return "mC";
return "";

25
gcc/testsuite/g++.dg/opt/pr98130.C Normal file
View file

@ -0,0 +1,25 @@
// PR c++/98130
// { dg-do run { target c++11 } }
// { dg-options "-O2" }
#include <new>
typedef int *T;
static unsigned char storage[sizeof (T)] alignas (T);
static T *p = (T *) storage;
static inline __attribute__((__always_inline__)) void
foo (T value)
{
new (p) T(value);
}
int
main ()
{
int a;
foo (&a);
if (!*p)
__builtin_abort ();
}