From 75f49cf82e06971b066b4f440256004775603752 Mon Sep 17 00:00:00 2001 From: Gaius Mulley Date: Thu, 1 Feb 2024 10:24:02 +0000 Subject: [PATCH] PR modula2/111627 defend against ICE Although PR 111627 can be fixed by renaming testsuite modules it highlighted that a possible ICE can occur if a malformed implementation module is actually a program module. This small patch defends against this ICE and checks to see whether the module is a DefImp before testing IsDefinitionForC. gcc/m2/ChangeLog: PR modula2/111627 PR modula2/112506 * gm2-compiler/M2Comp.mod (Pass0CheckMod): Test IsDefImp before checking IsDefinitionForC. Signed-off-by: Gaius Mulley --- gcc/m2/gm2-compiler/M2Comp.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/m2/gm2-compiler/M2Comp.mod b/gcc/m2/gm2-compiler/M2Comp.mod index a97f0edd648..c10c301cbde 100644 --- a/gcc/m2/gm2-compiler/M2Comp.mod +++ b/gcc/m2/gm2-compiler/M2Comp.mod @@ -869,7 +869,7 @@ BEGIN END ELSIF GenModuleList THEN - IF NOT IsDefinitionForC (sym) + IF IsDefImp (sym) AND (NOT IsDefinitionForC (sym)) THEN (* The implementation module is only useful if -fgen-module-list= is used (to gather all dependencies). Note that we do not insist