FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix version negotiation in libcc1 plugins

Browse source 
This fixes version negotiation in the libcc1 plugins.  It's done in a
simple way: the version number from the context object is now passed
to base_gdb_plugin.

The idea behind this is that when the client (gdb) requests version N,
the plugin should respond with the newest version that it knows of
that is backward compatible to N.  That is, the connection can be
upgraded.  Note that the protocol does not change much, and no
backward incompatibilities have ever been needed.

The C plugin is also changed to advertise GCC_C_FE_VERSION_1.

The version negotiation approach should of course be documented, but I
did that in a subsequent patch, in order to only have one patch
touching the 'include' directory and thus needing a merge to
binutils-gdb.

libcc1

	* libcp1.cc (libcp1::libcp1): Use FE version number from context.
	* libcc1.cc (libcc1::libcc1): Use FE version number from context.
	(c_vtable): Use GCC_C_FE_VERSION_1.
This commit is contained in:
Tom Tromey 2024-02-22 19:36:53 -07:00
parent fd846abc2d
commit 54137725cf
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libcc1/libcc1.cc
View file

@ -54,7 +54,7 @@ struct libcc1 : public cc1_plugin::base_gdb_plugin<gcc_c_context>
libcc1::libcc1 (const gcc_c_fe_vtable *cv)
: cc1_plugin::base_gdb_plugin<gcc_c_context> ("libcc1plugin",
C_COMPILER_NAME,
GCC_C_FE_VERSION_1)
cv->c_version)
{
c_ops = cv;
}
@ -108,7 +108,7 @@ set_callbacks (struct gcc_c_context *s,
static const struct gcc_c_fe_vtable c_vtable =
{
GCC_C_FE_VERSION_0,
GCC_C_FE_VERSION_1,
set_callbacks,
#define GCC_METHOD0(R, N) \

2
libcc1/libcp1.cc
View file

@ -55,7 +55,7 @@ struct libcp1 : public cc1_plugin::base_gdb_plugin<gcc_cp_context>
libcp1::libcp1 (const gcc_cp_fe_vtable *cv)
: cc1_plugin::base_gdb_plugin<gcc_cp_context> ("libcp1plugin",
CP_COMPILER_NAME,
GCC_CP_FE_VERSION_0)
cv->cp_version)
{
cp_ops = cv;
}