From 4fce678f8afd3d667becf67576b7d88d07670805 Mon Sep 17 00:00:00 2001 From: Jason Merrill Date: Wed, 14 Nov 2012 20:53:23 -0500 Subject: [PATCH] re PR c++/55275 (abi_tag attribute doesn't work on explicit specializations of class templates) PR c++/55275 * pt.c (maybe_process_partial_specialization): Update DECL_SOURCE_LOCATION for new specializations. From-SVN: r193524 --- gcc/cp/ChangeLog | 6 ++++ gcc/cp/pt.c | 2 ++ gcc/testsuite/g++.dg/abi/abi-tag3.C | 36 +++++++++++++++++++ gcc/testsuite/g++.dg/cpp0x/pr31439.C | 4 +-- gcc/testsuite/g++.dg/template/crash98.C | 4 +-- .../type_traits/add_unsigned_integer_neg.cc | 3 +- .../remove_unsigned_integer_neg.cc | 3 +- 7 files changed, 52 insertions(+), 6 deletions(-) create mode 100644 gcc/testsuite/g++.dg/abi/abi-tag3.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index d382a04f895..bb5e4bad4a7 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2012-11-13 Jason Merrill + + PR c++/55275 + * pt.c (maybe_process_partial_specialization): Update + DECL_SOURCE_LOCATION for new specializations. + 2012-11-14 Paolo Carlini PR c++/55323 diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c index 802c79b8755..3c9bb56c66b 100644 --- a/gcc/cp/pt.c +++ b/gcc/cp/pt.c @@ -838,6 +838,7 @@ maybe_process_partial_specialization (tree type) { check_specialization_namespace (CLASSTYPE_TI_TEMPLATE (type)); SET_CLASSTYPE_TEMPLATE_SPECIALIZATION (type); + DECL_SOURCE_LOCATION (TYPE_MAIN_DECL (type)) = input_location; if (processing_template_decl) { if (push_template_decl (TYPE_MAIN_DECL (type)) @@ -934,6 +935,7 @@ maybe_process_partial_specialization (tree type) have one level of template argument for the innermost class template. */ SET_CLASSTYPE_TEMPLATE_SPECIALIZATION (type); + DECL_SOURCE_LOCATION (TYPE_MAIN_DECL (type)) = input_location; CLASSTYPE_TI_ARGS (type) = INNERMOST_TEMPLATE_ARGS (CLASSTYPE_TI_ARGS (type)); } diff --git a/gcc/testsuite/g++.dg/abi/abi-tag3.C b/gcc/testsuite/g++.dg/abi/abi-tag3.C new file mode 100644 index 00000000000..05fd58e9402 --- /dev/null +++ b/gcc/testsuite/g++.dg/abi/abi-tag3.C @@ -0,0 +1,36 @@ +// An explicit specialization doesn't get the tag from its template unless +// it is specified there, too. + +// { dg-final { scan-assembler "_ZN3FooB5cxx11IcE1fEv" } } +template +struct __attribute ((abi_tag("cxx11"))) Foo +{ + int f(); +}; + +// { dg-final { scan-assembler "_ZN3FooB5cxx11IiE1fEv" } } +template<> +struct +__attribute ((abi_tag("cxx11"))) +Foo +{ + int f(); +}; + +// { dg-final { scan-assembler "_ZN3FooIdE1fEv" } } +template<> +struct +Foo +{ + int f(); +}; + +int main() +{ + Foo f; + f.f(); + Foo f1; + f1.f(); + Foo f2; + f2.f(); +} diff --git a/gcc/testsuite/g++.dg/cpp0x/pr31439.C b/gcc/testsuite/g++.dg/cpp0x/pr31439.C index 9d22b56c2f8..c64bc3145b6 100644 --- a/gcc/testsuite/g++.dg/cpp0x/pr31439.C +++ b/gcc/testsuite/g++.dg/cpp0x/pr31439.C @@ -1,7 +1,7 @@ // { dg-options "-std=c++0x" } -template struct A; // { dg-error "declaration" } +template struct A; -template struct A<> {}; // { dg-error "not used in partial specialization|anonymous" } +template struct A<> {}; // { dg-error "not used in partial specialization|anonymous|declaration" } template struct A : A {}; // { dg-error "incomplete type" } diff --git a/gcc/testsuite/g++.dg/template/crash98.C b/gcc/testsuite/g++.dg/template/crash98.C index e3c224df1d9..a79ab02f695 100644 --- a/gcc/testsuite/g++.dg/template/crash98.C +++ b/gcc/testsuite/g++.dg/template/crash98.C @@ -1,8 +1,8 @@ // PR c++/43630 -template < typename > struct A; // { dg-error "declaration" } +template < typename > struct A; -template < typename > struct A < int > // { dg-error "not used|template\\-parameter" } +template < typename > struct A < int > // { dg-error "not used|template\\-parameter|declaration" } { int i; int f (); diff --git a/libstdc++-v3/testsuite/ext/type_traits/add_unsigned_integer_neg.cc b/libstdc++-v3/testsuite/ext/type_traits/add_unsigned_integer_neg.cc index b976de022b4..bdd27cc85e1 100644 --- a/libstdc++-v3/testsuite/ext/type_traits/add_unsigned_integer_neg.cc +++ b/libstdc++-v3/testsuite/ext/type_traits/add_unsigned_integer_neg.cc @@ -36,4 +36,5 @@ int main() } // { dg-error "invalid use of incomplete" "" { target *-*-* } 28 } -// { dg-error "declaration of" "" { target *-*-* } 63 } +// { dg-error "declaration of" "" { target *-*-* } 98 } +// { dg-error "declaration of" "" { target *-*-* } 101 } diff --git a/libstdc++-v3/testsuite/ext/type_traits/remove_unsigned_integer_neg.cc b/libstdc++-v3/testsuite/ext/type_traits/remove_unsigned_integer_neg.cc index bd5c4237e02..099178ef1ce 100644 --- a/libstdc++-v3/testsuite/ext/type_traits/remove_unsigned_integer_neg.cc +++ b/libstdc++-v3/testsuite/ext/type_traits/remove_unsigned_integer_neg.cc @@ -36,4 +36,5 @@ int main() } // { dg-error "invalid use of incomplete" "" { target *-*-* } 28 } -// { dg-error "declaration of" "" { target *-*-* } 106 } +// { dg-error "declaration of" "" { target *-*-* } 141 } +// { dg-error "declaration of" "" { target *-*-* } 144 }