FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix oversight in handling of reverse SSO in SRA pass

Browse source 
The scalar storage order does not apply to pointer and vector components.

gcc/
	PR tree-optimization/101626
	* tree-sra.c (propagate_subaccesses_from_rhs): Do not set the
	reverse scalar storage order on a pointer or vector component.

gcc/testsuite/
	* gcc.dg/sso-15.c: New test.
This commit is contained in:
Eric Botcazou 2021-08-05 10:21:30 +02:00
parent ac8a2fbedf
commit 4e3129b0ca
2 changed files with 40 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
gcc/testsuite/gcc.dg/sso-15.c Normal file
View file

@ -0,0 +1,36 @@
/* { dg-do compile } */
/* { dg-options "-O2" } */
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
#define REV_ENDIANNESS __attribute__((scalar_storage_order("big-endian")))
#else
#define REV_ENDIANNESS __attribute__((scalar_storage_order("little-endian")))
#endif
struct X { int *p; } REV_ENDIANNESS;
struct X x;
struct X __attribute__((noinline)) foo (int *p)
{
struct X x;
x.p = p;
return x;
}
void __attribute((noinline)) bar (void)
{
*x.p = 1;
}
extern void abort (void);
int main (void)
{
int i = 0;
x = foo(&i);
bar();
if (i != 1)
abort ();
return 0;
}

5
gcc/tree-sra.c
View file

@ -2790,7 +2790,10 @@ propagate_subaccesses_from_rhs (struct access *lacc, struct access *racc)
{
/* We are about to change the access type from aggregate to scalar,
so we need to put the reverse flag onto the access, if any. */
const bool reverse = TYPE_REVERSE_STORAGE_ORDER (lacc->type);
const bool reverse
= TYPE_REVERSE_STORAGE_ORDER (lacc->type)
&& !POINTER_TYPE_P (racc->type)
&& !VECTOR_TYPE_P (racc->type);
tree t = lacc->base;
lacc->type = racc->type;