FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

analyzer: fix ICE on floating-point bounds [PR111881]

Browse source 
gcc/analyzer/ChangeLog:
	PR analyzer/111881
	* constraint-manager.cc (bound::ensure_closed): Assert that
	m_constant has integral type.
	(range::add_bound): Bail out on floating point constants.

gcc/testsuite/ChangeLog:
	PR analyzer/111881
	* c-c++-common/analyzer/conditionals-pr111881.c: New test.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>
This commit is contained in:
David Malcolm 2024-02-27 08:36:58 -05:00
parent a82ecdeacf
commit 43ad6ce601
2 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gcc/analyzer/constraint-manager.cc
View file

@ -124,10 +124,12 @@ bound::ensure_closed (enum bound_kind bound_kind)
For example, convert 3 < x into 4 <= x,
and convert x < 5 into x <= 4. */
gcc_assert (CONSTANT_CLASS_P (m_constant));
gcc_assert (INTEGRAL_TYPE_P (TREE_TYPE (m_constant)));
m_constant = fold_build2 (bound_kind == BK_UPPER ? MINUS_EXPR : PLUS_EXPR,
TREE_TYPE (m_constant),
m_constant, integer_one_node);
gcc_assert (CONSTANT_CLASS_P (m_constant));
gcc_assert (INTEGRAL_TYPE_P (TREE_TYPE (m_constant)));
m_closed = true;
}
}
@ -306,6 +308,10 @@ range::above_upper_bound (tree rhs_const) const
bool
range::add_bound (bound b, enum bound_kind bound_kind)
{
/* Bail out on floating point constants. */
if (!INTEGRAL_TYPE_P (TREE_TYPE (b.m_constant)))
return true;
b.ensure_closed (bound_kind);
switch (bound_kind)

8
gcc/testsuite/c-c++-common/analyzer/conditionals-pr111881.c Normal file
View file

@ -0,0 +1,8 @@
/* Verify we don't ICE on certain float conditionals. */
/* { dg-additional-options "-Ofast" } */
int test_pr111881 (float sf1)
{
return sf1 <= 0 || sf1 >= 7 ? 0 : sf1;
}