FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

contrib/gcc-changelog: Skip over review lines

Browse source 
git-check-commit.py does not know about "Reviewed-by",
"Reviewed-on", and "Signed-off-by" lines and hence it
expects those lines which follow the ChangeLog entries
to be indented by a tab.

This commit makes the script skip those lines.  No further
processing is attempted because the review information
is not part of the ChangeLogs.

contrib/

2020-05-20  Frederik Harwath  <frederik@codesourcery.com>

	* gcc-changelog/git_commit.py: Skip over lines starting
	with "Reviewed-by: ", "Reviewed-on: ", or "Signed-off-by: "
This commit is contained in:
Frederik Harwath 2020-05-19 11:15:28 +02:00
parent 93db1f8055
commit 3bcaf16edd
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
contrib/ChangeLog
View file

@ -1,3 +1,8 @@
2020-05-20 Frederik Harwath <frederik@codesourcery.com>
* gcc-changelog/git_commit.py: Skip over lines starting
with "Reviewed-by: ", "Reviewed-on: ", or "Signed-off-by: "
2020-05-20 Martin Liska <mliska@suse.cz>
* gcc-changelog/git_check_commit.py: Change

11
contrib/gcc-changelog/git_commit.py
View file

@ -151,7 +151,12 @@ LINE_LIMIT = 100
TAB_WIDTH = 8
CO_AUTHORED_BY_PREFIX = 'co-authored-by: '
CHERRY_PICK_PREFIX = '(cherry picked from commit '
REVIEWED_BY_PREFIX = 'reviewed-by: '
REVIEWED_ON_PREFIX = 'reviewed-on: '
SIGNED_OFF_BY_PREFIX = 'signed-off-by: '
REVIEW_PREFIXES = (REVIEWED_BY_PREFIX, REVIEWED_ON_PREFIX,\
SIGNED_OFF_BY_PREFIX)
class Error:
def __init__(self, message, line=None):
@ -345,11 +350,15 @@ class GitCommit:
else:
pr_line = line.lstrip()
if line.lower().startswith(CO_AUTHORED_BY_PREFIX):
lowered_line = line.lower()
if lowered_line.startswith(CO_AUTHORED_BY_PREFIX):
name = line[len(CO_AUTHORED_BY_PREFIX):]
author = self.format_git_author(name)
self.co_authors.append(author)
continue
elif lowered_line.startswith(REVIEW_PREFIXES):
continue
elif line.startswith(CHERRY_PICK_PREFIX):
continue