FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

reassoc: Fold some statements [PR108819]

Browse source 
This spot in update_ops can replace one or both of the assign operands with
constants, creating 1 & 1 and similar expressions which can confuse later
passes until they are folded.  Rather than folding both constants by hand
and also handling swapping of operands for commutative ops if the first one
is constant and second one is not, the following patch just uses
fold_stmt_inplace to do that.  I think we shouldn't fold more than the
single statement because that could screw up the rest of the pass, we'd have
to mark all those with uids, visited and the like.

2023-02-18  Jakub Jelinek  <jakub@redhat.com>

	PR tree-optimization/108819
	* tree-ssa-reassoc.cc (update_ops): Fold new stmt in place.

	* gcc.dg/pr108819.c: New test.
This commit is contained in:
Jakub Jelinek 2023-02-18 12:40:49 +01:00
parent 3c135697fd
commit 32b5875c91
2 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
gcc/testsuite/gcc.dg/pr108819.c Normal file
View file

@ -0,0 +1,19 @@
/* PR tree-optimization/108819 */
/* { dg-do compile } */
/* { dg-options "-O1 -fno-tree-ccp -fno-tree-forwprop" } */
int a, b;
int
main ()
{
int d = 1;
for (; b; b++)
if (a < 1)
while (d <= a && a <= 0UL)
{
int *e = &d;
*e = 0;
}
return 0;
}

3
gcc/tree-ssa-reassoc.cc
View file

@ -4687,6 +4687,9 @@ update_ops (tree var, enum tree_code code, const vec<operand_entry *> &ops,
gimple_set_uid (g, gimple_uid (stmt));
gimple_set_visited (g, true);
gsi_insert_before (&gsi, g, GSI_SAME_STMT);
gimple_stmt_iterator gsi2 = gsi_for_stmt (g);
if (fold_stmt_inplace (&gsi2))
update_stmt (g);
}
return var;
}