FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid undefined behaviour in build_option_suggestions

Browse source 
The inner loop in build_option_suggestions uses OPTION to take the
address of OPTB and use it across iterations, which is undefined
behaviour since OPTB is defined within the loop.  Pull it outside the
loop to make this defined.

gcc/ChangeLog:

	* opt-suggestions.cc
	(option_proposer::build_option_suggestions): Pull OPTB
	definition out of the innermost loop.

(cherry picked from commit e0d997e913f811ecf4b3e10891e6a4aab5b38a31)
This commit is contained in:
Siddhesh Poyarekar 2024-07-19 12:44:32 -04:00
parent 94e4661fee
commit 2eca8a9548
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gcc/opt-suggestions.cc
View file

@ -167,9 +167,9 @@ option_proposer::build_option_suggestions (const char *prefix)
add_misspelling_candidates (m_option_suggestions, option,
opt_text);
struct cl_option optb;
for (int j = 0; sanitizer_opts[j].name != NULL; ++j)
{
struct cl_option optb;
/* -fsanitize=all is not valid, only -fno-sanitize=all.
So don't register the positive misspelling candidates
for it. */