FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix modref_eaf_analysis::analyze_ssa_name handling of values dereferenced to function call parameters

Browse source 
modref_eaf_analysis::analyze_ssa_name misinterprets EAF flags.  If dereferenced
parameter is passed (to map_iterator in the testcase) it can be returned
indirectly which in turn makes it to escape into the next function call.

	PR ipa/115033

gcc/ChangeLog:

	* ipa-modref.cc (modref_eaf_analysis::analyze_ssa_name): Fix checking of
	EAF flags when analysing values dereferenced as function parameters.

gcc/testsuite/ChangeLog:

	* gcc.c-torture/execute/pr115033.c: New test.

(cherry picked from commit cf8ffc58aad3127031c229a75cc4b99c8ace25e0)
This commit is contained in:
Jan Hubicka 2024-07-22 18:08:08 +02:00
parent f2e9808479
commit 27ef3a0779
2 changed files with 39 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gcc/ipa-modref.cc
View file

@ -2571,8 +2571,10 @@ modref_eaf_analysis::analyze_ssa_name (tree name, bool deferred)
int call_flags = deref_flags
(gimple_call_arg_flags (call, i), ignore_stores);
if (!ignore_retval && !(call_flags & EAF_UNUSED)
&& !(call_flags & EAF_NOT_RETURNED_DIRECTLY)
&& !(call_flags & EAF_NOT_RETURNED_INDIRECTLY))
&& (call_flags & (EAF_NOT_RETURNED_DIRECTLY
| EAF_NOT_RETURNED_INDIRECTLY))
!= (EAF_NOT_RETURNED_DIRECTLY
| EAF_NOT_RETURNED_INDIRECTLY))
merge_call_lhs_flags (call, i, name, false, true);
if (ecf_flags & (ECF_CONST | ECF_NOVOPS))
m_lattice[index].merge_direct_load ();

35
gcc/testsuite/gcc.c-torture/execute/pr115033.c Normal file
View file

@ -0,0 +1,35 @@
typedef struct func
{
int *a;
}func;
__attribute__((noinline))
void ff(struct func *t)
{
*(t->a) = 0;
}
typedef struct mapped_iterator {
func F;
}mapped_iterator;
__attribute__((noinline))
mapped_iterator map_iterator(func F) {
mapped_iterator t = {F};
return t;
}
void map_to_vector(func *F) {
mapped_iterator t = map_iterator(*F);
ff(&t.F);
}
int main() {
int resultIsStatic = 1;
func t ={&resultIsStatic};
map_to_vector(&t);
if (resultIsStatic)
__builtin_trap();
__builtin_exit(0);
}