FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

c++: Make -Wunknown-pragmas controllable by #pragma GCC diagnostic [PR89038]

Browse source 
As noted on the PR, commit r13-1544, the fix for PR53431, did not handle
the specific case of -Wunknown-pragmas, because that warning is issued
during preprocessing, but not by libcpp directly (it comes from the
cb_def_pragma callback).  Address that by handling this pragma in
addition to libcpp pragmas during the early pragma handler.

gcc/c-family/ChangeLog:

	PR c++/89038
	* c-pragma.cc (handle_pragma_diagnostic_impl):  Handle
	-Wunknown-pragmas during early processing.

gcc/testsuite/ChangeLog:

	PR c++/89038
	* c-c++-common/cpp/Wunknown-pragmas-1.c: New test.
This commit is contained in:
Lewis Hyatt 2023-10-18 12:37:08 -04:00
parent 202a214d68
commit 19cc4b9d74
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gcc/c-family/c-pragma.cc
View file

@ -963,7 +963,8 @@ handle_pragma_diagnostic_impl ()
/* option_string + 1 to skip the initial '-' */
unsigned int option_index = find_opt (data.option_str + 1, lang_mask);
if (early && !c_option_is_from_cpp_diagnostics (option_index))
if (early && !(c_option_is_from_cpp_diagnostics (option_index)
|| option_index == OPT_Wunknown_pragmas))
return;
if (option_index == OPT_SPECIAL_unknown)

13
gcc/testsuite/c-c++-common/cpp/Wunknown-pragmas-1.c Normal file
View file

@ -0,0 +1,13 @@
/* PR c++/89038 */
/* { dg-additional-options "-Wunknown-pragmas" } */
#pragma oops /* { dg-warning "-:-Wunknown-pragmas" } */
#pragma GGC diagnostic push /* { dg-warning "-:-Wunknown-pragmas" } */
#pragma GCC diagnostics push /* { dg-warning "-:-Wunknown-pragmas" } */
/* Test we can disable the warnings. */
#pragma GCC diagnostic ignored "-Wunknown-pragmas"
#pragma oops /* { dg-bogus "-:-Wunknown-pragmas" } */
#pragma GGC diagnostic push /* { dg-bogus "-:-Wunknown-pragmas" } */
#pragma GCC diagnostics push /* { dg-bogus "-:-Wunknown-pragmas" } */