diff --git a/libbacktrace/ChangeLog b/libbacktrace/ChangeLog index e7fdfd8e940..8894446a75b 100644 --- a/libbacktrace/ChangeLog +++ b/libbacktrace/ChangeLog @@ -1,3 +1,8 @@ +2018-11-28 Tom de Vries + + * dwarf.c (read_abbrevs): Fix handling of abbrevs->abbrevs allocation + failure. + 2018-11-27 Tom de Vries * mmap.c (backtrace_vector_release): Same. diff --git a/libbacktrace/dwarf.c b/libbacktrace/dwarf.c index 4e93f120820..34543747c8f 100644 --- a/libbacktrace/dwarf.c +++ b/libbacktrace/dwarf.c @@ -1105,13 +1105,13 @@ read_abbrevs (struct backtrace_state *state, uint64_t abbrev_offset, if (num_abbrevs == 0) return 1; - abbrevs->num_abbrevs = num_abbrevs; abbrevs->abbrevs = ((struct abbrev *) backtrace_alloc (state, num_abbrevs * sizeof (struct abbrev), error_callback, data)); if (abbrevs->abbrevs == NULL) return 0; + abbrevs->num_abbrevs = num_abbrevs; memset (abbrevs->abbrevs, 0, num_abbrevs * sizeof (struct abbrev)); num_abbrevs = 0;