FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

re PR c/45969 (ICE in build_binary_op, at c-typeck.c:9833)

Browse source 
PR c/45969
	* c-typeck.c (build_binary_op): Don't try to compute a semantic
	type with excess precision for boolean operations.

testsuite:
	* gcc.c-torture/compile/pr45969-1.c: New test.

From-SVN: r165472
This commit is contained in:
Joseph Myers 2010-10-14 16:48:52 +01:00 • committed by Joseph Myers
parent 4a759e75ab
commit 180f8dbbb3
4 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gcc/ChangeLog
View file

@ -1,3 +1,9 @@
2010-10-14 Joseph Myers <joseph@codesourcery.com>
PR c/45969
* c-typeck.c (build_binary_op): Don't try to compute a semantic
type with excess precision for boolean operations.
2010-10-14 Jeremie Salvucci <jeremie.salvucci@free.fr>
Basile Starynkevitch <basile@starynkevitch.net>

8
gcc/c-typeck.c
View file

@ -9423,6 +9423,10 @@ build_binary_op (location_t location, enum tree_code code,
precision. */
bool may_need_excess_precision;
/* True means this is a boolean operation that converts both its
operands to truth-values. */
bool boolean_op = false;
if (location == UNKNOWN_LOCATION)
location = input_location;
@ -9650,6 +9654,7 @@ build_binary_op (location_t location, enum tree_code code,
op0 = c_common_truthvalue_conversion (location, op0);
op1 = c_common_truthvalue_conversion (location, op1);
converted = 1;
boolean_op = true;
}
if (code == TRUTH_ANDIF_EXPR)
{
@ -10192,7 +10197,8 @@ build_binary_op (location_t location, enum tree_code code,
if (build_type == NULL_TREE)
{
build_type = result_type;
if (type0 != orig_type0 || type1 != orig_type1)
if ((type0 != orig_type0 || type1 != orig_type1)
&& !boolean_op)
{
gcc_assert (may_need_excess_precision && common);
semantic_result_type = c_common_type (orig_type0, orig_type1);

5
gcc/testsuite/ChangeLog
View file

@ -1,3 +1,8 @@
2010-10-14 Joseph Myers <joseph@codesourcery.com>
PR c/45969
* gcc.c-torture/compile/pr45969-1.c: New test.
2010-10-14 Richard Guenther <rguenther@suse.de>
PR lto/45382

6
gcc/testsuite/gcc.c-torture/compile/pr45969-1.c Normal file
View file

@ -0,0 +1,6 @@
/* { dg-options "-std=c89" } */
void crash() {
double l[4];
if((l[0]+l[2]) && (l[1]+l[3])){
}
}