From 0fa32aeaa6da4ef9566d98a6fb541dd7427d7d36 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Thu, 16 Nov 2023 17:42:22 +0100 Subject: [PATCH] c++: Fix error recovery ICE [PR112365] check_field_decls for DECL_C_BIT_FIELD FIELD_DECLs with error_mark_node TREE_TYPE continues early and doesn't call check_bitfield_decl which would either set DECL_BIT_FIELD, or clear DECL_C_BIT_FIELD. So, the following testcase ICEs after emitting tons of errors, because SET_DECL_FIELD_CXX_ZERO_WIDTH_BIT_FIELD asserts DECL_BIT_FIELD. The patch skips that for FIELD_DECLs with error_mark_node, another option would be to check DECL_BIT_FIELD in addition to DECL_C_BIT_FIELD. 2023-11-16 Jakub Jelinek PR c++/112365 * class.cc (layout_class_type): Don't SET_DECL_FIELD_CXX_ZERO_WIDTH_BIT_FIELD on FIELD_DECLs with error_mark_node type. * g++.dg/cpp0x/pr112365.C: New test. --- gcc/cp/class.cc | 3 ++- gcc/testsuite/g++.dg/cpp0x/pr112365.C | 8 ++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/cpp0x/pr112365.C diff --git a/gcc/cp/class.cc b/gcc/cp/class.cc index 9d4d95f85bf..4766b7cf832 100644 --- a/gcc/cp/class.cc +++ b/gcc/cp/class.cc @@ -6962,7 +6962,8 @@ layout_class_type (tree t, tree *virtuals_p) check_bitfield_decl eventually sets DECL_SIZE (field) to that width. */ && (DECL_SIZE (field) == NULL_TREE - || integer_zerop (DECL_SIZE (field)))) + || integer_zerop (DECL_SIZE (field))) + && TREE_TYPE (field) != error_mark_node) SET_DECL_FIELD_CXX_ZERO_WIDTH_BIT_FIELD (field, 1); check_non_pod_aggregate (field); } diff --git a/gcc/testsuite/g++.dg/cpp0x/pr112365.C b/gcc/testsuite/g++.dg/cpp0x/pr112365.C new file mode 100644 index 00000000000..23409cba49e --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/pr112365.C @@ -0,0 +1,8 @@ +// PR c++/112365 +// { dg-do compile { target c++11 } } +// { dg-excess-errors "" } + +template struct A; +template A foo (T; +template struct A { constexpr A : T {} } +struct { bar ( { foo (this)