FreeChainXenon/gcc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

diagnostics: special-case -fdiagnostics-text-art-charset=ascii for LANG=C

Browse source 
In the LWN discussion of the "ASCII" art in GCC 14
  https://lwn.net/Articles/946733/#Comments
there was some concern about the use of non-ASCII characters in the
output.

Currently -fdiagnostics-text-art-charset defaults to "emoji".
To better handle older terminals by default, this patch special-cases
LANG=C to use -fdiagnostics-text-art-charset=ascii.

gcc/ChangeLog:
	* diagnostic.cc (diagnostic_initialize): When LANG=C, update
	default for -fdiagnostics-text-art-charset from emoji to ascii.
	* doc/invoke.texi (fdiagnostics-text-art-charset): Document the above.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>
This commit is contained in:
David Malcolm 2023-10-16 19:04:50 -04:00
parent f8644b6782
commit 04013e4464
2 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
gcc/diagnostic.cc
View file

@ -226,8 +226,17 @@ diagnostic_initialize (diagnostic_context *context, int n_opts)
context->includes_seen = NULL;
context->m_client_data_hooks = NULL;
context->m_diagrams.m_theme = NULL;
diagnostics_text_art_charset_init (context,
DIAGNOSTICS_TEXT_ART_CHARSET_DEFAULT);
enum diagnostic_text_art_charset text_art_charset
= DIAGNOSTICS_TEXT_ART_CHARSET_DEFAULT;
if (const char *lang = getenv ("LANG"))
{
/* For LANG=C, don't assume the terminal supports anything
other than ASCII. */
if (!strcmp (lang, "C"))
text_art_charset = DIAGNOSTICS_TEXT_ART_CHARSET_ASCII;
}
diagnostics_text_art_charset_init (context, text_art_charset);
}
/* Maybe initialize the color support. We require clients to do this

3
gcc/doc/invoke.texi
View file

@ -5688,7 +5688,8 @@ value further adds the possibility of emoji in the output (such as emitting
U+26A0 WARNING SIGN followed by U+FE0F VARIATION SELECTOR-16 to select the
emoji variant of the character).
The default is @samp{emoji}.
The default is @samp{emoji}, except when the environment variable @env{LANG}
is set to @samp{C}, in which case the default is @samp{ascii}.
@opindex fdiagnostics-format
@item -fdiagnostics-format=@var{FORMAT}