binutils-gdb/gdb/testsuite/gdb.base/shlib-call.exp
Tom de Vries 0fc2a808cb [gdb/testsuite] Fix gdb.base/shlib-call.exp with gcc-8
When running test-case gdb.base/shlib-call.exp with gcc-8 instead of gcc-7, we
have:
...
 (gdb) step^M
-main () at /data/gdb_versions/devel/src/gdb/testsuite/gdb.base/shmain.c:42^M
-42        g = mainshr1(g);^M
-(gdb) PASS: gdb.base/shlib-call.exp: step out of shr2 epilogue to main
+main () at /data/gdb_versions/devel/src/gdb/testsuite/gdb.base/shmain.c:41^M
+41        g = shr2(g);^M
+(gdb) FAIL: gdb.base/shlib-call.exp: step out of shr2 epilogue to main
...

This is due to the fact that gcc-8 generates more precise line info, making
the instruction after the call to shr2 at 0x4008f1:
...
  4008e4:  8b 05 aa 07 20 00  mov    0x2007aa(%rip),%eax  # 601094 <g>
  4008ea:  89 c7              mov    %eax,%edi
  4008ec:  e8 1f fe ff ff     callq  400710 <shr2@plt>
  4008f1:  89 05 9d 07 20 00  mov    %eax,0x20079d(%rip)  # 601094 <g>
...
a "recommended breakpoint location":
...
  [0x00000287]  Special opcode 187: advance Address by 13 to 0x4008f1 and \
    Line by 0 to 41
...
so when stepping out of shr2, gdb steps back onto line 41, the line containing
the call to shr2.

Fix this by detecting this situation and adding an extra step to reach
line 42.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2020-05-06  Tom de Vries  <tdevries@suse.de>

	* gdb.base/shlib-call.exp: Add extra step to reach shmain.c:42, if
	necessary.
2020-05-06 11:50:52 +02:00

196 lines
4.7 KiB
Text

# Copyright 1997-2020 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# file to test calls into shared libraries
# the source files for this test are:
#
# shmain.c
# shr1.c (shared lib)
# shr2.c (shared lib)
# ss.h (header for shr2.c)
#
# file written by Elena Zannoni: elz@ch.apollo.com
#
#debug shmain
#prop lib shr1.sl
#prop lib shr2.sl
if {[skip_shlib_tests]} {
return 0
}
standard_testfile shmain.c shr1.c shr2.c
set srcfile ${srcdir}/${subdir}/${srcfile}
set lib1src ${srcdir}/${subdir}/${srcfile2}
set lib2src ${srcdir}/${subdir}/${srcfile3}
set lib1 [standard_output_file shr1.sl]
set lib2 [standard_output_file shr2.sl]
set lib_opts "debug"
set exec_opts [list debug shlib=${lib1} shlib=${lib2}]
if [get_compiler_info] {
return -1
}
if { [gdb_compile_shlib ${lib1src} ${lib1} $lib_opts] != ""
|| [gdb_compile_shlib ${lib2src} ${lib2} $lib_opts] != ""
|| [gdb_compile ${srcfile} ${binfile} executable $exec_opts] != ""} {
untested "failed to compile"
return -1
}
# Start with a fresh gdb.
clean_restart ${binfile}
gdb_load_shlib $lib1
gdb_load_shlib $lib2
gdb_test_no_output "set print sevenbit-strings"
gdb_test_no_output "set print address off"
gdb_test_no_output "set width 0"
if ![runto_main] then {
perror "C function calling tests suppressed"
}
#step -over
gdb_test "next 2" "g = shr1\\(g\\);" "next to shr1"
#print g
gdb_test "print g" "\[0-9\]* = 1"
#step -over
if ![gdb_skip_stdio_test "next over shr1"] {
gdb_test_stdio "next" \
"address of sgs is $hex" \
"g = shr2\\(g\\);" \
"next over shr1"
} else {
gdb_test "next" ".*" ""
}
#print g
gdb_test "print g" "\[0-9\]* = 2"
#print shr1(1)
if ![gdb_skip_stdio_test "print shr1(1)"] {
gdb_test_stdio "print shr1(1)" \
"address of sgs is $hex" \
"\[0-9\]* = 2" \
"print shr1(1)"
}
#print shr1(g)
if ![gdb_skip_stdio_test "print shr1(g)"] {
gdb_test_stdio "print shr1(g)" \
"address of sgs is $hex" \
"\[0-9\]* = 4" \
"print shr1(g)"
}
#break shr2
#go
gdb_test "break shr2" \
"Breakpoint.*file.*shr2.c, line.*" \
"breakpoint function shr2"
gdb_test "continue" \
"Continuing\\..*Breakpoint ${decimal}, shr2 \\(.*\\) at.*shr2\\.c:${decimal}.*shr2-return \\*\\/" \
"run until breakpoint set at a function"
#print shr1(1)
if ![gdb_skip_stdio_test "print shr1(1) 2nd time"] {
gdb_test_stdio "print shr1(1)" \
"address of sgs is $hex" \
"\[0-9\]* = 2" \
"print shr1(1) 2nd time"
}
#print mainshr1(1)
gdb_test "print mainshr1(1)" "\[0-9\]* = 2" \
"print mainshr1(1) from shlib func"
#step -return
# A step at this point will either take us entirely out of
# the function or into the function's epilogue. The exact
# behavior will differ depending upon upon whether or not
# the compiler emits line number information for the epilogue.
gdb_test_multiple "step" "step out of shr2 to main" {
-re "main \\(\\) at.*g = mainshr1\\(g\\);.*$gdb_prompt $" {
pass "step out of shr2 to main"
}
-re ".*\\\}.*$gdb_prompt $" {
pass "step out of shr2 to main (stopped in shr2 epilogue)"
gdb_test_multiple "step" "step out of shr2 epilogue to main" {
-re -wrap "main \\(\\) at.*g = mainshr1\\(g\\);" {
pass $gdb_test_name
}
-re -wrap "main \\(\\) at.*g = shr2\\(g\\);" {
gdb_test "step" "g = mainshr1\\(g\\);" $gdb_test_name
}
}
}
}
#print mainshr1(1)
gdb_test "print mainshr1(1)" "\[0-9\]* = 2"
#step
gdb_test "step" "mainshr1 \\(g=4\\) at.*return 2.g;" \
"step into mainshr1"
# Start with a fresh gdb.
gdb_exit
gdb_start
gdb_reinitialize_dir $srcdir/$subdir
gdb_load ${binfile}
gdb_test_no_output "set print sevenbit-strings"
gdb_test_no_output "set print address off"
gdb_test_no_output "set width 0"
# PR's 16495, 18213
# test that we can re-set breakpoints in shared libraries
gdb_breakpoint "shr1" "allow-pending"
set test "run to bp in shared library"
gdb_run_cmd
gdb_test_multiple "" $test {
-re "Breakpoint .,.*${gdb_prompt} " {
pass $test
}
}
gdb_continue_to_end "" continue 1
set test "re-run to bp in shared library (PR's 16495, 18213)"
gdb_run_cmd
gdb_test_multiple "" $test {
-re "Breakpoint .,.*${gdb_prompt} " {
pass $test
}
}
gdb_continue_to_end "" continue 1