
This fixes PR python/19438 and PR python/18393. Both bugs are about invoking dir() on some Python object implemented by gdb, and getting a crash. The crash happens because the dictionary field of these objects was not initialized. Apparently what happens is that this field can be lazily initialized by Python when assigning to an attribute; and it can also be handled ok when using dir() but without __dict__ defined; but gdb defines __dict__ because this isn't supplied automatically by Python. The docs on this seem rather sparse, but this patch works ok. An alternative might be to lazily create the dictionary in gdb_py_generic_dict, but I went with this approach because it seemed more straightforward. Built and regtested on x86-64 Fedora 23. 2016-05-23 Tom Tromey <tom@tromey.com> PR python/19438, PR python/18393: * python/py-objfile.c (objfpy_initialize): Initialize self->dict. * python/py-progspace.c (pspy_initialize): Initialize self->dict. 2016-05-23 Tom Tromey <tom@tromey.com> PR python/19438, PR python/18393: * gdb.python/py-progspace.exp: Add "dir" test. * gdb.python/py-objfile.exp: Add "dir" test.
151 lines
5.3 KiB
Text
151 lines
5.3 KiB
Text
# Copyright (C) 2011-2016 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file is part of the GDB testsuite. It tests the program space
|
|
# support in Python.
|
|
|
|
load_lib gdb-python.exp
|
|
|
|
standard_testfile
|
|
|
|
if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile}] } {
|
|
return -1
|
|
}
|
|
|
|
# Skip all tests if Python scripting is not enabled.
|
|
if { [skip_python_tests] } { continue }
|
|
|
|
if ![runto_main] then {
|
|
fail "Can't run to main"
|
|
return 0
|
|
}
|
|
|
|
set python_error_text "Error while executing Python code\\."
|
|
|
|
gdb_py_test_silent_cmd "python sym = gdb.lookup_symbol(\"some_var\")" \
|
|
"Find a symbol in objfile" 1
|
|
gdb_py_test_silent_cmd "python objfile = sym\[0\].symtab.objfile" \
|
|
"Get backing object file" 1
|
|
|
|
gdb_test "python print (objfile.filename)" "${testfile}" \
|
|
"Get objfile file name"
|
|
|
|
gdb_test "python print (objfile.username)" "${testfile}" \
|
|
"Get objfile user name"
|
|
|
|
gdb_test_no_output "python dir(objfile)"
|
|
|
|
gdb_test "python print (gdb.lookup_objfile (\"${testfile}\").filename)" \
|
|
"${testfile}" "print lookup_objfile filename"
|
|
gdb_test "python print (gdb.lookup_objfile (\"junk\"))" \
|
|
"Objfile not found\\.\r\n${python_error_text}"
|
|
|
|
set binfile_build_id [get_build_id $binfile]
|
|
if [string compare $binfile_build_id ""] {
|
|
verbose -log "binfile_build_id = $binfile_build_id"
|
|
gdb_test "python print (objfile.build_id)" "$binfile_build_id" \
|
|
"Get objfile build id"
|
|
gdb_test "python print (gdb.lookup_objfile (\"$binfile_build_id\", by_build_id=True).filename)" \
|
|
"${testfile}" "print lookup_objfile filename by build-id"
|
|
} else {
|
|
unsupported "build-id is not supported by the compiler"
|
|
}
|
|
|
|
# Other lookup_objfile_by_build_id tests we can do, even if compiler doesn't
|
|
# support them.
|
|
gdb_test "python print (gdb.lookup_objfile (\"foo\", by_build_id=True))" \
|
|
"Not a valid build id\\.\r\n${python_error_text}" \
|
|
"print invalid file lookup_objfile by build-id"
|
|
gdb_test "python print (gdb.lookup_objfile (\"1234abcdef\", by_build_id=True))" \
|
|
"Objfile not found\\.\r\n${python_error_text}" \
|
|
"print invalid file lookup_objfile by build-id 2"
|
|
|
|
gdb_test "python print (objfile.progspace)" "<gdb\.Progspace object at .*>" \
|
|
"Get objfile program space"
|
|
gdb_test "python print (objfile.is_valid())" "True" \
|
|
"Get objfile validity"
|
|
gdb_unload
|
|
gdb_test "python print (objfile.is_valid())" "False" \
|
|
"Get objfile validity after unload"
|
|
|
|
gdb_py_test_silent_cmd "python objfile.random_attribute = 42" \
|
|
"Set random attribute in objfile" 1
|
|
gdb_test "python print (objfile.random_attribute)" "42" \
|
|
"Verify set of random attribute in objfile"
|
|
|
|
# Verify invalid objfile handling.
|
|
|
|
if { [gdb_unload] < 0 } {
|
|
fail "unload all files"
|
|
return -1
|
|
}
|
|
|
|
gdb_test "python print(objfile.filename)" "None" \
|
|
"objfile.filename after objfile is unloaded"
|
|
gdb_test "python print(objfile.username)" "None" \
|
|
"objfile.username after objfile is unloaded"
|
|
|
|
# Now build another copy of the testcase, this time without debug info.
|
|
|
|
if { [prepare_for_testing ${testfile}.exp ${testfile}2 ${srcfile} {nodebug ldflags=-Wl,--strip-debug}] } {
|
|
return -1
|
|
}
|
|
|
|
if ![runto_main] {
|
|
fail "Can't run to main"
|
|
return 0
|
|
}
|
|
|
|
gdb_py_test_silent_cmd "python objfile = gdb.objfiles()\[0\]" \
|
|
"Get no-debug objfile file" 1
|
|
|
|
gdb_test "python print (objfile.owner)" "None" \
|
|
"Test owner of real objfile."
|
|
|
|
gdb_test "p main" "= {<text variable, no debug info>} $hex <main>" \
|
|
"print main without debug info"
|
|
|
|
gdb_py_test_silent_cmd "python objfile.add_separate_debug_file(\"${binfile}\")" \
|
|
"Add separate debug file file" 1
|
|
|
|
gdb_py_test_silent_cmd "python sep_objfile = gdb.objfiles()\[0\]" \
|
|
"Get separate debug info objfile" 1
|
|
|
|
gdb_test "python print (sep_objfile.owner.filename)" "${testfile}2" \
|
|
"Test owner of separate debug file"
|
|
|
|
gdb_test "python print (sep_objfile.owner.username)" "${testfile}2" \
|
|
"Test user-name of owner of separate debug file"
|
|
|
|
gdb_test "p main" "= {int \\(\\)} $hex <main>" \
|
|
"print main with debug info"
|
|
|
|
# Separate debug files are not findable.
|
|
if { [get_python_valueof "sep_objfile.build_id" "None"] != "None" } {
|
|
gdb_test "python print (gdb.lookup_objfile (sep_objfile.build_id, by_build_id=True))" \
|
|
"Objfile not found\\.\r\n${python_error_text}" \
|
|
"print lookup_objfile of separate debug file"
|
|
}
|
|
|
|
# An objfile that was a symlink to a differently named file is still
|
|
# findable with its original name.
|
|
set symlink_binary [standard_output_file "symlink-binary"]
|
|
remote_exec host "rm -f ${symlink_binary}"
|
|
remote_exec host "ln -sf ${testfile} ${symlink_binary}"
|
|
if [remote_file host exists "${symlink_binary}"] {
|
|
clean_restart "${symlink_binary}"
|
|
gdb_test "python print (gdb.lookup_objfile (\"${symlink_binary}\").filename)" \
|
|
"${testfile}" "gdb.lookup_objfile of symlinked binary"
|
|
}
|