binutils-gdb/gdb/dwarf2/tag.h
Tom Tromey 446fcb446f Fix .debug_names regression with new indexer
At AdaCore, we run the internal gdb test suite in several modes,
including one using the .debug_names index.  This caught a regression
caused by the new DWARF indexer.

First, the psymtabs-based .debug_names generator was completely wrong.
However, to avoid making the rewrite series even bigger (fixing the
writer will also require rewriting the .debug_names reader), it
attempted to preserve the weirdness.

However, this was not done properly.  For example the old writer did
this:

-      case STRUCT_DOMAIN:
-	return DW_TAG_structure_type;

The new code, instead, simply preserves the actual DWARF tag -- but
this makes future lookups fail, because the .debug_names reader only
looks for DW_TAG_structure_type.

This patch attempts to revert to the old behavior in the writer.
2022-04-29 13:16:44 -06:00

67 lines
1.9 KiB
C

/* Tag attributes
Copyright (C) 2022 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#ifndef GDB_DWARF2_TAG_H
#define GDB_DWARF2_TAG_H
#include "dwarf2.h"
/* Return true if TAG represents a type, false otherwise. */
static inline bool
tag_is_type (dwarf_tag tag)
{
switch (tag)
{
case DW_TAG_padding:
case DW_TAG_array_type:
case DW_TAG_class_type:
case DW_TAG_enumeration_type:
case DW_TAG_pointer_type:
case DW_TAG_reference_type:
case DW_TAG_string_type:
case DW_TAG_structure_type:
case DW_TAG_subroutine_type:
case DW_TAG_typedef:
case DW_TAG_union_type:
case DW_TAG_ptr_to_member_type:
case DW_TAG_set_type:
case DW_TAG_subrange_type:
case DW_TAG_base_type:
case DW_TAG_const_type:
case DW_TAG_packed_type:
case DW_TAG_template_type_param:
case DW_TAG_volatile_type:
case DW_TAG_restrict_type:
case DW_TAG_interface_type:
case DW_TAG_namespace:
case DW_TAG_unspecified_type:
case DW_TAG_shared_type:
case DW_TAG_rvalue_reference_type:
case DW_TAG_coarray_type:
case DW_TAG_dynamic_type:
case DW_TAG_atomic_type:
case DW_TAG_immutable_type:
return true;
default:
return false;
}
}
#endif /* GDB_DWARF2_TAG_H */