binutils-gdb/gdbserver
Simon Marchi df5ad10200 gdb, gdbserver: detach fork child when detaching from fork parent
While working with pending fork events, I wondered what would happen if
the user detached an inferior while a thread of that inferior had a
pending fork event.  What happens with the fork child, which is
ptrace-attached by the GDB process (or by GDBserver), but not known to
the core?  Sure enough, neither the core of GDB or the target detach the
child process, so GDB (or GDBserver) just stays ptrace-attached to the
process.  The result is that the fork child process is stuck, while you
would expect it to be detached and run.

Make GDBserver detach of fork children it knows about.  That is done in
the generic handle_detach function.  Since a process_info already exists
for the child, we can simply call detach_inferior on it.

GDB-side, make the linux-nat and remote targets detach of fork children
known because of pending fork events.  These pending fork events can be
stored in:

 - thread_info::pending_waitstatus, if the core has consumed the event
   but then saved it for later (for example, because it got the event
   while stopping all threads, to present an all-stop stop on top of a
   non-stop target)
 - thread_info::pending_follow: if we ran to a "catch fork" and we
   detach at that moment

Additionally, pending fork events can be in target-specific fields:

 - For linux-nat, they can be in lwp_info::status and
   lwp_info::waitstatus.
 - For the remote target, they could be stored as pending stop replies,
   saved in `remote_state::notif_state::pending_event`, if not
   acknowledged yet, or in `remote_state::stop_reply_queue`, if
   acknowledged.  I followed the model of remove_new_fork_children for
   this: call remote_notif_get_pending_events to process /
   acknowledge any unacknowledged notification, then look through
   stop_reply_queue.

Update the gdb.threads/pending-fork-event.exp test (and rename it to
gdb.threads/pending-fork-event-detach.exp) to try to detach the process
while it is stopped with a pending fork event.  In order to verify that
the fork child process is correctly detached and resumes execution
outside of GDB's control, make that process create a file in the test
output directory, and make the test wait $timeout seconds for that file
to appear (it happens instantly if everything goes well).

This test catches a bug in linux-nat.c, also reported as PR 28512
("waitstatus.h:300: internal-error: gdb_signal target_waitstatus::sig()
const: Assertion `m_kind == TARGET_WAITKIND_STOPPED || m_kind ==
TARGET_WAITKIND_SIGNALLED' failed.).  When detaching a thread with a
pending event, get_detach_signal unconditionally fetches the signal
stored in the waitstatus (`tp->pending_waitstatus ().sig ()`).  However,
that is only valid if the pending event is of type
TARGET_WAITKIND_STOPPED, and this is now enforced using assertions (iit
would also be valid for TARGET_WAITKIND_SIGNALLED, but that would mean
the thread does not exist anymore, so we wouldn't be detaching it).  Add
a condition in get_detach_signal to access the signal number only if the
wait status is of kind TARGET_WAITKIND_STOPPED, and use GDB_SIGNAL_0
instead (since the thread was not stopped with a signal to begin with).

Add another test, gdb.threads/pending-fork-event-ns.exp, specifically to
verify that we consider events in pending stop replies in the remote
target.  This test has many threads constantly forking, and we detach
from the program while the program is executing.  That gives us some
chance that we detach while a fork stop reply is stored in the remote
target.  To verify that we correctly detach all fork children, we ask
the parent to exit by sending it a SIGUSR1 signal and have it write a
file to the filesystem before exiting.  Because the parent's main thread
joins the forking threads, and the forking threads wait for their fork
children to exit, if some fork child is not detach by GDB, the parent
will not write the file, and the test will time out.  If I remove the
new remote_detach_pid calls in remote.c, the test fails eventually if I
run it in a loop.

There is a known limitation: we don't remove breakpoints from the
children before detaching it.  So the children, could hit a trap
instruction after being detached and crash.  I know this is wrong, and
it should be fixed, but I would like to handle that later.  The current
patch doesn't fix everything, but it's a step in the right direction.

Change-Id: I6d811a56f520e3cb92d5ea563ad38976f92e93dd
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28512
2021-12-08 21:00:39 -05:00
..
.dir-locals.el gdb: additional settings for emacs in .dir-locals.el 2021-05-17 20:47:46 +01:00
.gitattributes gdb, gdbserver, gdbsupport: add .gitattributes files 2020-03-05 15:59:22 +01:00
.gitignore
acinclude.m4 gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS 2021-06-19 23:06:01 -04:00
aclocal.m4 gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS 2021-06-19 23:06:01 -04:00
ax.cc gdb: make some variables static 2021-01-20 20:55:05 -05:00
ax.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
ChangeLog-2002-2021 gdb: move remaining ChangeLogs to legacy files 2021-07-26 12:20:33 +01:00
config.in Fix build on rhES5 2021-11-09 08:21:18 -07:00
configure Fix build on rhES5 2021-11-09 08:21:18 -07:00
configure.ac gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS 2021-06-19 23:06:01 -04:00
configure.srv gdb: or1k: implement gdb server 2021-10-29 05:22:12 +09:00
debug.cc gdb: make some variables static 2021-01-20 20:55:05 -05:00
debug.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
dll.cc gdbserver: convert the global dll list into a process_info field 2021-03-22 09:18:04 +01:00
dll.h gdbserver: convert the global dll list into a process_info field 2021-03-22 09:18:04 +01:00
fork-child.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
gdb_proc_service.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
gdbreplay.cc Remove WinCE code from gdbreplay 2021-04-13 22:18:24 +01:00
gdbthread.h gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
hostio.cc Remove process_stratum_target::hostio_last_error abstraction 2021-04-13 13:26:44 +01:00
hostio.h Remove process_stratum_target::hostio_last_error abstraction 2021-04-13 13:26:44 +01:00
i387-fp.cc [gdb/tdep] Fix avx512 -m32 support in gdbserver 2021-12-02 18:20:13 +01:00
i387-fp.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
inferiors.cc gdbserver: make thread_info non-POD 2021-10-21 16:10:54 -04:00
inferiors.h gdb: make inferior::m_cwd an std::string 2021-07-23 15:38:54 -04:00
linux-aarch32-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-aarch32-low.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-aarch32-tdesc.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-aarch32-tdesc.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-aarch64-ipa.cc AArch64: Add target description/feature for MTE registers 2021-03-24 14:52:08 -03:00
linux-aarch64-low.cc [AArch64] Make gdbserver register set selection dynamic 2021-11-03 09:50:53 -03:00
linux-aarch64-tdesc.cc AArch64: Add target description/feature for MTE registers 2021-03-24 14:52:08 -03:00
linux-aarch64-tdesc.h AArch64: Add target description/feature for MTE registers 2021-03-24 14:52:08 -03:00
linux-amd64-ipa.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-arc-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-arm-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-arm-tdesc.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-arm-tdesc.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-i386-ipa.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-ia64-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-low.cc gdb, gdbserver: detach fork child when detaching from fork parent 2021-12-08 21:00:39 -05:00
linux-low.h gdb, gdbserver: detach fork child when detaching from fork parent 2021-12-08 21:00:39 -05:00
linux-m68k-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-mips-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-nios2-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-or1k-low.cc gdb: or1k: implement gdb server 2021-10-29 05:22:12 +09:00
linux-ppc-ipa.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-ppc-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-ppc-tdesc-init.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-riscv-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-s390-ipa.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-s390-low.cc gdb: fix some indentation issues 2021-05-27 15:01:28 -04:00
linux-s390-tdesc.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-sh-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-sparc-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-tic6x-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-x86-low.cc gdb: make some variables static 2021-01-20 20:55:05 -05:00
linux-x86-tdesc.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-x86-tdesc.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-xtensa-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
Makefile.in Remove config.cache in gdbserver's "distclean" 2021-11-16 09:13:24 -07:00
mem-break.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
mem-break.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
netbsd-aarch64-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
netbsd-amd64-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
netbsd-i386-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
netbsd-low.cc gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
netbsd-low.h gdbserver: constify the 'pid_to_exec_file' target op 2021-04-12 16:36:25 +02:00
notif.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
notif.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
proc-service.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
proc-service.list Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
README gdbserver: small cleanup of README file 2020-06-12 16:01:35 -04:00
regcache.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
regcache.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
remote-utils.cc gdb: pass more const target_waitstatus by reference 2021-11-22 13:57:54 -05:00
remote-utils.h gdb: pass more const target_waitstatus by reference 2021-11-22 13:57:54 -05:00
server.cc gdb, gdbserver: detach fork child when detaching from fork parent 2021-12-08 21:00:39 -05:00
server.h GDBserver remote packet support for memory tagging 2021-03-24 14:49:21 -03:00
symbol.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
target.cc gdb, gdbserver: detach fork child when detaching from fork parent 2021-12-08 21:00:39 -05:00
target.h gdb, gdbserver: detach fork child when detaching from fork parent 2021-12-08 21:00:39 -05:00
tdesc.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
tdesc.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
thread-db.cc Remove defaulted 'tid' parameter to ptid_t constructor 2021-09-23 09:30:54 -06:00
tracepoint.cc gdbserver: make target_pid_to_str return std::string 2021-10-25 14:33:55 -04:00
tracepoint.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
utils.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
utils.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
win32-i386-low.cc Fix x86_64 mingw build 2021-05-03 12:40:19 -06:00
win32-low.cc gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
win32-low.h Remove unused declaration from gdbserver/win32-low.h 2021-09-07 12:17:42 -06:00
x86-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
x86-low.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
x86-tdesc.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
xtensa-xtregs.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00

		   README for GDBserver & GDBreplay
		    by Stu Grossman and Fred Fish

Introduction:

This is GDBserver, a remote server for Un*x-like systems.  It can be used to
control the execution of a program on a target system from a GDB on a different
host.  GDB and GDBserver communicate using the standard remote serial protocol.
They communicate via either a serial line or a TCP connection.

For more information about GDBserver, see the GDB manual:

    https://sourceware.org/gdb/current/onlinedocs/gdb/Remote-Protocol.html

Usage (server (target) side):

First, you need to have a copy of the program you want to debug put onto
the target system.  The program can be stripped to save space if needed, as
GDBserver doesn't care about symbols.  All symbol handling is taken care of by
the GDB running on the host system.

To use the server, you log on to the target system, and run the `gdbserver'
program.  You must tell it (a) how to communicate with GDB, (b) the name of
your program, and (c) its arguments.  The general syntax is:

	target> gdbserver COMM PROGRAM [ARGS ...]

For example, using a serial port, you might say:

	target> gdbserver /dev/com1 emacs foo.txt

This tells GDBserver to debug emacs with an argument of foo.txt, and to
communicate with GDB via /dev/com1.  GDBserver now waits patiently for the
host GDB to communicate with it.

To use a TCP connection, you could say:

	target> gdbserver host:2345 emacs foo.txt

This says pretty much the same thing as the last example, except that we are
going to communicate with the host GDB via TCP.  The `host:2345' argument means
that we are expecting to see a TCP connection to local TCP port 2345.
(Currently, the `host' part is ignored.)  You can choose any number you want for
the port number as long as it does not conflict with any existing TCP ports on
the target system.  This same port number must be used in the host GDB's
`target remote' command, which will be described shortly. Note that if you chose
a port number that conflicts with another service, GDBserver will print an error
message and exit.

On some targets, GDBserver can also attach to running programs.  This is
accomplished via the --attach argument.  The syntax is:

	target> gdbserver --attach COMM PID

PID is the process ID of a currently running process.  It isn't necessary
to point GDBserver at a binary for the running process.

Usage (host side):

You need an unstripped copy of the target program on your host system, since
GDB needs to examine it's symbol tables and such.  Start up GDB as you normally
would, with the target program as the first argument.  (You may need to use the
--baud option if the serial line is running at anything except 9600 baud.)
Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'.  After that, the only
new command you need to know about is `target remote'.  It's argument is either
a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT
descriptor.  For example:

	(gdb) target remote /dev/ttyb

communicates with the server via serial line /dev/ttyb, and:

	(gdb) target remote the-target:2345

communicates via a TCP connection to port 2345 on host `the-target', where
you previously started up GDBserver with the same port number.  Note that for
TCP connections, you must start up GDBserver prior to using the `target remote'
command, otherwise you may get an error that looks something like
`Connection refused'.

Building GDBserver:

See the `configure.srv` file for the list of host triplets you can build
GDBserver for.

Building GDBserver for your host is very straightforward.  If you build
GDB natively on a host which GDBserver supports, it will be built
automatically when you build GDB.  You can also build just GDBserver:

	% mkdir obj
	% cd obj
	% path-to-toplevel-sources/configure --disable-gdb
	% make all-gdbserver

(If you have a combined binutils+gdb tree, you may want to also
disable other directories when configuring, e.g., binutils, gas, gold,
gprof, and ld.)

If you prefer to cross-compile to your target, then you can also build
GDBserver that way.  For example:

	% export CC=your-cross-compiler
	% path-to-topevel-sources/configure --disable-gdb
	% make all-gdbserver

Using GDBreplay:

A special hacked down version of GDBserver can be used to replay remote
debug log files created by GDB.  Before using the GDB "target" command to
initiate a remote debug session, use "set remotelogfile <filename>" to tell
GDB that you want to make a recording of the serial or tcp session.  Note
that when replaying the session, GDB communicates with GDBreplay via tcp,
regardless of whether the original session was via a serial link or tcp.

Once you are done with the remote debug session, start GDBreplay and
tell it the name of the log file and the host and port number that GDB
should connect to (typically the same as the host running GDB):

	$ gdbreplay logfile host:port

Then start GDB (preferably in a different screen or window) and use the
"target" command to connect to GDBreplay:

	(gdb) target remote host:port

Repeat the same sequence of user commands to GDB that you gave in the
original debug session.  GDB should not be able to tell that it is talking
to GDBreplay rather than a real target, all other things being equal.  Note
that GDBreplay echos the command lines to stderr, as well as the contents of
the packets it sends and receives.  The last command echoed by GDBreplay is
the next command that needs to be typed to GDB to continue the session in
sync with the original session.