b49180acf2
Testing showed that gdb was not correctly handling some fixed-point binary operations correctly. Addition and subtraction worked by casting the result to the type of left hand operand. So, "fixed+int" had a different type -- and different value -- from "int+fixed". Furthermore, for multiplication and division, it does not make sense to first cast both sides to the fixed-point type. For example, this can prevent "f * 1" from yielding "f", if 1 is not in the domain of "f". Instead, this patch changes gdb to use the value. (This is somewhat different from Ada semantics, as those can yield a "universal fixed point".) This includes a new test case. It is only run in "minimal" mode, as the old-style fixed point works differently, and is obsolete, so I have no plans to change it. gdb/ChangeLog 2021-01-06 Tom Tromey <tromey@adacore.com> * ada-lang.c (ada_evaluate_subexp) <BINOP_ADD, BINOP_SUB>: Do not cast result. * valarith.c (fixed_point_binop): Handle multiplication and division specially. * valops.c (value_to_gdb_mpq): New function. (value_cast_to_fixed_point): Use it. gdb/testsuite/ChangeLog 2021-01-06 Tom Tromey <tromey@adacore.com> * gdb.ada/fixed_points/pck.ads (Delta4): New constant. (FP4_Type): New type. (FP4_Var): New variable. * gdb.ada/fixed_points/fixed_points.adb: Update. * gdb.ada/fixed_points.exp: Add tests for binary operators.
67 lines
2 KiB
Ada
67 lines
2 KiB
Ada
-- Copyright 2004-2021 Free Software Foundation, Inc.
|
|
--
|
|
-- This program is free software; you can redistribute it and/or modify
|
|
-- it under the terms of the GNU General Public License as published by
|
|
-- the Free Software Foundation; either version 3 of the License, or
|
|
-- (at your option) any later version.
|
|
--
|
|
-- This program is distributed in the hope that it will be useful,
|
|
-- but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
-- GNU General Public License for more details.
|
|
--
|
|
-- You should have received a copy of the GNU General Public License
|
|
-- along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
with System;
|
|
with Pck; use Pck;
|
|
|
|
procedure Fixed_Points is
|
|
|
|
------------
|
|
-- Test 1 --
|
|
------------
|
|
|
|
-- Fixed point subtypes
|
|
|
|
type Base_Fixed_Point_Type is
|
|
delta 1.0 / 16.0
|
|
range -2147483648 * 1.0 / 16.0 .. 2147483647 * 1.0 / 16.0;
|
|
|
|
subtype Fixed_Point_Subtype is
|
|
Base_Fixed_Point_Type range -50.0 .. 50.0;
|
|
|
|
type New_Fixed_Point_Type is
|
|
new Base_Fixed_Point_Type range -50.0 .. 50.0;
|
|
|
|
Base_Object : Base_Fixed_Point_Type := -50.0;
|
|
Subtype_Object : Fixed_Point_Subtype := -50.0;
|
|
New_Type_Object : New_Fixed_Point_Type := -50.0;
|
|
|
|
|
|
------------
|
|
-- Test 2 --
|
|
------------
|
|
|
|
-- Overprecise delta
|
|
|
|
Overprecise_Delta : constant := 0.135791357913579;
|
|
-- delta whose significant figures cannot be stored into a long.
|
|
|
|
type Overprecise_Fixed_Point is
|
|
delta Overprecise_Delta range 0.0 .. 200.0;
|
|
for Overprecise_Fixed_Point'Small use Overprecise_Delta;
|
|
|
|
Overprecise_Object : Overprecise_Fixed_Point :=
|
|
Overprecise_Fixed_Point'Small;
|
|
|
|
begin
|
|
Base_Object := 1.0/16.0; -- Set breakpoint here
|
|
Subtype_Object := 1.0/16.0;
|
|
New_Type_Object := 1.0/16.0;
|
|
Overprecise_Object := Overprecise_Fixed_Point'Small * 2;
|
|
Do_Nothing (FP1_Var'Address);
|
|
Do_Nothing (FP2_Var'Address);
|
|
Do_Nothing (FP3_Var'Address);
|
|
Do_Nothing (FP4_Var'Address);
|
|
end Fixed_Points;
|