aa3cfbda2f
Prior to this patch, calling functions on the inferior with arguments and then using these arguments within a function resulted in an invalid memory access. This is because Fortran arguments are typically passed as pointers to values. It is possible to call Fortran functions, but memory must be allocated in the inferior, so a pointer can be passed to the function, and the language must be set to C to enable C-style casting. This is cumbersome and not a pleasant debug experience. This patch implements the GNU Fortran argument passing conventions with caveats. Firstly, it does not handle the VALUE attribute as there is insufficient DWARF information to determine when this is the case. Secondly, functions with optional parameters can only be called with all parameters present. Both these cases are marked as KFAILS in the test. Since the GNU Fortran argument passing convention has been implemented, there is no guarantee that this patch will work correctly, in all cases, with other compilers. Despite these limitations, this patch improves the ease with which functions can be called in many cases, without taking away the existing approach of calling with the language set to C. Regression tested on x86_64, aarch64 and POWER9 with GCC 7.3.0. Regression tested with Ada on x86_64. Regression tested with native-extended-gdbserver target board. gdb/ChangeLog: * eval.c (evaluate_subexp_standard): Call Fortran argument wrapping logic. * f-lang.c (struct value): A value which can be passed into a Fortran function call. (fortran_argument_convert): Wrap Fortran arguments in a pointer where appropriate. (struct type): Value ready for a Fortran function call. (fortran_preserve_arg_pointer): Undo check_typedef, the pointer is needed. * f-lang.h (fortran_argument_convert): Declaration. (fortran_preserve_arg_pointer): Declaration. * infcall.c (value_arg_coerce): Call Fortran argument logic. gdb/testsuite/ChangeLog: * gdb.fortran/function-calls.exp: New file. * gdb.fortran/function-calls.f90: New test.
118 lines
3.9 KiB
C
118 lines
3.9 KiB
C
/* Fortran language support definitions for GDB, the GNU debugger.
|
|
|
|
Copyright (C) 1992-2019 Free Software Foundation, Inc.
|
|
|
|
Contributed by Motorola. Adapted from the C definitions by Farooq Butt
|
|
(fmbutt@engage.sps.mot.com).
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef F_LANG_H
|
|
#define F_LANG_H
|
|
|
|
struct type_print_options;
|
|
struct parser_state;
|
|
|
|
extern int f_parse (struct parser_state *);
|
|
|
|
extern void f_print_type (struct type *, const char *, struct ui_file *, int,
|
|
int, const struct type_print_options *);
|
|
|
|
extern void f_val_print (struct type *, int, CORE_ADDR,
|
|
struct ui_file *, int,
|
|
struct value *,
|
|
const struct value_print_options *);
|
|
|
|
/* Language-specific data structures */
|
|
|
|
/* A common block. */
|
|
|
|
struct common_block
|
|
{
|
|
/* The number of entries in the block. */
|
|
size_t n_entries;
|
|
|
|
/* The contents of the block, allocated using the struct hack. All
|
|
pointers in the array are non-NULL. */
|
|
struct symbol *contents[1];
|
|
};
|
|
|
|
extern int f77_get_upperbound (struct type *);
|
|
|
|
extern int f77_get_lowerbound (struct type *);
|
|
|
|
extern void f77_get_dynamic_array_length (struct type *);
|
|
|
|
extern int calc_f77_array_dims (struct type *);
|
|
|
|
|
|
/* Fortran (F77) types */
|
|
|
|
struct builtin_f_type
|
|
{
|
|
struct type *builtin_character;
|
|
struct type *builtin_integer;
|
|
struct type *builtin_integer_s2;
|
|
struct type *builtin_logical;
|
|
struct type *builtin_logical_s1;
|
|
struct type *builtin_logical_s2;
|
|
struct type *builtin_logical_s8;
|
|
struct type *builtin_real;
|
|
struct type *builtin_real_s8;
|
|
struct type *builtin_real_s16;
|
|
struct type *builtin_complex_s8;
|
|
struct type *builtin_complex_s16;
|
|
struct type *builtin_complex_s32;
|
|
struct type *builtin_void;
|
|
};
|
|
|
|
/* Return the Fortran type table for the specified architecture. */
|
|
extern const struct builtin_f_type *builtin_f_type (struct gdbarch *gdbarch);
|
|
|
|
/* Ensures that function argument VALUE is in the appropriate form to
|
|
pass to a Fortran function. Returns a possibly new value that should
|
|
be used instead of VALUE.
|
|
|
|
When IS_ARTIFICIAL is true this indicates an artificial argument,
|
|
e.g. hidden string lengths which the GNU Fortran argument passing
|
|
convention specifies as being passed by value.
|
|
|
|
When IS_ARTIFICIAL is false, the argument is passed by pointer. If the
|
|
value is already in target memory then return a value that is a pointer
|
|
to VALUE. If VALUE is not in memory (e.g. an integer literal), allocate
|
|
space in the target, copy VALUE in, and return a pointer to the in
|
|
memory copy. */
|
|
|
|
extern struct value *fortran_argument_convert (struct value *value,
|
|
bool is_artificial);
|
|
|
|
/* Ensures that function argument TYPE is appropriate to inform the debugger
|
|
that ARG should be passed as a pointer. Returns the potentially updated
|
|
argument type.
|
|
|
|
If ARG is of type pointer then the type of ARG is returned, otherwise
|
|
TYPE is returned untouched.
|
|
|
|
This function exists to augment the types of Fortran function call
|
|
parameters to be pointers to the reported value, when the corresponding ARG
|
|
has also been wrapped in a pointer (by fortran_argument_convert). This
|
|
informs the debugger that these arguments should be passed as a pointer
|
|
rather than as the pointed to type. */
|
|
|
|
extern struct type *fortran_preserve_arg_pointer (struct value *arg,
|
|
struct type *type);
|
|
|
|
#endif /* F_LANG_H */
|