28ab59607e
v6: Fix comments. Fix copyright Remove unnecessary test suite stuff. save_var had to stay, as it mutates some test suite state that otherwise fails. v5: Did what Tom Tromey requested in v4; which can be found here: https://pi.simark.ca/gdb-patches/87pmjm0xar.fsf@tromey.com/ v4: Doc formatting fixed. v3: Eli: Updated docs & NEWS to reflect new changes. Added a reference from the .ptid attribute of the ThreadExitedEvent to the ptid attribute of InferiorThread. To do this, I've added an anchor to that attribute. Tom: Tom requested that I should probably just emit the thread object; I ran into two issues for this, which I could not resolve in this patch; 1 - The Thread Object (the python type) checks it's own validity by doing a comparison of it's `thread_info* thread` to nullptr. This means that any access of it's attributes may (probably, since we are in "async" land) throw Python exceptions because the thread has been removed from the thread object. Therefore I've decided in v3 of this patch to just emit most of the same fields that gdb.InferiorThread has, namely global_num, name, num and ptid (the 3-attribute tuple provided by gdb.InferiorThread.ptid). 2 - A python user can hold a global reference to an exiting thread. Thus in order to have a ThreadExit event that can provide attribute access reliably (both as a global reference, but also inside the thread exit handler, as we can never guarantee that it's executed _before_ the thread_info pointer is removed from the gdbpy thread object), the `thread_info *` thread pointer must not be null. However, this comes at the cost of gdb.InferiorThread believing it is "valid" - which means, that if a user holds takes a global reference to that exiting event thread object, they can some time later do `t.switch()` at which point GDB will 'explode' so to speak. v2: Fixed white space issues and NULL/nullptr stuff, as requested by Tom Tromey. v1: Currently no event is emitted for a thread exit. This adds this functionality by emitting a new gdb.ThreadExitedEvent. It currently provides four attributes: - global_num: The GDB assigned global thread number - num: the per-inferior thread number - name: name of the thread or none if not set - ptid: the PTID of the thread, a 3-attribute tuple, identical to InferiorThread.ptid attribute Added info to docs & the NEWS file as well. Added test to test suite. Fixed formatting. Feedback wanted and appreciated.
76 lines
2 KiB
C
76 lines
2 KiB
C
/* Copyright (C) 2009-2023 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "py-event.h"
|
|
#include "infrun.h"
|
|
#include "gdbthread.h"
|
|
|
|
/* See py-event.h. */
|
|
|
|
gdbpy_ref<>
|
|
py_get_event_thread (ptid_t ptid)
|
|
{
|
|
if (non_stop)
|
|
{
|
|
thread_info *thread
|
|
= current_inferior ()->find_thread (ptid);
|
|
if (thread != nullptr)
|
|
return thread_to_thread_object (thread);
|
|
PyErr_SetString (PyExc_RuntimeError, "Could not find event thread");
|
|
return NULL;
|
|
}
|
|
return gdbpy_ref<>::new_reference (Py_None);
|
|
}
|
|
|
|
gdbpy_ref<>
|
|
create_thread_event_object (PyTypeObject *py_type, PyObject *thread)
|
|
{
|
|
gdb_assert (thread != NULL);
|
|
|
|
gdbpy_ref<> thread_event_obj = create_event_object (py_type);
|
|
if (thread_event_obj == NULL)
|
|
return NULL;
|
|
|
|
if (evpy_add_attribute (thread_event_obj.get (),
|
|
"inferior_thread",
|
|
thread) < 0)
|
|
return NULL;
|
|
|
|
return thread_event_obj;
|
|
}
|
|
|
|
/* Emits a thread exit event for THREAD */
|
|
|
|
int
|
|
emit_thread_exit_event (thread_info * thread)
|
|
{
|
|
if (evregpy_no_listeners_p (gdb_py_events.thread_exited))
|
|
return 0;
|
|
|
|
auto py_thr = thread_to_thread_object (thread);
|
|
|
|
if (py_thr == nullptr)
|
|
return -1;
|
|
|
|
auto inf_thr = create_thread_event_object (&thread_exited_event_object_type,
|
|
py_thr.get ());
|
|
if (inf_thr == nullptr)
|
|
return -1;
|
|
|
|
return evpy_emit_event (inf_thr.get (), gdb_py_events.thread_exited);
|
|
}
|