e7af6c702d
The multi-target patch makes inferior_ptid point to null_ptid before calling into target_wait, which catches bad uses of inferior_ptid, since the current selected thread in gdb shouldn't have much relation to the thread that reports an event. One such bad use is found in remote_target::remote_parse_stop_reply, where we handle the 'W' or 'X' packets (process exit), and the remote target does not support the multi-process extensions, i.e., it does not report the PID of the process that exited. With the multi-target patch, that would result in a failed assertion, trying to find the inferior for process pid 0. gdb/ChangeLog: 2020-01-10 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> Pedro Alves <palves@redhat.com> * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>: If no process is specified, return null_ptid instead of inferior_ptid. (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED / TARGET_WAITKIND_SIGNALLED with no pid. gdb/testsuite/ChangeLog: 2020-01-10 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> Pedro Alves <palves@redhat.com> * gdb.server/connect-without-multi-process.exp: Also test continuing to end.
66 lines
2 KiB
Text
66 lines
2 KiB
Text
# Copyright 2015-2020 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
# Check that we can connect to GDBserver with the multiprocess
|
|
# extensions disabled, run to main, and finish the process.
|
|
|
|
load_lib gdbserver-support.exp
|
|
|
|
if {[skip_gdbserver_tests]} {
|
|
return
|
|
}
|
|
|
|
standard_testfile
|
|
|
|
if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
|
|
return -1
|
|
}
|
|
|
|
# Test spawning gdbserver with a program, connect to it and run to
|
|
# main, with both multiprocess extensions on and off.
|
|
proc do_test {multiprocess} {
|
|
global binfile
|
|
|
|
clean_restart $binfile
|
|
|
|
# Make sure we're disconnected, in case we're testing with an
|
|
# extended-remote board, therefore already connected.
|
|
gdb_test "disconnect" ".*"
|
|
|
|
gdb_test_no_output "set remote multiprocess-feature $multiprocess"
|
|
|
|
set res [gdbserver_spawn ""]
|
|
set gdbserver_protocol [lindex $res 0]
|
|
set gdbserver_gdbport [lindex $res 1]
|
|
|
|
gdb_test "break main" "Breakpoint .*"
|
|
|
|
gdb_test "target $gdbserver_protocol $gdbserver_gdbport" \
|
|
"Remote debugging using .*" \
|
|
"target $gdbserver_protocol"
|
|
|
|
gdb_test "continue" "main .*" "continue to main"
|
|
|
|
# The W/X packets do not include the PID of the exiting process
|
|
# without the multi-process extensions. Check that we handle
|
|
# process exit correctly in that case.
|
|
gdb_continue_to_end
|
|
}
|
|
|
|
foreach multiprocess { "off" "auto" } {
|
|
with_test_prefix "multiprocess=$multiprocess" {
|
|
do_test $multiprocess
|
|
}
|
|
}
|