binutils-gdb/gdb/testsuite/gdb.testsuite/gdb-caching-proc.exp
Tom de Vries 71f1ab80f1 [gdb/testsuite] Allow args in gdb_caching_proc
Test-case gdb.base/morestack.exp contains:
...
require {have_compile_flag -fsplit-stack}
...
and I want to cache the result of have_compile_flag.

Currently gdb_caching_proc doesn't allow args, so I could add:
...
gdb_caching_proc have_compile_flag_fsplit_stack {
    return [have_compile_flag -fsplit-stack]
}
...
and then use that proc instead, but I find this cumbersome and
maintenance-unfriendly.

Instead, allow args in a gdb_caching_proc, such that I can simply do:
...
-proc have_compile_flag { flag } {
+gdb_caching_proc have_compile_flag { flag } {
...

Note that gdb_caching_procs with args do not work with the
gdb.base/gdb-caching-procs.exp test-case, so those procs are skipped.

Tested on x86_64-linux.

Reviewed-By: Tom Tromey <tom@tromey.com>
2023-03-06 16:49:19 +01:00

45 lines
1.3 KiB
Text

# Copyright 2023 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
gdb_caching_proc gdb_testsuite_gdb_caching_proc_exp_noarg {} {
incr ::count
return 1
}
gdb_caching_proc gdb_testsuite_gdb_caching_proc_exp_arg { arg } {
incr ::count
return $arg
}
set assertions {
{ [gdb_testsuite_gdb_caching_proc_exp_noarg] == 1 }
{ [gdb_testsuite_gdb_caching_proc_exp_arg 1] == 1 }
{ [gdb_testsuite_gdb_caching_proc_exp_arg "foo foo"] == "foo foo" }
}
set assertion_nr 0
foreach assertion $assertions {
with_test_prefix $assertion_nr {
set ::count 0
gdb_assert $assertion
gdb_assert { $::count == 1 }
with_test_prefix cached {
gdb_assert $assertion
gdb_assert { $::count == 1 }
}
}
incr assertion_nr
}