binutils-gdb/gdb/python
Simon Marchi 50888e42dc gdb: change functions returning value contents to use gdb::array_view
The bug fixed by this [1] patch was caused by an out-of-bounds access to
a value's content.  The code gets the value's content (just a pointer)
and then indexes it with a non-sensical index.

This made me think of changing functions that return value contents to
return array_views instead of a plain pointer.  This has the advantage
that when GDB is built with _GLIBCXX_DEBUG, accesses to the array_view
are checked, making bugs more apparent / easier to find.

This patch changes the return types of these functions, and updates
callers to call .data() on the result, meaning it's not changing
anything in practice.  Additional work will be needed (which can be done
little by little) to make callers propagate the use of array_view and
reap the benefits.

[1] https://sourceware.org/pipermail/gdb-patches/2021-September/182306.html

Change-Id: I5151f888f169e1c36abe2cbc57620110673816f3
2021-10-25 14:51:44 -04:00
..
lib/gdb gdb/python: fix a few flake8 warnings 2021-10-02 08:33:28 -04:00
py-all-events.def gdb/python: add a new gdb_exiting event 2021-10-05 10:05:40 +01:00
py-arch.c gdb/python: new gdb.architecture_names function 2021-10-22 13:42:49 +01:00
py-auto-load.c gdb: remove unnecessary lookup_cmd when deprecating commands 2021-05-27 14:00:07 -04:00
py-block.c gdb/python: remove all uses of Py_TPFLAGS_HAVE_ITER 2021-09-09 09:50:38 +01:00
py-bpevent.c
py-breakpoint.c Use unique_xmalloc_ptr in breakpoint 2021-10-20 11:00:32 -06:00
py-cmd.c gdb: remove cmd_list_element::function::sfunc 2021-07-23 15:38:54 -04:00
py-continueevent.c
py-event-types.def gdb/python: add a new gdb_exiting event 2021-10-05 10:05:40 +01:00
py-event.c
py-event.h
py-events.h
py-evtregistry.c
py-evts.c
py-exitedevent.c
py-finishbreakpoint.c gdb: remove iterate_over_breakpoints function 2021-05-27 14:58:37 -04:00
py-frame.c gdb/python: add PendingFrame.level and Frame.level methods 2021-06-21 16:20:08 +01:00
py-framefilter.c Remove uses of fprintf_symbol_filtered 2021-08-02 10:48:29 -06:00
py-function.c
py-gdb-readline.c
py-inferior.c gdb: change functions returning value contents to use gdb::array_view 2021-10-25 14:51:44 -04:00
py-infevents.c
py-infthread.c gdb: change thread_info::name to unique_xmalloc_ptr, add helper function 2021-09-24 17:25:55 -04:00
py-instruction.c
py-instruction.h
py-lazy-string.c
py-linetable.c gdb/python: remove all uses of Py_TPFLAGS_HAVE_ITER 2021-09-09 09:50:38 +01:00
py-membuf.c gdb/python: move gdb.Membuf support into a new file 2021-10-22 13:43:42 +01:00
py-newobjfileevent.c
py-objfile.c gdb: delay python initialisation until gdbpy_finish_initialization 2021-04-28 09:56:20 +01:00
py-param.c gdb: make string-like set show commands use std::string variable 2021-10-03 17:53:16 +01:00
py-prettyprint.c gdb: fix some indentation issues 2021-05-27 15:01:28 -04:00
py-progspace.c gdb: delay python initialisation until gdbpy_finish_initialization 2021-04-28 09:56:20 +01:00
py-record-btrace.c
py-record-btrace.h
py-record-full.c
py-record-full.h
py-record.c
py-record.h
py-ref.h
py-registers.c gdb/python: remove all uses of Py_TPFLAGS_HAVE_ITER 2021-09-09 09:50:38 +01:00
py-signalevent.c
py-stopevent.c
py-stopevent.h
py-symbol.c Restore gdb.SYMBOL_LABEL_DOMAIN constant 2021-06-03 14:56:55 +02:00
py-symtab.c gdb: delay python initialisation until gdbpy_finish_initialization 2021-04-28 09:56:20 +01:00
py-threadevent.c
py-tui.c Forward mouse click to python TUI window 2021-06-04 16:18:10 +02:00
py-type.c gdb: remove TYPE_FIELD_NAME and FIELD_NAME macros 2021-09-30 22:05:57 -04:00
py-unwind.c gdb: change functions returning value contents to use gdb::array_view 2021-10-25 14:51:44 -04:00
py-utils.c
py-value.c gdb: change functions returning value contents to use gdb::array_view 2021-10-25 14:51:44 -04:00
py-varobj.c
py-xmethods.c
python-config.py gdb: re-format Python files using black 21.4b0 2021-05-07 10:56:20 -04:00
python-internal.h gdb/python: move gdb.Membuf support into a new file 2021-10-22 13:43:42 +01:00
python.c gdb/python: move gdb.Membuf support into a new file 2021-10-22 13:43:42 +01:00
python.h