binutils-gdb/gdb/features
Simon Marchi a8d2e5856f Do not emit "field_type" var if not needed on "maint print c-tdesc"
While fiddling a bit with -Wunused-variable, Sergio noticed that "maint
print c-tdesc" was always generating code for the "tdesc_type
*field_type" variable, even when it wasn't used.  This is caught by GCC
when using -Wunused-variable, of course.

This patch changes the print_c_tdesc class to only output the field
declaration when we actually need it.

It shouldn't be necessary to do the same with the other variable
declarations (type_with_fields and element_type), because they are
always if they are declared.

The C files in features/ are regenerated, some declarations of
field_type are removed, as expected, while some others move to where
they are used for the first time.

gdb/ChangeLog:

	* target-descriptions.c (print_c_tdesc) <visit>: Don't output
	field_type declaration, use printf_field_type_assignment
	instead.
	<printf_field_type_assignment>: New method.
	* features/aarch64-core.c, features/aarch64-fpu.c
	features/arc-arcompact.c, features/arc-v2.c,
	features/arm/arm-with-iwmmxt.c, features/i386/32bit-core.c,
	features/i386/32bit-mpx.c, features/i386/32bit-sse.c,
	features/i386/64bit-avx512.c, features/i386/64bit-core.c,
	features/i386/64bit-mpx.c, features/i386/64bit-sse.c,
	features/i386/x32-core.c, features/or1k.c,
	features/rs6000/powerpc-7400.c,
	features/rs6000/powerpc-altivec32.c,
	features/rs6000/powerpc-altivec32l.c,
	features/rs6000/powerpc-altivec64.c,
	features/rs6000/powerpc-altivec64l.c,
	features/rs6000/powerpc-cell32l.c,
	features/rs6000/powerpc-cell64l.c,
	features/rs6000/powerpc-isa205-altivec32l.c,
	features/rs6000/powerpc-isa205-altivec64l.c,
	features/rs6000/powerpc-isa205-vsx32l.c,
	features/rs6000/powerpc-isa205-vsx64l.c,
	features/rs6000/powerpc-vsx32.c,
	features/rs6000/powerpc-vsx32l.c,
	features/rs6000/powerpc-vsx64.c,
	features/rs6000/powerpc-vsx64l.c, features/s390-gs-linux64.c,
	features/s390-tevx-linux64.c, features/s390-vx-linux64.c,
	features/s390x-gs-linux64.c, features/s390x-tevx-linux64.c,
	features/s390x-vx-linux64.c: Re-generate.
2017-12-21 18:21:45 -05:00
..
arm Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
i386 Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
rs6000 Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
sparc gdb: provide and use sparc{32,64} target description XML files. 2017-02-05 23:44:03 -08:00
aarch64-core.c Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
aarch64-core.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
aarch64-fpu.c Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
aarch64-fpu.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
aarch64.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
arc-arcompact.c Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
arc-arcompact.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
arc-v2.c Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
arc-v2.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
btrace-conf.dtd update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
btrace.dtd update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
feature_to_c.sh update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
gdb-target.dtd update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
gdbserver-regs.xsl
library-list-aix.dtd update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
library-list-svr4.dtd update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
library-list.dtd update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
m68k-core.xml
Makefile gdb: Add OpenRISC or1k and or1knd target support 2017-12-12 23:36:00 +09:00
microblaze-core.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
microblaze-stack-protect.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
microblaze-with-stack-protect.c Fix for remote G Packet message too long error for baremetal. 2014-07-19 17:47:52 -07:00
microblaze-with-stack-protect.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
microblaze.c Fix for remote G Packet message too long error for baremetal. 2014-07-19 17:47:52 -07:00
microblaze.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
mips-cp0.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
mips-cpu.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
mips-dsp-linux.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
mips-dsp-linux.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
mips-dsp.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
mips-fpu.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
mips-linux.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
mips-linux.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
mips64-cp0.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
mips64-cpu.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
mips64-dsp-linux.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
mips64-dsp-linux.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
mips64-dsp.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
mips64-fpu.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
mips64-linux.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
mips64-linux.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
nds32-core.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
nds32-fpu.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
nds32-system.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
nds32.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
nds32.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
nios2-cpu.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
nios2-linux.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
nios2.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
nios2.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
number-regs.xsl
or1k-core.xml gdb: Add OpenRISC or1k and or1knd target support 2017-12-12 23:36:00 +09:00
or1k.c Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
or1k.xml gdb: Add OpenRISC or1k and or1knd target support 2017-12-12 23:36:00 +09:00
osdata.dtd update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-acr.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-core32.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-core64.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-fpr.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-gs-linux64.c Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
s390-gs-linux64.xml S390: Add guarded-storage register definitions and tdescs 2017-09-25 16:02:23 +02:00
s390-gs.xml S390: Add guarded-storage register definitions and tdescs 2017-09-25 16:02:23 +02:00
s390-gsbc.xml S390: Add guarded-storage register definitions and tdescs 2017-09-25 16:02:23 +02:00
s390-linux32.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
s390-linux32.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-linux32v1.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
s390-linux32v1.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-linux32v2.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
s390-linux32v2.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-linux64.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
s390-linux64.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-linux64v1.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
s390-linux64v1.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-linux64v2.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
s390-linux64v2.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-tdb.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-te-linux64.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
s390-te-linux64.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-tevx-linux64.c Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
s390-tevx-linux64.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-vx-linux64.c Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
s390-vx-linux64.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390-vx.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390x-core64.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390x-gs-linux64.c Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
s390x-gs-linux64.xml S390: Add guarded-storage register definitions and tdescs 2017-09-25 16:02:23 +02:00
s390x-linux64.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
s390x-linux64.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390x-linux64v1.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
s390x-linux64v1.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390x-linux64v2.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
s390x-linux64v2.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390x-te-linux64.c Use visitor pattern for "maint print c-tdesc" 2017-07-26 12:56:54 +01:00
s390x-te-linux64.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390x-tevx-linux64.c Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
s390x-tevx-linux64.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
s390x-vx-linux64.c Do not emit "field_type" var if not needed on "maint print c-tdesc" 2017-12-21 18:21:45 -05:00
s390x-vx-linux64.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
sort-regs.xsl
threads.dtd update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
tic6x-c6xp.c Change tic6x target descriptions 2017-11-24 09:29:43 +00:00
tic6x-c6xp.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
tic6x-c62x-linux.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
tic6x-c64x-linux.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
tic6x-c64xp-linux.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
tic6x-core.c Change tic6x target descriptions 2017-11-24 09:29:43 +00:00
tic6x-core.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
tic6x-gp.c Change tic6x target descriptions 2017-11-24 09:29:43 +00:00
tic6x-gp.xml update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
traceframe-info.dtd update copyright year range in GDB files 2017-01-01 10:52:34 +04:00
xinclude.dtd update copyright year range in GDB files 2017-01-01 10:52:34 +04:00