486f9e20e0
On gcc-12 build fails as:
../../gdbserver/../gdb/nat/linux-osdata.c: In function 'void linux_xfer_osdata_processes(buffer*)':
../../gdbserver/../gdb/nat/linux-osdata.c:330:39: error:
'__builtin___sprintf_chk' may write a terminating nul past the end of the destination [-Werror=format-overflow=]
330 | sprintf (core_str, "%d", i);
| ^
It's an off-by-one case in an infeasible scenario for negative
huge core count. The change switches to std::string for memory
handling.
Tested by running 'info os processes' and checking CPU cores column.
|
||
|---|---|---|
| .. | ||
| aarch64-linux-hw-point.c | ||
| aarch64-linux-hw-point.h | ||
| aarch64-linux.c | ||
| aarch64-linux.h | ||
| aarch64-mte-linux-ptrace.c | ||
| aarch64-mte-linux-ptrace.h | ||
| aarch64-sve-linux-ptrace.c | ||
| aarch64-sve-linux-ptrace.h | ||
| aarch64-sve-linux-sigcontext.h | ||
| amd64-linux-siginfo.c | ||
| amd64-linux-siginfo.h | ||
| fork-inferior.c | ||
| fork-inferior.h | ||
| gdb_ptrace.h | ||
| gdb_thread_db.h | ||
| glibc_thread_db.h | ||
| linux-btrace.c | ||
| linux-btrace.h | ||
| linux-namespaces.c | ||
| linux-namespaces.h | ||
| linux-nat.h | ||
| linux-osdata.c | ||
| linux-osdata.h | ||
| linux-personality.c | ||
| linux-personality.h | ||
| linux-procfs.c | ||
| linux-procfs.h | ||
| linux-ptrace.c | ||
| linux-ptrace.h | ||
| linux-waitpid.c | ||
| linux-waitpid.h | ||
| mips-linux-watch.c | ||
| mips-linux-watch.h | ||
| netbsd-nat.c | ||
| netbsd-nat.h | ||
| ppc-linux.c | ||
| ppc-linux.h | ||
| riscv-linux-tdesc.c | ||
| riscv-linux-tdesc.h | ||
| windows-nat.c | ||
| windows-nat.h | ||
| x86-cpuid.h | ||
| x86-dregs.c | ||
| x86-dregs.h | ||
| x86-gcc-cpuid.h | ||
| x86-linux-dregs.c | ||
| x86-linux-dregs.h | ||
| x86-linux.c | ||
| x86-linux.h | ||