binutils-gdb modified for the FreeChainXenon project
Find a file
Simon Marchi 237f6eac15 gdbserver/tracepoint.cc: use snprintf in gdb_agent_socket_init
If we modify tracepoint.cc to try to use a too long unix socket name,
for example by modifying SOCK_DIR to be:

    #define SOCK_DIR "/tmp/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut/salut"

... trying to start an application with libinproctrace.so loaded
crashes:

    $ LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libasan.so.6:./libinproctrace.so /bin/ls
    /home/smarchi/src/binutils-gdb/gdbserver/../gdbsupport/common-utils.cc:69: A problem internal to GDBserver in-process agent has been detected.
    xsnprintf: Assertion `ret < size' failed.

Looking at the rest of the socket initialization code, the intent seems
to be that if something goes wrong, we warn but let the program
execute.  So crashing on this failed assertions seems against the intent.

Commit 6cebaf6e1a ("use xsnprintf instead of snprintf.") changed this
code to use xsnprintf instead of snprintf, introducing this assertion.
Before that, snprintf would return a value bigger that UNIX_PATH_MAX and
the "if" after would catch it and emit a warning, which is exactly what
we want.  That change was done because LynxOS didn't have snprintf.
Since LynxOS isn't supported anymore, we can simply revert to use
snprintf there.

With this patch, we get a warning (printed by the caller of
gdb_agent_socket_init), but the program keeps executing:

    $ LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libasan.so.6:./libinproctrace.so /bin/ls
    ipa: could not create sync socket
    ...

Change-Id: I78bca52d5dc3145335abeae45a42052701e3f5dd
2021-12-14 14:35:05 -05:00
bfd bfd: fix -Wunused errors with clang 13+ 2021-12-14 08:47:48 -05:00
binutils Don't return the main file as the separate debug info 2021-12-10 17:52:40 -08:00
config Deprecate a.out support for NetBSD targets. 2021-08-11 13:17:54 +01:00
contrib Import mklog.py from gcc repo 2020-09-25 10:24:44 -04:00
cpu Re: opcodes: constify & local meps macros 2021-07-05 21:40:49 +09:30
elfcpp [GOLD] PowerPC64 @notoc in non-power10 code 2021-12-11 14:52:36 +10:30
etc etc: switch to automake 2021-09-09 23:30:12 -04:00
gas RISC-V: Clarify the behavior of .option arch directive. 2021-12-09 15:55:04 +08:00
gdb gdb/mi: rename build_table to add_builtin_mi_commands 2021-12-14 11:44:44 +00:00
gdbserver gdbserver/tracepoint.cc: use snprintf in gdb_agent_socket_init 2021-12-14 14:35:05 -05:00
gdbsupport Revert "gdbsupport: remove unnecessary #ifndef IN_PROCESS_AGENT" 2021-12-09 19:03:55 -05:00
gnulib gnulib: import various network functions 2021-09-08 17:48:09 -04:00
gold [GOLD] PowerPC64 @notoc in non-power10 code 2021-12-11 14:52:36 +10:30
gprof gprof: enable silent build rules 2021-11-29 20:28:29 -05:00
include Support AT_FXRNG and AT_KPRELOAD on FreeBSD. 2021-12-07 10:29:01 -08:00
intl Regenerate a couple of files 2021-11-15 12:20:12 +10:30
ld RISC-V: Added ld testcases for the medlow and medany code models. 2021-12-14 13:21:20 +08:00
libbacktrace sync libbacktrace from gcc 2021-11-14 18:07:50 +10:30
libctf libctf: workaround automake bug with conditional info pages 2021-12-02 23:26:18 -05:00
libdecnumber Run autoreconf -vf throughout 2020-07-29 16:03:55 -04:00
libiberty Deprecate a.out support for NetBSD targets. 2021-08-11 13:17:54 +01:00
opcodes aarch64: Fix uninitialised memory 2021-12-03 11:57:17 +00:00
readline Update config.sub and config.guess for MIPS R3 and R5 ISA support 2021-05-24 18:11:49 +02:00
sim sim: use ## for automake comments 2021-12-09 01:40:28 -05:00
texinfo
zlib zlib: enable silent build rules 2021-11-29 20:28:29 -05:00
.cvsignore
.gitattributes
.gitignore Add gnu global outputs to .gitignore 2020-12-02 10:00:27 -05:00
ar-lib Bump to autoconf 2.69 and automake 1.15.1 2018-06-19 16:55:06 -04:00
ChangeLog Document "memory-tag-violations". 2021-10-29 13:31:37 +03:00
compile
config-ml.in
config.guess Update config.sub and config.guess for MIPS R3 and R5 ISA support 2021-05-24 18:11:49 +02:00
config.rpath
config.sub Update config.sub and config.guess for MIPS R3 and R5 ISA support 2021-05-24 18:11:49 +02:00
configure top-level configure: setup target_configdirs based on repository 2021-09-28 12:21:21 +01:00
configure.ac top-level configure: setup target_configdirs based on repository 2021-09-28 12:21:21 +01:00
COPYING
COPYING.LIB
COPYING.LIBGLOSS
COPYING.NEWLIB
COPYING3
COPYING3.LIB
depcomp
djunpack.bat
install-sh
libtool.m4 libtool.m4: fix nm BSD flag detection 2021-09-27 20:31:23 +01:00
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
lt~obsolete.m4
MAINTAINERS MAINTAINERS: Update path to readline config.{sub,guess} files 2021-05-24 18:11:49 +02:00
Makefile.def Import Makefile.def from gcc 2021-11-12 19:02:12 +10:30
Makefile.in Sync Makefile.tpl with GCC 2021-11-13 09:04:03 -08:00
Makefile.tpl Sync Makefile.tpl with GCC 2021-11-13 09:04:03 -08:00
makefile.vms
missing
mkdep
mkinstalldirs
move-if-change
multilib.am Merge autoconf / automake update changes from GCC. 2018-10-31 17:10:56 +00:00
README
README-maintainer-mode Bump to autoconf 2.69 and automake 1.15.1 2018-06-19 16:55:06 -04:00
setup.com
src-release.sh src-release.sh: add libbacktrace to GDB_SUPPORT_DIRS 2021-09-28 12:21:21 +01:00
symlink-tree
test-driver Bump to autoconf 2.69 and automake 1.15.1 2018-06-19 16:55:06 -04:00
ylwrap

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.