binutils-gdb/gdb/cli
Andrew Burgess 19c659f164 gdb: improve the warning given for deprecated aliases with a prefix
Consider this GDB session:

  (gdb) define set xxx_yyy
  Type commands for definition of "set xxx_yyy".
  End with a line saying just "end".
  >echo in set xxx_yyy command\n
  >end
  (gdb) alias set qqq_aaa=set xxx_yyy
  (gdb) maintenance deprecate set qqq_aaa
  (gdb) set qqq_aaa
  Warning: 'qqq_aaa', an alias for the command 'xxx_yyy' is deprecated.
  No alternative known.

  in set xxx_yyy command
  (gdb)

Notice the warning mentions 'qqq_aaa' and 'xxx_yyy', I consider this
to be wrong.  I think the proper warning should read:

  (gdb) set qqq_aaa
  Warning: 'set qqq_aaa', an alias for the command 'set xxx_yyy', is deprecated.
  No alternative known.

With the 'set' prefixes added and a comma before the final 'is
deprecated'.  That is what this patch does.  The expected results are
updated as needed.

gdb/ChangeLog:

	* cli/cli-decode.c (deprecated_cmd_warning): Ignore the prefix
	result from lookup_cmd_composition_1, use the prefixes from both
	the command and the alias instead.
	(lookup_cmd_composition_1): Initial prefix command is the based on
	the search list being passed in.  Simplify the logic for tracking
	the prefix command.  Replace a use of alloca with a local
	std::string.

gdb/testsuite/ChangeLog:

	* gdb.base/commands.exp: Update expected results.
2020-12-11 22:10:50 +00:00
..
cli-cmds.c gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
cli-cmds.h Update copyright year range in all GDB files. 2020-01-01 10:20:53 +04:00
cli-decode.c gdb: improve the warning given for deprecated aliases with a prefix 2020-12-11 22:10:50 +00:00
cli-decode.h gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
cli-dump.c Remove target_has_execution macro 2020-09-28 19:52:21 -06:00
cli-interp.c gdb: add back declarations for _initialize functions 2020-01-13 14:01:38 -05:00
cli-interp.h Update copyright year range in all GDB files. 2020-01-01 10:20:53 +04:00
cli-logging.c Update more calls to add_prefix_cmd 2020-05-03 11:31:20 -06:00
cli-option.c Update copyright year range in all GDB files. 2020-01-01 10:20:53 +04:00
cli-option.h Update copyright year range in all GDB files. 2020-01-01 10:20:53 +04:00
cli-script.c gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
cli-script.h Update copyright year range in all GDB files. 2020-01-01 10:20:53 +04:00
cli-setshow.c gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
cli-setshow.h Fix inconsistent output of prefix and bugs in 'show' command 2020-05-15 22:17:45 +02:00
cli-style.c Revert "Add completion styling" 2020-05-24 20:27:48 -06:00
cli-style.h Revert "Add completion styling" 2020-05-24 20:27:48 -06:00
cli-utils.c gdb: remove TYPE_CODE macro 2020-05-14 13:46:38 -04:00
cli-utils.h Update copyright year range in all GDB files. 2020-01-01 10:20:53 +04:00