
This patch starts from the desire to eliminate make_cleanup_ui_file_delete, but then goes beyond. It makes ui_file & friends a real C++ class hierarchy, and switches temporary ui_file-like objects to stack-based allocation. - mem_fileopen -> string_file mem_fileopen is replaced with a new string_file class that is treated as a value class created on the stack. This alone eliminates most make_cleanup_ui_file_delete calls, and, simplifies code a whole lot (diffstat shows around 1k loc dropped.) string_file's internal buffer is a std::string, thus the "string" in the name. This simplifies the implementation much, compared to mem_fileopen, which managed growing its internal buffer manually. - ui_file_as_string, ui_file_strdup, ui_file_obsavestring all gone The new string_file class has a string() method that provides direct writable access to the internal std::string buffer. This replaced ui_file_as_string, which forced a copy of the same data the stream had inside. With direct access via a writable reference, we can instead move the string out of the string_stream, avoiding deep string copying. Related, ui_file_xstrdup calls are replaced with xstrdup'ping the stream's string, and ui_file_obsavestring is replaced by obstack_copy0. With all those out of the way, getting rid of the weird ui_file_put mechanism was possible. - New ui_file::printf, ui_file::puts, etc. methods These simplify / clarify client code. I considered splitting client-code changes, like these, e.g.: - stb = mem_fileopen (); - fprintf_unfiltered (stb, "%s%s%s", - _("The valid values are:\n"), - regdesc, - _("The default is \"std\".")); + string_file stb; + stb.printf ("%s%s%s", + _("The valid values are:\n"), + regdesc, + _("The default is \"std\".")); In two steps, with the first step leaving fprintf_unfiltered (etc.) calls in place, and only afterwards do a pass to change all those to call stb.printf etc.. I didn't do that split, because (when I tried), it turned out to be pointless make-work: the first pass would have to touch the fprintf_unfiltered line anyway, to replace "stb" with "&stb". - gdb_fopen replaced with stack-based objects This avoids the need for cleanups or unique_ptr's. I.e., this: struct ui_file *file = gdb_fopen (filename, "w"); if (filename == NULL) perror_with_name (filename); cleanups = make_cleanup_ui_file_delete (file); // use file. do_cleanups (cleanups); is replaced with this: stdio_file file; if (!file.open (filename, "w")) perror_with_name (filename); // use file. - odd contorsions in null_file_write / null_file_fputs around when to call to_fputs / to_write eliminated. - Global null_stream object A few places that were allocating a ui_file in order to print to "nowhere" are adjusted to instead refer to a new 'null_stream' global stream. - TUI's tui_sfileopen eliminated. TUI's ui_file much simplified The TUI's ui_file was serving a dual purpose. It supported being used as string buffer, and supported being backed by a stdio FILE. The string buffer part is gone, replaced by using of string_file. The 'FILE *' support is now much simplified, by making the TUI's ui_file inherit from stdio_file. gdb/ChangeLog: 2017-02-02 Pedro Alves <palves@redhat.com> * ada-lang.c (type_as_string): Use string_file. * ada-valprint.c (ada_print_floating): Use string_file. * ada-varobj.c (ada_varobj_scalar_image) (ada_varobj_get_value_image): Use string_file. * aix-thread.c (aix_thread_extra_thread_info): Use string_file. * arm-tdep.c (_initialize_arm_tdep): Use string_printf. * breakpoint.c (update_inserted_breakpoint_locations) (insert_breakpoint_locations, reattach_breakpoints) (print_breakpoint_location, print_one_detail_ranged_breakpoint) (print_it_watchpoint): Use string_file. (save_breakpoints): Use stdio_file. * c-exp.y (oper): Use string_file. * cli/cli-logging.c (set_logging_redirect): Use ui_file_up and tee_file. (pop_output_files): Use delete. (handle_redirections): Use stdio_file and tee_file. * cli/cli-setshow.c (do_show_command): Use string_file. * compile/compile-c-support.c (c_compute_program): Use string_file. * compile/compile-c-symbols.c (generate_vla_size): Take a 'string_file &' instead of a 'ui_file *'. (generate_c_for_for_one_variable): Take a 'string_file &' instead of a 'ui_file *'. Use string_file. (generate_c_for_variable_locations): Take a 'string_file &' instead of a 'ui_file *'. * compile/compile-internal.h (generate_c_for_for_one_variable): Take a 'string_file &' instead of a 'ui_file *'. * compile/compile-loc2c.c (push, pushf, unary, binary) (print_label, pushf_register_address, pushf_register) (do_compile_dwarf_expr_to_c): Take a 'string_file &' instead of a 'ui_file *'. Adjust. * compile/compile.c (compile_to_object): Use string_file. * compile/compile.h (compile_dwarf_expr_to_c) (compile_dwarf_bounds_to_c): Take a 'string_file &' instead of a 'ui_file *'. * cp-support.c (inspect_type): Use string_file and obstack_copy0. (replace_typedefs_qualified_name): Use string_file and obstack_copy0. * disasm.c (gdb_pretty_print_insn): Use string_file. (gdb_disassembly): Adjust reference the null_stream global. (do_ui_file_delete): Delete. (gdb_insn_length): Use null_stream. * dummy-frame.c (maintenance_print_dummy_frames): Use stdio_file. * dwarf2loc.c (dwarf2_compile_property_to_c) (locexpr_generate_c_location, loclist_generate_c_location): Take a 'string_file &' instead of a 'ui_file *'. * dwarf2loc.h (dwarf2_compile_property_to_c): Likewise. * dwarf2read.c (do_ui_file_peek_last): Delete. (dwarf2_compute_name): Use string_file. * event-top.c (gdb_setup_readline): Use stdio_file. * gdbarch.sh (verify_gdbarch): Use string_file. * gdbtypes.c (safe_parse_type): Use null_stream. * guile/scm-breakpoint.c (gdbscm_breakpoint_commands): Use string_file. * guile/scm-disasm.c (gdbscm_print_insn_from_port): Take a 'string_file *' instead of a 'ui_file *'. (gdbscm_arch_disassemble): Use string_file. * guile/scm-frame.c (frscm_print_frame_smob): Use string_file. * guile/scm-ports.c (class ioscm_file_port): Now a class that inherits from ui_file. (ioscm_file_port_delete, ioscm_file_port_rewind) (ioscm_file_port_put): Delete. (ioscm_file_port_write): Rename to ... (ioscm_file_port::write): ... this. Remove file_port_magic checks. (ioscm_file_port_new): Delete. (ioscm_with_output_to_port_worker): Use ioscm_file_port and ui_file_up. * guile/scm-type.c (tyscm_type_name): Use string_file. * guile/scm-value.c (vlscm_print_value_smob, gdbscm_value_print): Use string_file. * infcmd.c (print_return_value_1): Use string_file. * infrun.c (print_target_wait_results): Use string_file. * language.c (add_language): Use string_file. * location.c (explicit_to_string_internal): Use string_file. * main.c (captured_main_1): Use null_file. * maint.c (maintenance_print_architecture): Use stdio_file. * mi/mi-cmd-stack.c (list_arg_or_local): Use string_file. * mi/mi-common.h (struct mi_interp) <out, err, log, targ, event_channel>: Change type to mi_console_file pointer. * mi/mi-console.c (mi_console_file_fputs, mi_console_file_flush) (mi_console_file_delete): Delete. (struct mi_console_file): Delete. (mi_console_file_magic): Delete. (mi_console_file_new): Delete. (mi_console_file::mi_console_file): New. (mi_console_file_delete): Delete. (mi_console_file_fputs): Delete. (mi_console_file::write): New. (mi_console_raw_packet): Delete. (mi_console_file::flush): New. (mi_console_file_flush): Delete. (mi_console_set_raw): Rename to ... (mi_console_file::set_raw): ... this. * mi/mi-console.h (class mi_console_file): New class. (mi_console_file_new, mi_console_set_raw): Delete. * mi/mi-interp.c (mi_interpreter_init): Use mi_console_file. (mi_set_logging): Use delete and tee_file. Adjust. * mi/mi-main.c (output_register): Use string_file. (mi_cmd_data_evaluate_expression): Use string_file. (mi_cmd_data_read_memory): Use string_file. (mi_cmd_execute, print_variable_or_computed): Use string_file. * mi/mi-out.c (mi_ui_out::main_stream): New. (mi_ui_out::rewind): Use main_stream and string_file. (mi_ui_out::put): Use main_stream and string_file. (mi_ui_out::mi_ui_out): Remove 'stream' parameter. Allocate a 'string_file' instead. (mi_out_new): Don't allocate a mem_fileopen stream here. * mi/mi-out.h (mi_ui_out::mi_ui_out): Remove 'stream' parameter. (mi_ui_out::main_stream): Declare method. * printcmd.c (eval_command): Use string_file. * psymtab.c (maintenance_print_psymbols): Use stdio_file. * python/py-arch.c (archpy_disassemble): Use string_file. * python/py-breakpoint.c (bppy_get_commands): Use string_file. * python/py-frame.c (frapy_str): Use string_file. * python/py-framefilter.c (py_print_type, py_print_single_arg): Use string_file. * python/py-type.c (typy_str): Use string_file. * python/py-unwind.c (unwind_infopy_str): Use string_file. * python/py-value.c (valpy_str): Use string_file. * record-btrace.c (btrace_insn_history): Use string_file. * regcache.c (regcache_print): Use stdio_file. * reggroups.c (maintenance_print_reggroups): Use stdio_file. * remote.c (escape_buffer): Use string_file. * rust-lang.c (rust_get_disr_info): Use string_file. * serial.c (serial_open_ops_1): Use stdio_file. (do_serial_close): Use delete. * stack.c (print_frame_arg): Use string_file. (print_frame_args): Remove local mem_fileopen stream, not used. (print_frame): Use string_file. * symmisc.c (maintenance_print_symbols): Use stdio_file. * symtab.h (struct symbol_computed_ops) <generate_c_location>: Take a 'string_file *' instead of a 'ui_file *'. * top.c (new_ui): Use stdio_file and stderr_file. (free_ui): Use delete. (execute_command_to_string): Use string_file. (quit_confirm): Use string_file. * tracepoint.c (collection_list::append_exp): Use string_file. * tui/tui-disasm.c (tui_disassemble): Use string_file. * tui/tui-file.c: Don't include "ui-file.h". (enum streamtype, struct tui_stream): Delete. (tui_file_new, tui_file_delete, tui_fileopen, tui_sfileopen) (tui_file_isatty, tui_file_rewind, tui_file_put): Delete. (tui_file::tui_file): New method. (tui_file_fputs): Delete. (tui_file_get_strbuf): Delete. (tui_file::puts): New method. (tui_file_adjust_strbuf): Delete. (tui_file_flush): Delete. (tui_file::flush): New method. * tui/tui-file.h: Tweak intro comment. Include ui-file.h. (tui_fileopen, tui_sfileopen, tui_file_get_strbuf) (tui_file_adjust_strbuf): Delete declarations. (class tui_file): New class. * tui/tui-io.c (tui_initialize_io): Use tui_file. * tui/tui-regs.c (tui_restore_gdbout): Use delete. (tui_register_format): Use string_stream. * tui/tui-stack.c (tui_make_status_line): Use string_file. (tui_get_function_from_frame): Use string_file. * typeprint.c (type_to_string): Use string_file. * ui-file.c (struct ui_file, ui_file_magic, ui_file_new): Delete. (null_stream): New global. (ui_file_delete): Delete. (ui_file::ui_file): New. (null_file_isatty): Delete. (ui_file::~ui_file): New. (null_file_rewind): Delete. (ui_file::printf): New. (null_file_put): Delete. (null_file_flush): Delete. (ui_file::putstr): New. (null_file_write): Delete. (ui_file::putstrn): New. (null_file_read): Delete. (ui_file::putc): New. (null_file_fputs): Delete. (null_file_write_async_safe): Delete. (ui_file::vprintf): New. (null_file_delete): Delete. (null_file::write): New. (null_file_fseek): Delete. (null_file::puts): New. (ui_file_data): Delete. (null_file::write_async_safe): New. (gdb_flush, ui_file_isatty): Adjust. (ui_file_put, ui_file_rewind): Delete. (ui_file_write): Adjust. (ui_file_write_for_put): Delete. (ui_file_write_async_safe, ui_file_read): Adjust. (ui_file_fseek): Delete. (fputs_unfiltered): Adjust. (set_ui_file_flush, set_ui_file_isatty, set_ui_file_rewind) (set_ui_file_put, set_ui_file_write, set_ui_file_write_async_safe) (set_ui_file_read, set_ui_file_fputs, set_ui_file_fseek) (set_ui_file_data): Delete. (string_file::~string_file, string_file::write) (struct accumulated_ui_file, do_ui_file_xstrdup, ui_file_xstrdup) (do_ui_file_as_string, ui_file_as_string): Delete. (do_ui_file_obsavestring, ui_file_obsavestring): Delete. (struct mem_file): Delete. (mem_file_new): Delete. (stdio_file::stdio_file): New. (mem_file_delete): Delete. (stdio_file::stdio_file): New. (mem_fileopen): Delete. (stdio_file::~stdio_file): New. (mem_file_rewind): Delete. (stdio_file::set_stream): New. (mem_file_put): Delete. (stdio_file::open): New. (mem_file_write): Delete. (stdio_file_magic, struct stdio_file): Delete. (stdio_file_new, stdio_file_delete, stdio_file_flush): Delete. (stdio_file::flush): New. (stdio_file_read): Rename to ... (stdio_file::read): ... this. Adjust. (stdio_file_write): Rename to ... (stdio_file::write): ... this. Adjust. (stdio_file_write_async_safe): Rename to ... (stdio_file::write_async_safe) ... this. Adjust. (stdio_file_fputs): Rename to ... (stdio_file::puts) ... this. Adjust. (stdio_file_isatty): Delete. (stdio_file_fseek): Delete. (stdio_file::isatty): New. (stderr_file_write): Rename to ... (stderr_file::write) ... this. Adjust. (stderr_file_fputs): Rename to ... (stderr_file::puts) ... this. Adjust. (stderr_fileopen, stdio_fileopen, gdb_fopen): Delete. (stderr_file::stderr_file): New. (tee_file_magic): Delete. (struct tee_file): Delete. (tee_file::tee_file): New. (tee_file_new): Delete. (tee_file::~tee_file): New. (tee_file_delete): Delete. (tee_file_flush): Rename to ... (tee_file::flush): ... this. Adjust. (tee_file_write): Rename to ... (tee_file::write): ... this. Adjust. (tee_file::write_async_safe): New. (tee_file_fputs): Rename to ... (tee_file::puts): ... this. Adjust. (tee_file_isatty): Rename to ... (tee_file::isatty): ... this. Adjust. * ui-file.h (struct obstack, struct ui_file): Don't forward-declare. (ui_file_new, ui_file_flush_ftype, set_ui_file_flush) (ui_file_write_ftype) (set_ui_file_write, ui_file_fputs_ftype, set_ui_file_fputs) (ui_file_write_async_safe_ftype, set_ui_file_write_async_safe) (ui_file_read_ftype, set_ui_file_read, ui_file_isatty_ftype) (set_ui_file_isatty, ui_file_rewind_ftype, set_ui_file_rewind) (ui_file_put_method_ftype, ui_file_put_ftype, set_ui_file_put) (ui_file_delete_ftype, set_ui_file_data, ui_file_fseek_ftype) (set_ui_file_fseek): Delete. (ui_file_data, ui_file_delete, ui_file_rewind) (struct ui_file): New. (ui_file_up): New. (class null_file): New. (null_stream): Declare. (ui_file_write_for_put, ui_file_put): Delete. (ui_file_xstrdup, ui_file_as_string, ui_file_obsavestring): Delete. (ui_file_fseek, mem_fileopen, stdio_fileopen, stderr_fileopen) (gdb_fopen, tee_file_new): Delete. (struct string_file): New. (struct stdio_file): New. (stdio_file_up): New. (struct stderr_file): New. (class tee_file): New. * ui-out.c (ui_out::field_stream): Take a 'string_file &' instead of a 'ui_file *'. Adjust. * ui-out.h (class ui_out) <field_stream>: Likewise. * utils.c (do_ui_file_delete, make_cleanup_ui_file_delete) (null_stream): Delete. (error_stream): Take a 'string_file &' instead of a 'ui_file *'. Adjust. * utils.h (struct ui_file): Delete forward declaration.. (make_cleanup_ui_file_delete, null_stream): Delete declarations. (error_stream): Take a 'string_file &' instead of a 'ui_file *'. * varobj.c (varobj_value_get_print_value): Use string_file. * xtensa-tdep.c (xtensa_verify_config): Use string_file. * gdbarch.c: Regenerate.
744 lines
21 KiB
C
744 lines
21 KiB
C
/* General Compile and inject code
|
||
|
||
Copyright (C) 2014-2017 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "top.h"
|
||
#include "ui-out.h"
|
||
#include "command.h"
|
||
#include "cli/cli-script.h"
|
||
#include "cli/cli-utils.h"
|
||
#include "completer.h"
|
||
#include "gdbcmd.h"
|
||
#include "compile.h"
|
||
#include "compile-internal.h"
|
||
#include "compile-object-load.h"
|
||
#include "compile-object-run.h"
|
||
#include "language.h"
|
||
#include "frame.h"
|
||
#include "source.h"
|
||
#include "block.h"
|
||
#include "arch-utils.h"
|
||
#include "filestuff.h"
|
||
#include "target.h"
|
||
#include "osabi.h"
|
||
#include "gdb_wait.h"
|
||
#include "valprint.h"
|
||
|
||
|
||
|
||
/* Initial filename for temporary files. */
|
||
|
||
#define TMP_PREFIX "/tmp/gdbobj-"
|
||
|
||
/* Hold "compile" commands. */
|
||
|
||
static struct cmd_list_element *compile_command_list;
|
||
|
||
/* Debug flag for "compile" commands. */
|
||
|
||
int compile_debug;
|
||
|
||
/* Implement "show debug compile". */
|
||
|
||
static void
|
||
show_compile_debug (struct ui_file *file, int from_tty,
|
||
struct cmd_list_element *c, const char *value)
|
||
{
|
||
fprintf_filtered (file, _("Compile debugging is %s.\n"), value);
|
||
}
|
||
|
||
|
||
|
||
/* Check *ARG for a "-raw" or "-r" argument. Return 0 if not seen.
|
||
Return 1 if seen and update *ARG. */
|
||
|
||
static int
|
||
check_raw_argument (char **arg)
|
||
{
|
||
*arg = skip_spaces (*arg);
|
||
|
||
if (arg != NULL
|
||
&& (check_for_argument (arg, "-raw", sizeof ("-raw") - 1)
|
||
|| check_for_argument (arg, "-r", sizeof ("-r") - 1)))
|
||
return 1;
|
||
return 0;
|
||
}
|
||
|
||
/* Handle the input from the 'compile file' command. The "compile
|
||
file" command is used to evaluate an expression contained in a file
|
||
that may contain calls to the GCC compiler. */
|
||
|
||
static void
|
||
compile_file_command (char *arg, int from_tty)
|
||
{
|
||
enum compile_i_scope_types scope = COMPILE_I_SIMPLE_SCOPE;
|
||
char *buffer;
|
||
struct cleanup *cleanup;
|
||
|
||
scoped_restore save_async = make_scoped_restore (¤t_ui->async, 0);
|
||
|
||
/* Check the user did not just <enter> after command. */
|
||
if (arg == NULL)
|
||
error (_("You must provide a filename for this command."));
|
||
|
||
/* Check if a raw (-r|-raw) argument is provided. */
|
||
if (arg != NULL && check_raw_argument (&arg))
|
||
{
|
||
scope = COMPILE_I_RAW_SCOPE;
|
||
arg = skip_spaces (arg);
|
||
}
|
||
|
||
/* After processing arguments, check there is a filename at the end
|
||
of the command. */
|
||
if (arg[0] == '\0')
|
||
error (_("You must provide a filename with the raw option set."));
|
||
|
||
if (arg[0] == '-')
|
||
error (_("Unknown argument specified."));
|
||
|
||
arg = skip_spaces (arg);
|
||
arg = gdb_abspath (arg);
|
||
cleanup = make_cleanup (xfree, arg);
|
||
buffer = xstrprintf ("#include \"%s\"\n", arg);
|
||
make_cleanup (xfree, buffer);
|
||
eval_compile_command (NULL, buffer, scope, NULL);
|
||
do_cleanups (cleanup);
|
||
}
|
||
|
||
/* Handle the input from the 'compile code' command. The
|
||
"compile code" command is used to evaluate an expression that may
|
||
contain calls to the GCC compiler. The language expected in this
|
||
compile command is the language currently set in GDB. */
|
||
|
||
static void
|
||
compile_code_command (char *arg, int from_tty)
|
||
{
|
||
enum compile_i_scope_types scope = COMPILE_I_SIMPLE_SCOPE;
|
||
|
||
scoped_restore save_async = make_scoped_restore (¤t_ui->async, 0);
|
||
|
||
if (arg != NULL && check_raw_argument (&arg))
|
||
{
|
||
scope = COMPILE_I_RAW_SCOPE;
|
||
arg = skip_spaces (arg);
|
||
}
|
||
|
||
arg = skip_spaces (arg);
|
||
|
||
if (arg != NULL && !check_for_argument (&arg, "--", sizeof ("--") - 1))
|
||
{
|
||
if (arg[0] == '-')
|
||
error (_("Unknown argument specified."));
|
||
}
|
||
|
||
if (arg && *arg)
|
||
eval_compile_command (NULL, arg, scope, NULL);
|
||
else
|
||
{
|
||
struct command_line *l = get_command_line (compile_control, "");
|
||
struct cleanup *cleanup = make_cleanup_free_command_lines (&l);
|
||
|
||
l->control_u.compile.scope = scope;
|
||
execute_control_command_untraced (l);
|
||
do_cleanups (cleanup);
|
||
}
|
||
}
|
||
|
||
/* Callback for compile_print_command. */
|
||
|
||
void
|
||
compile_print_value (struct value *val, void *data_voidp)
|
||
{
|
||
const struct format_data *fmtp = (const struct format_data *) data_voidp;
|
||
|
||
print_value (val, fmtp);
|
||
}
|
||
|
||
/* Handle the input from the 'compile print' command. The "compile
|
||
print" command is used to evaluate and print an expression that may
|
||
contain calls to the GCC compiler. The language expected in this
|
||
compile command is the language currently set in GDB. */
|
||
|
||
static void
|
||
compile_print_command (char *arg_param, int from_tty)
|
||
{
|
||
const char *arg = arg_param;
|
||
enum compile_i_scope_types scope = COMPILE_I_PRINT_ADDRESS_SCOPE;
|
||
struct format_data fmt;
|
||
|
||
scoped_restore save_async = make_scoped_restore (¤t_ui->async, 0);
|
||
|
||
/* Passing &FMT as SCOPE_DATA is safe as do_module_cleanup will not
|
||
touch the stale pointer if compile_object_run has already quit. */
|
||
print_command_parse_format (&arg, "compile print", &fmt);
|
||
|
||
if (arg && *arg)
|
||
eval_compile_command (NULL, arg, scope, &fmt);
|
||
else
|
||
{
|
||
struct command_line *l = get_command_line (compile_control, "");
|
||
struct cleanup *cleanup = make_cleanup_free_command_lines (&l);
|
||
|
||
l->control_u.compile.scope = scope;
|
||
l->control_u.compile.scope_data = &fmt;
|
||
execute_control_command_untraced (l);
|
||
do_cleanups (cleanup);
|
||
}
|
||
}
|
||
|
||
/* A cleanup function to remove a directory and all its contents. */
|
||
|
||
static void
|
||
do_rmdir (void *arg)
|
||
{
|
||
const char *dir = (const char *) arg;
|
||
char *zap;
|
||
int wstat;
|
||
|
||
gdb_assert (startswith (dir, TMP_PREFIX));
|
||
zap = concat ("rm -rf ", dir, (char *) NULL);
|
||
wstat = system (zap);
|
||
if (wstat == -1 || !WIFEXITED (wstat) || WEXITSTATUS (wstat) != 0)
|
||
warning (_("Could not remove temporary directory %s"), dir);
|
||
XDELETEVEC (zap);
|
||
}
|
||
|
||
/* Return the name of the temporary directory to use for .o files, and
|
||
arrange for the directory to be removed at shutdown. */
|
||
|
||
static const char *
|
||
get_compile_file_tempdir (void)
|
||
{
|
||
static char *tempdir_name;
|
||
|
||
#define TEMPLATE TMP_PREFIX "XXXXXX"
|
||
char tname[sizeof (TEMPLATE)];
|
||
|
||
if (tempdir_name != NULL)
|
||
return tempdir_name;
|
||
|
||
strcpy (tname, TEMPLATE);
|
||
#undef TEMPLATE
|
||
#ifdef HAVE_MKDTEMP
|
||
tempdir_name = mkdtemp (tname);
|
||
#else
|
||
error (_("Command not supported on this host."));
|
||
#endif
|
||
if (tempdir_name == NULL)
|
||
perror_with_name (_("Could not make temporary directory"));
|
||
|
||
tempdir_name = xstrdup (tempdir_name);
|
||
make_final_cleanup (do_rmdir, tempdir_name);
|
||
return tempdir_name;
|
||
}
|
||
|
||
/* Compute the names of source and object files to use. */
|
||
|
||
static compile_file_names
|
||
get_new_file_names ()
|
||
{
|
||
static int seq;
|
||
const char *dir = get_compile_file_tempdir ();
|
||
|
||
++seq;
|
||
|
||
return compile_file_names (string_printf ("%s%sout%d.c",
|
||
dir, SLASH_STRING, seq),
|
||
string_printf ("%s%sout%d.o",
|
||
dir, SLASH_STRING, seq));
|
||
}
|
||
|
||
/* Get the block and PC at which to evaluate an expression. */
|
||
|
||
static const struct block *
|
||
get_expr_block_and_pc (CORE_ADDR *pc)
|
||
{
|
||
const struct block *block = get_selected_block (pc);
|
||
|
||
if (block == NULL)
|
||
{
|
||
struct symtab_and_line cursal = get_current_source_symtab_and_line ();
|
||
|
||
if (cursal.symtab)
|
||
block = BLOCKVECTOR_BLOCK (SYMTAB_BLOCKVECTOR (cursal.symtab),
|
||
STATIC_BLOCK);
|
||
if (block != NULL)
|
||
*pc = BLOCK_START (block);
|
||
}
|
||
else
|
||
*pc = BLOCK_START (block);
|
||
|
||
return block;
|
||
}
|
||
|
||
/* Call gdb_buildargv, set its result for S into *ARGVP but calculate also the
|
||
number of parsed arguments into *ARGCP. If gdb_buildargv has returned NULL
|
||
then *ARGCP is set to zero. */
|
||
|
||
static void
|
||
build_argc_argv (const char *s, int *argcp, char ***argvp)
|
||
{
|
||
*argvp = gdb_buildargv (s);
|
||
*argcp = countargv (*argvp);
|
||
}
|
||
|
||
/* String for 'set compile-args' and 'show compile-args'. */
|
||
static char *compile_args;
|
||
|
||
/* Parsed form of COMPILE_ARGS. COMPILE_ARGS_ARGV is NULL terminated. */
|
||
static int compile_args_argc;
|
||
static char **compile_args_argv;
|
||
|
||
/* Implement 'set compile-args'. */
|
||
|
||
static void
|
||
set_compile_args (char *args, int from_tty, struct cmd_list_element *c)
|
||
{
|
||
freeargv (compile_args_argv);
|
||
build_argc_argv (compile_args, &compile_args_argc, &compile_args_argv);
|
||
}
|
||
|
||
/* Implement 'show compile-args'. */
|
||
|
||
static void
|
||
show_compile_args (struct ui_file *file, int from_tty,
|
||
struct cmd_list_element *c, const char *value)
|
||
{
|
||
fprintf_filtered (file, _("Compile command command-line arguments "
|
||
"are \"%s\".\n"),
|
||
value);
|
||
}
|
||
|
||
/* Append ARGC and ARGV (as parsed by build_argc_argv) to *ARGCP and *ARGVP.
|
||
ARGCP+ARGVP can be zero+NULL and also ARGC+ARGV can be zero+NULL. */
|
||
|
||
static void
|
||
append_args (int *argcp, char ***argvp, int argc, char **argv)
|
||
{
|
||
int argi;
|
||
|
||
*argvp = XRESIZEVEC (char *, *argvp, (*argcp + argc + 1));
|
||
|
||
for (argi = 0; argi < argc; argi++)
|
||
(*argvp)[(*argcp)++] = xstrdup (argv[argi]);
|
||
(*argvp)[(*argcp)] = NULL;
|
||
}
|
||
|
||
/* Return DW_AT_producer parsed for get_selected_frame () (if any).
|
||
Return NULL otherwise.
|
||
|
||
GCC already filters its command-line arguments only for the suitable ones to
|
||
put into DW_AT_producer - see GCC function gen_producer_string. */
|
||
|
||
static const char *
|
||
get_selected_pc_producer_options (void)
|
||
{
|
||
CORE_ADDR pc = get_frame_pc (get_selected_frame (NULL));
|
||
struct compunit_symtab *symtab = find_pc_compunit_symtab (pc);
|
||
const char *cs;
|
||
|
||
if (symtab == NULL || symtab->producer == NULL
|
||
|| !startswith (symtab->producer, "GNU "))
|
||
return NULL;
|
||
|
||
cs = symtab->producer;
|
||
while (*cs != 0 && *cs != '-')
|
||
cs = skip_spaces_const (skip_to_space_const (cs));
|
||
if (*cs != '-')
|
||
return NULL;
|
||
return cs;
|
||
}
|
||
|
||
/* Filter out unwanted options from *ARGCP and ARGV. */
|
||
|
||
static void
|
||
filter_args (int *argcp, char **argv)
|
||
{
|
||
char **destv;
|
||
|
||
for (destv = argv; *argv != NULL; argv++)
|
||
{
|
||
/* -fpreprocessed may get in commonly from ccache. */
|
||
if (strcmp (*argv, "-fpreprocessed") == 0)
|
||
{
|
||
xfree (*argv);
|
||
(*argcp)--;
|
||
continue;
|
||
}
|
||
*destv++ = *argv;
|
||
}
|
||
*destv = NULL;
|
||
}
|
||
|
||
/* Produce final vector of GCC compilation options. First element is target
|
||
size ("-m64", "-m32" etc.), optionally followed by DW_AT_producer options
|
||
and then compile-args string GDB variable. */
|
||
|
||
static void
|
||
get_args (const struct compile_instance *compiler, struct gdbarch *gdbarch,
|
||
int *argcp, char ***argvp)
|
||
{
|
||
const char *cs_producer_options;
|
||
int argc_compiler;
|
||
char **argv_compiler;
|
||
|
||
build_argc_argv (gdbarch_gcc_target_options (gdbarch),
|
||
argcp, argvp);
|
||
|
||
cs_producer_options = get_selected_pc_producer_options ();
|
||
if (cs_producer_options != NULL)
|
||
{
|
||
int argc_producer;
|
||
char **argv_producer;
|
||
|
||
build_argc_argv (cs_producer_options, &argc_producer, &argv_producer);
|
||
filter_args (&argc_producer, argv_producer);
|
||
append_args (argcp, argvp, argc_producer, argv_producer);
|
||
freeargv (argv_producer);
|
||
}
|
||
|
||
build_argc_argv (compiler->gcc_target_options,
|
||
&argc_compiler, &argv_compiler);
|
||
append_args (argcp, argvp, argc_compiler, argv_compiler);
|
||
freeargv (argv_compiler);
|
||
|
||
append_args (argcp, argvp, compile_args_argc, compile_args_argv);
|
||
}
|
||
|
||
/* A cleanup function to destroy a gdb_gcc_instance. */
|
||
|
||
static void
|
||
cleanup_compile_instance (void *arg)
|
||
{
|
||
struct compile_instance *inst = (struct compile_instance *) arg;
|
||
|
||
inst->destroy (inst);
|
||
}
|
||
|
||
/* A cleanup function to unlink a file. */
|
||
|
||
static void
|
||
cleanup_unlink_file (void *arg)
|
||
{
|
||
const char *filename = (const char *) arg;
|
||
|
||
unlink (filename);
|
||
}
|
||
|
||
/* A helper function suitable for use as the "print_callback" in the
|
||
compiler object. */
|
||
|
||
static void
|
||
print_callback (void *ignore, const char *message)
|
||
{
|
||
fputs_filtered (message, gdb_stderr);
|
||
}
|
||
|
||
/* Process the compilation request. On success it returns the object
|
||
and source file names. On an error condition, error () is
|
||
called. */
|
||
|
||
static compile_file_names
|
||
compile_to_object (struct command_line *cmd, const char *cmd_string,
|
||
enum compile_i_scope_types scope)
|
||
{
|
||
struct compile_instance *compiler;
|
||
struct cleanup *cleanup, *inner_cleanup;
|
||
const struct block *expr_block;
|
||
CORE_ADDR trash_pc, expr_pc;
|
||
int argc;
|
||
char **argv;
|
||
int ok;
|
||
FILE *src;
|
||
struct gdbarch *gdbarch = get_current_arch ();
|
||
const char *os_rx;
|
||
const char *arch_rx;
|
||
char *triplet_rx;
|
||
char *error_message;
|
||
|
||
if (!target_has_execution)
|
||
error (_("The program must be running for the compile command to "\
|
||
"work."));
|
||
|
||
expr_block = get_expr_block_and_pc (&trash_pc);
|
||
expr_pc = get_frame_address_in_block (get_selected_frame (NULL));
|
||
|
||
/* Set up instance and context for the compiler. */
|
||
if (current_language->la_get_compile_instance == NULL)
|
||
error (_("No compiler support for language %s."),
|
||
current_language->la_name);
|
||
compiler = current_language->la_get_compile_instance ();
|
||
cleanup = make_cleanup (cleanup_compile_instance, compiler);
|
||
|
||
compiler->fe->ops->set_print_callback (compiler->fe, print_callback, NULL);
|
||
|
||
compiler->scope = scope;
|
||
compiler->block = expr_block;
|
||
|
||
/* From the provided expression, build a scope to pass to the
|
||
compiler. */
|
||
|
||
string_file input_buf;
|
||
const char *input;
|
||
|
||
if (cmd != NULL)
|
||
{
|
||
struct command_line *iter;
|
||
|
||
for (iter = cmd->body_list[0]; iter; iter = iter->next)
|
||
{
|
||
input_buf.puts (iter->line);
|
||
input_buf.puts ("\n");
|
||
}
|
||
|
||
input = input_buf.c_str ();
|
||
}
|
||
else if (cmd_string != NULL)
|
||
input = cmd_string;
|
||
else
|
||
error (_("Neither a simple expression, or a multi-line specified."));
|
||
|
||
std::string code
|
||
= current_language->la_compute_program (compiler, input, gdbarch,
|
||
expr_block, expr_pc);
|
||
if (compile_debug)
|
||
fprintf_unfiltered (gdb_stdlog, "debug output:\n\n%s", code.c_str ());
|
||
|
||
os_rx = osabi_triplet_regexp (gdbarch_osabi (gdbarch));
|
||
arch_rx = gdbarch_gnu_triplet_regexp (gdbarch);
|
||
|
||
/* Allow triplets with or without vendor set. */
|
||
triplet_rx = concat (arch_rx, "(-[^-]*)?-", os_rx, (char *) NULL);
|
||
make_cleanup (xfree, triplet_rx);
|
||
|
||
/* Set compiler command-line arguments. */
|
||
get_args (compiler, gdbarch, &argc, &argv);
|
||
make_cleanup_freeargv (argv);
|
||
|
||
error_message = compiler->fe->ops->set_arguments (compiler->fe, triplet_rx,
|
||
argc, argv);
|
||
if (error_message != NULL)
|
||
{
|
||
make_cleanup (xfree, error_message);
|
||
error ("%s", error_message);
|
||
}
|
||
|
||
if (compile_debug)
|
||
{
|
||
int argi;
|
||
|
||
fprintf_unfiltered (gdb_stdlog, "Passing %d compiler options:\n", argc);
|
||
for (argi = 0; argi < argc; argi++)
|
||
fprintf_unfiltered (gdb_stdlog, "Compiler option %d: <%s>\n",
|
||
argi, argv[argi]);
|
||
}
|
||
|
||
compile_file_names fnames = get_new_file_names ();
|
||
|
||
src = gdb_fopen_cloexec (fnames.source_file (), "w");
|
||
if (src == NULL)
|
||
perror_with_name (_("Could not open source file for writing"));
|
||
inner_cleanup = make_cleanup (cleanup_unlink_file,
|
||
(void *) fnames.source_file ());
|
||
if (fputs (code.c_str (), src) == EOF)
|
||
perror_with_name (_("Could not write to source file"));
|
||
fclose (src);
|
||
|
||
if (compile_debug)
|
||
fprintf_unfiltered (gdb_stdlog, "source file produced: %s\n\n",
|
||
fnames.source_file ());
|
||
|
||
/* Call the compiler and start the compilation process. */
|
||
compiler->fe->ops->set_source_file (compiler->fe, fnames.source_file ());
|
||
|
||
if (!compiler->fe->ops->compile (compiler->fe, fnames.object_file (),
|
||
compile_debug))
|
||
error (_("Compilation failed."));
|
||
|
||
if (compile_debug)
|
||
fprintf_unfiltered (gdb_stdlog, "object file produced: %s\n\n",
|
||
fnames.object_file ());
|
||
|
||
discard_cleanups (inner_cleanup);
|
||
do_cleanups (cleanup);
|
||
|
||
return fnames;
|
||
}
|
||
|
||
/* The "compile" prefix command. */
|
||
|
||
static void
|
||
compile_command (char *args, int from_tty)
|
||
{
|
||
/* If a sub-command is not specified to the compile prefix command,
|
||
assume it is a direct code compilation. */
|
||
compile_code_command (args, from_tty);
|
||
}
|
||
|
||
/* See compile.h. */
|
||
|
||
void
|
||
eval_compile_command (struct command_line *cmd, const char *cmd_string,
|
||
enum compile_i_scope_types scope, void *scope_data)
|
||
{
|
||
struct cleanup *cleanup_unlink;
|
||
struct compile_module *compile_module;
|
||
|
||
compile_file_names fnames = compile_to_object (cmd, cmd_string, scope);
|
||
|
||
cleanup_unlink = make_cleanup (cleanup_unlink_file,
|
||
(void *) fnames.object_file ());
|
||
make_cleanup (cleanup_unlink_file, (void *) fnames.source_file ());
|
||
compile_module = compile_object_load (fnames, scope, scope_data);
|
||
if (compile_module == NULL)
|
||
{
|
||
gdb_assert (scope == COMPILE_I_PRINT_ADDRESS_SCOPE);
|
||
eval_compile_command (cmd, cmd_string,
|
||
COMPILE_I_PRINT_VALUE_SCOPE, scope_data);
|
||
return;
|
||
}
|
||
discard_cleanups (cleanup_unlink);
|
||
compile_object_run (compile_module);
|
||
}
|
||
|
||
/* See compile/compile-internal.h. */
|
||
|
||
char *
|
||
compile_register_name_mangled (struct gdbarch *gdbarch, int regnum)
|
||
{
|
||
const char *regname = gdbarch_register_name (gdbarch, regnum);
|
||
|
||
return xstrprintf ("__%s", regname);
|
||
}
|
||
|
||
/* See compile/compile-internal.h. */
|
||
|
||
int
|
||
compile_register_name_demangle (struct gdbarch *gdbarch,
|
||
const char *regname)
|
||
{
|
||
int regnum;
|
||
|
||
if (regname[0] != '_' || regname[1] != '_')
|
||
error (_("Invalid register name \"%s\"."), regname);
|
||
regname += 2;
|
||
|
||
for (regnum = 0; regnum < gdbarch_num_regs (gdbarch); regnum++)
|
||
if (strcmp (regname, gdbarch_register_name (gdbarch, regnum)) == 0)
|
||
return regnum;
|
||
|
||
error (_("Cannot find gdbarch register \"%s\"."), regname);
|
||
}
|
||
|
||
extern initialize_file_ftype _initialize_compile;
|
||
|
||
void
|
||
_initialize_compile (void)
|
||
{
|
||
struct cmd_list_element *c = NULL;
|
||
|
||
add_prefix_cmd ("compile", class_obscure, compile_command,
|
||
_("\
|
||
Command to compile source code and inject it into the inferior."),
|
||
&compile_command_list, "compile ", 1, &cmdlist);
|
||
add_com_alias ("expression", "compile", class_obscure, 0);
|
||
|
||
add_cmd ("code", class_obscure, compile_code_command,
|
||
_("\
|
||
Compile, inject, and execute code.\n\
|
||
\n\
|
||
Usage: compile code [-r|-raw] [--] [CODE]\n\
|
||
-r|-raw: Suppress automatic 'void _gdb_expr () { CODE }' wrapping.\n\
|
||
--: Do not parse any options beyond this delimiter. All text to the\n\
|
||
right will be treated as source code.\n\
|
||
\n\
|
||
The source code may be specified as a simple one line expression, e.g.:\n\
|
||
\n\
|
||
compile code printf(\"Hello world\\n\");\n\
|
||
\n\
|
||
Alternatively, you can type a multiline expression by invoking\n\
|
||
this command with no argument. GDB will then prompt for the\n\
|
||
expression interactively; type a line containing \"end\" to\n\
|
||
indicate the end of the expression."),
|
||
&compile_command_list);
|
||
|
||
c = add_cmd ("file", class_obscure, compile_file_command,
|
||
_("\
|
||
Evaluate a file containing source code.\n\
|
||
\n\
|
||
Usage: compile file [-r|-raw] [filename]\n\
|
||
-r|-raw: Suppress automatic 'void _gdb_expr () { CODE }' wrapping."),
|
||
&compile_command_list);
|
||
set_cmd_completer (c, filename_completer);
|
||
|
||
add_cmd ("print", class_obscure, compile_print_command,
|
||
_("\
|
||
Evaluate EXPR by using the compiler and print result.\n\
|
||
\n\
|
||
Usage: compile print[/FMT] [EXPR]\n\
|
||
\n\
|
||
The expression may be specified on the same line as the command, e.g.:\n\
|
||
\n\
|
||
compile print i\n\
|
||
\n\
|
||
Alternatively, you can type a multiline expression by invoking\n\
|
||
this command with no argument. GDB will then prompt for the\n\
|
||
expression interactively; type a line containing \"end\" to\n\
|
||
indicate the end of the expression.\n\
|
||
\n\
|
||
EXPR may be preceded with /FMT, where FMT is a format letter\n\
|
||
but no count or size letter (see \"x\" command)."),
|
||
&compile_command_list);
|
||
|
||
add_setshow_boolean_cmd ("compile", class_maintenance, &compile_debug, _("\
|
||
Set compile command debugging."), _("\
|
||
Show compile command debugging."), _("\
|
||
When on, compile command debugging is enabled."),
|
||
NULL, show_compile_debug,
|
||
&setdebuglist, &showdebuglist);
|
||
|
||
add_setshow_string_cmd ("compile-args", class_support,
|
||
&compile_args,
|
||
_("Set compile command GCC command-line arguments"),
|
||
_("Show compile command GCC command-line arguments"),
|
||
_("\
|
||
Use options like -I (include file directory) or ABI settings.\n\
|
||
String quoting is parsed like in shell, for example:\n\
|
||
-mno-align-double \"-I/dir with a space/include\""),
|
||
set_compile_args, show_compile_args, &setlist, &showlist);
|
||
|
||
/* Override flags possibly coming from DW_AT_producer. */
|
||
compile_args = xstrdup ("-O0 -gdwarf-4"
|
||
/* We use -fPIE Otherwise GDB would need to reserve space large enough for
|
||
any object file in the inferior in advance to get the final address when
|
||
to link the object file to and additionally the default system linker
|
||
script would need to be modified so that one can specify there the
|
||
absolute target address.
|
||
-fPIC is not used at is would require from GDB to generate .got. */
|
||
" -fPIE"
|
||
/* We want warnings, except for some commonly happening for GDB commands. */
|
||
" -Wall "
|
||
" -Wno-implicit-function-declaration"
|
||
" -Wno-unused-but-set-variable"
|
||
" -Wno-unused-variable"
|
||
/* Override CU's possible -fstack-protector-strong. */
|
||
" -fno-stack-protector"
|
||
);
|
||
set_compile_args (compile_args, 0, NULL);
|
||
}
|