13123da89a
Re-format all Python files using black [1] version 21.4b0. The goal is
that from now on, we keep all Python files formatted using black. And
that we never have to discuss formatting during review (for these files
at least) ever again.
One change is needed in gdb.python/py-prettyprint.exp, because it
matches the string representation of an exception, which shows source
code. So the change in formatting must be replicated in the expected
regexp.
To document our usage of black I plan on adding this to the "GDB Python
Coding Standards" wiki page [2]:
--8<--
All Python source files under the `gdb/` directory must be formatted
using black version 21.4b0.
This specific version can be installed using:
$ pip3 install 'black == 21.4b0'
All you need to do to re-format files is run `black <file/directory>`,
and black will re-format any Python file it finds in there. It runs
quite fast, so the simplest is to do:
$ black gdb/
from the top-level.
If you notice that black produces changes unrelated to your patch, it's
probably because someone forgot to run it before you. In this case,
don't include unrelated hunks in your patch. Push an obvious patch
fixing the formatting and rebase your work on top of that.
-->8--
Once this is merged, I plan on setting a up an `ignoreRevsFile`
config so that git-blame ignores this commit, as described here:
https://github.com/psf/black#migrating-your-code-style-without-ruining-git-blame
I also plan on working on a git commit hook (checked in the repo) to
automatically check the formatting of the Python files on commit.
[1] https://pypi.org/project/black/
[2] https://sourceware.org/gdb/wiki/Internals%20GDB-Python-Coding-Standards
gdb/ChangeLog:
* Re-format all Python files using black.
gdb/testsuite/ChangeLog:
* Re-format all Python files using black.
* gdb.python/py-prettyprint.exp (run_lang_tests): Adjust.
Change-Id: I28588a22c2406afd6bc2703774ddfff47cd61919
52 lines
2.1 KiB
Python
52 lines
2.1 KiB
Python
# Copyright (C) 2015-2021 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test printing of std::cerr.
|
|
# libstdc++ is typically near the end of the list of shared libraries,
|
|
# and thus searched last (or near last).
|
|
# Plus llvm had a bug where its pubnames output that gold uses to generate
|
|
# the index caused a massive perf regression (basically it emitted an entry
|
|
# for every CU that used it, whereas we only want the CU with the
|
|
# definition).
|
|
#
|
|
# Note: One difference between this test and gmonster-ptype-string.py
|
|
# is that here we do not pre-expand the symtab: we don't want include
|
|
# GDB's slowness in searching expanded symtabs first to color these results.
|
|
|
|
from perftest import perftest
|
|
from perftest import measure
|
|
from perftest import utils
|
|
|
|
|
|
class PrintCerr(perftest.TestCaseWithBasicMeasurements):
|
|
def __init__(self, name, run_names, binfile):
|
|
super(PrintCerr, self).__init__(name)
|
|
self.run_names = run_names
|
|
self.binfile = binfile
|
|
|
|
def warm_up(self):
|
|
pass
|
|
|
|
def execute_test(self):
|
|
for run in self.run_names:
|
|
this_run_binfile = "%s-%s" % (self.binfile, utils.convert_spaces(run))
|
|
utils.select_file(this_run_binfile)
|
|
utils.runto_main()
|
|
iteration = 5
|
|
while iteration > 0:
|
|
utils.safe_execute("mt flush symbol-cache")
|
|
func = lambda: utils.safe_execute("print gm_std::cerr")
|
|
self.measure.measure(func, run)
|
|
iteration -= 1
|