FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
binutils-gdb/gdb/testsuite/gdb.trace
History
Pedro Alves a2a176c46b Fix pedantically invalid DWARF in gdb.trace/unavailable-dwarf-piece.exp 
The DWARF spec says:

  Any debugging information entry representing the declaration of an object,
  module, subprogram or type may have DW_AT_decl_file, DW_AT_decl_line and
  DW_AT_decl_column attributes, each of whose value is an unsigned integer
							  ^^^^^^^^
  constant.

Grepping around the DWARF-assembler-based testcases, I noticed that
gdb.trace/unavailable-dwarf-piece.exp emits decl_line with
DW_FORM_sdata, a signed integer form.  This commit tweaks it to use
DW_FORM_udata instead.

Unsurprisingly, this:

  $ make check \
      TESTS="gdb.trace/unavailable-dwarf-piece.exp" \
      RUNTESTFLAGS="--target_board=native-gdbserver"

... still passes cleanly for me after this change.

I've noticed this because current llvm-dwarfdump crashed on an
ROCm-internal DWARF-assembler-based testcase that incorrectly used
signed forms for DW_AT_decl_file/DW_AT_decl_line.

The older llvm-dwarfdump found on Ubuntu 20.04 (LLVM 10) reads the
line numbers with signed forms as "0" instead of crashing.  Here's the
before/after fix for gdb.trace/unavailable-dwarf-piece.exp with that
llvm-dwarfdump version:

  $ diff -up before.txt after.txt
  --- before.txt    2022-07-07 13:21:28.387690334 +0100
  +++ after.txt     2022-07-07 13:21:39.379801092 +0100
  @@ -18,7 +18,7 @@
		   DW_AT_name     ("s")
		   DW_AT_byte_size        (3)
		   DW_AT_decl_file        (0)
  -                DW_AT_decl_line        (0)
  +                DW_AT_decl_line        (1)

   0x0000002f:     DW_TAG_member
		     DW_AT_name   ("a")
  @@ -41,7 +41,7 @@
		   DW_AT_name     ("t")
		   DW_AT_byte_size        (3)
		   DW_AT_decl_file        (0)
  -                DW_AT_decl_line        (0)
  +                DW_AT_decl_line        (1)

   0x00000054:     DW_TAG_member
		     DW_AT_name   ("a")

Change-Id: I5c866946356da421ff944019d0eca2607b2b738f
2022-07-07 13:27:39 +01:00
..
actions-changed.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
actions-changed.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
actions.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
actions.exp gdb: Fix DUPLICATE and PATH regressions throughout 2022-05-25 13:44:12 +01:00
ax.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
backtrace.exp gdb: Fix DUPLICATE and PATH regressions throughout 2022-05-25 13:44:12 +01:00
change-loc-1.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
change-loc-2.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
change-loc.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
change-loc.exp gdb/testsuite: remove unneeded calls to get_compiler_info 2022-06-24 15:07:29 +01:00
change-loc.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
circ.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
circ.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
collection.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
collection.exp gdb: Fix DUPLICATE and PATH regressions throughout 2022-05-25 13:44:12 +01:00
deltrace.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
disconnected-tracing.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
disconnected-tracing.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
entry-values.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
entry-values.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
ftrace-lock.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
ftrace-lock.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
ftrace.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
ftrace.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
infotrace.exp gdb: Fix DUPLICATE and PATH regressions throughout 2022-05-25 13:44:12 +01:00
mi-trace-frame-collected.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
mi-trace-save.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
mi-trace-unavailable.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
mi-traceframe-changed.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
mi-tracepoint-changed.exp gdb/testsuite: fix "continue outside of loop" TCL errors 2022-05-16 10:07:43 -03:00
mi-tsv-changed.exp gdb/testsuite: fix "continue outside of loop" TCL errors 2022-05-16 10:07:43 -03:00
no-attach-trace.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
no-attach-trace.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
packetlen.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
passc-dyn.exp gdb: Fix DUPLICATE and PATH regressions throughout 2022-05-25 13:44:12 +01:00
passcount.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
pending.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
pending.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
pendshr1.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
pendshr2.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
pr16508.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
qtro.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
qtro.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
range-stepping.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
range-stepping.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
read-memory.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
read-memory.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
report.exp gdb: Fix DUPLICATE and PATH regressions throughout 2022-05-25 13:44:12 +01:00
save-trace.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
signal.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
signal.exp gdb/testsuite: resolve duplicate test name in gdb.trace/signal.exp 2022-05-31 09:23:32 +01:00
stap-trace.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
stap-trace.exp gdb/testsuite: fix "continue outside of loop" TCL errors 2022-05-16 10:07:43 -03:00
status-stop.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
status-stop.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
strace.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
strace.exp gdb/testsuite: remove unneeded calls to get_compiler_info 2022-06-24 15:07:29 +01:00
tfile.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
tfile.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
tfind.exp gdb: Fix DUPLICATE and PATH regressions throughout 2022-05-25 13:44:12 +01:00
trace-break.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
trace-break.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
trace-buffer-size.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
trace-buffer-size.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
trace-common.h Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
trace-condition.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
trace-condition.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
trace-enable-disable.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
trace-enable-disable.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
trace-mt.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
trace-mt.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
trace-unavailable.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
tracecmd.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
tracefile-pseudo-reg.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
tracefile-pseudo-reg.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
tspeed.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
tspeed.exp gdb: Fix DUPLICATE and PATH regressions throughout 2022-05-25 13:44:12 +01:00
tstatus.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
tsv.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
unavailable-dwarf-piece.c Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
unavailable-dwarf-piece.exp Fix pedantically invalid DWARF in gdb.trace/unavailable-dwarf-piece.exp 2022-07-07 13:27:39 +01:00
unavailable.cc Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
unavailable.exp Automatic Copyright Year update after running gdb/copyright.py 2022-01-01 19:13:23 +04:00
while-dyn.exp gdb: Fix DUPLICATE and PATH regressions throughout 2022-05-25 13:44:12 +01:00
while-stepping.exp gdb: Fix DUPLICATE and PATH regressions throughout 2022-05-25 13:44:12 +01:00