a207f6b3a3
The "python" command (and the Python implementation of the gdb "source" command) does not handle Python exceptions in the same way as other gdb-facing Python code. In particular, exceptions are turned into a generic error rather than being routed through gdbpy_handle_exception, which takes care of converting to 'quit' as appropriate. I think this was done this way because PyRun_SimpleFile and friends do not propagate the Python exception -- they simply indicate that one occurred. This patch reimplements these functions to respect the general gdb convention here. As a bonus, some Windows-specific code can be removed, as can the _execute_file function. The bulk of this change is tweaking the test suite to match the new way that exceptions are displayed. These changes are largely uninteresting. However, it's worth pointing out the py-error.exp change. Here, the failure changes because the test changes the host charset to something that isn't supported by Python. This then results in a weird error in the new setup. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31354 Acked-By: Tom de Vries <tdevries@suse.de> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
82 lines
3 KiB
Text
82 lines
3 KiB
Text
# Copyright (C) 2022-2024 Free Software Foundation, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test that GDB rejects invalid TUI window names, and that valid names
|
|
# are allowed.
|
|
|
|
load_lib gdb-python.exp
|
|
|
|
require allow_python_tests allow_tui_tests
|
|
|
|
tuiterm_env
|
|
|
|
clean_restart
|
|
|
|
# Define a function we can use as a window constructor. If this ever
|
|
# gets called we'll throw an error, but that's OK, this test doesn't
|
|
# actually try to create any windows.
|
|
gdb_test_multiline "create a window constructor" \
|
|
"python" "" \
|
|
"def failwin(win):" "" \
|
|
" raise RuntimeError('failwin')" "" \
|
|
"end" ""
|
|
|
|
# Check for some of the characters that can't be used within a window
|
|
# name.
|
|
foreach c {$ * \{ \} ( ) @ #} {
|
|
set re [string_to_regexp "$c"]
|
|
gdb_test "python gdb.register_window_type('te${c}st', failwin)" \
|
|
[multi_line \
|
|
"gdb.error.*: invalid character '${re}' in window name" \
|
|
"Error occurred in Python.*" ]
|
|
|
|
gdb_test "python gdb.register_window_type('${c}test', failwin)" \
|
|
[multi_line \
|
|
"gdb.error.*: invalid character '${re}' in window name" \
|
|
"Error occurred in Python.*" ]
|
|
}
|
|
|
|
# Check that whitespace within a window name is rejected.
|
|
foreach c [list " " "\\t" "\\n" "\\r"] {
|
|
gdb_test "python gdb.register_window_type('te${c}st', failwin)" \
|
|
[multi_line \
|
|
"gdb.error.*: invalid whitespace character in window name" \
|
|
"Error occurred in Python.*" ]
|
|
}
|
|
|
|
# Check some of the characters which are allowed within a window name,
|
|
# but are not allowed to be used as the first character.
|
|
foreach c {1 _ - .} {
|
|
set re [string_to_regexp "$c"]
|
|
gdb_test "python gdb.register_window_type('${c}test', failwin)" \
|
|
[multi_line \
|
|
"gdb.error.*: window name must start with a letter, not '${re}'" \
|
|
"Error occurred in Python.*" ]
|
|
}
|
|
|
|
# Check different capitalisations.
|
|
gdb_test_no_output "python gdb.register_window_type('TEST', failwin)"
|
|
gdb_test_no_output "python gdb.register_window_type('test', failwin)"
|
|
gdb_test_no_output "python gdb.register_window_type('tEsT', failwin)"
|
|
gdb_test_no_output "python gdb.register_window_type('TeSt', failwin)"
|
|
|
|
# Check a set of characters that can appear within a name, just not
|
|
# necessarily as the first character. We check at both the end of the
|
|
# name, and within the name.
|
|
foreach c {1 _ - . A} {
|
|
set re [string_to_regexp "$c"]
|
|
gdb_test_no_output "python gdb.register_window_type('test${c}', failwin)"
|
|
gdb_test_no_output "python gdb.register_window_type('te${c}st', failwin)"
|
|
}
|