binutils-gdb/gdb/testsuite/gdb.python/py-record-full.exp
Tom Tromey a207f6b3a3 Rewrite "python" command exception handling
The "python" command (and the Python implementation of the gdb
"source" command) does not handle Python exceptions in the same way as
other gdb-facing Python code.  In particular, exceptions are turned
into a generic error rather than being routed through
gdbpy_handle_exception, which takes care of converting to 'quit' as
appropriate.

I think this was done this way because PyRun_SimpleFile and friends do
not propagate the Python exception -- they simply indicate that one
occurred.

This patch reimplements these functions to respect the general gdb
convention here.  As a bonus, some Windows-specific code can be
removed, as can the _execute_file function.

The bulk of this change is tweaking the test suite to match the new
way that exceptions are displayed.  These changes are largely
uninteresting.  However, it's worth pointing out the py-error.exp
change.  Here, the failure changes because the test changes the host
charset to something that isn't supported by Python.  This then
results in a weird error in the new setup.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31354
Acked-By: Tom de Vries <tdevries@suse.de>
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
2024-02-27 09:46:31 -07:00

50 lines
1.7 KiB
Text

# This testcase is part of GDB, the GNU debugger.
#
# Copyright 2016-2024 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Skip this test if target does not support recording.
require supports_process_record allow_python_tests
load_lib gdb-python.exp
standard_testfile
if [prepare_for_testing "failed to prepare" $testfile $srcfile] { return -1 }
if {![runto_main]} {
return -1
}
with_test_prefix "no or double record" {
gdb_test "python print(gdb.current_recording())" "None"
gdb_test_no_output "python gdb.start_recording(\"full\")"
gdb_test "python gdb.start_recording(\"full\")" \
".*gdb\.error.*: The process is already being recorded\..*" \
"already recording"
gdb_test_no_output "python gdb.stop_recording()" "first"
gdb_test "python gdb.stop_recording()" \
".*gdb\.error.*: No recording is currently active\..*" "second"
}
with_test_prefix "preopened record full" {
gdb_test_no_output "record full"
gdb_test "python print(gdb.current_recording().method)" "full"
gdb_test "python print(gdb.current_recording().format)" "full"
gdb_test_no_output "python gdb.stop_recording()"
}