binutils-gdb/gdb/testsuite/gdb.ada/arrayptr.exp
Tom Tromey 1dd09e7f70 Fix Ada 'ptype' of access to array
ptype is a bit funny, in that it accepts both expressions and type
names.  It also evaluates the resulting expression using
EVAL_AVOID_SIDE_EFFECTS -- which both seems sensible (as a user would
you expect ptype to possibly cause inferior execution?), but is also a
historical artifact of how expressions are implemented (there's no
EVAL_FOR_TYPE).

In Ada, calling a function with an array will sometimes result in a
"thick pointer" array descriptor being made.  This is essentially a
structure holding a pointer and bounds information.

Currently, in such a callee, printing the type of the array will yield
funny results:

    (gdb) print str.all
    $1 = "Hello World"
    (gdb) ptype str
    type = array (<>) of character
    (gdb) ptype str.all
    type = array (1 .. 0) of character

That "1 .. 0" is the result of an EVAL_AVOID_SIDE_EFFECTS branch
trying to do "something" with an array descriptor, without doing too
much.

I tried briefly to make this code really dereference the array
descriptor and get the correct runtime type.  However, that proved to
be tricky; it certainly can't be done for all access types, because
that will cause dynamic type resolution and end up printing just the
runtime type -- which with variants may be pretty far from what the
user may expect.

Instead, this patch arranges to just leave such types alone in this
situation.  I don't think this should have an extra effects, because
things like array subscripting still work on thick pointers.

This patch also touches arrayptr.exp, because in that case the access
type is a "thin pointer", and this ensures that the output does not
change in that scenario.
2024-03-18 08:22:37 -06:00

108 lines
2.9 KiB
Text

# Copyright 2008-2024 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
load_lib "ada.exp"
require allow_ada_tests
standard_ada_testfile foo
foreach_with_prefix scenario {all minimal} {
set flags [list debug additional_flags=-fgnat-encodings=$scenario]
if {[gdb_compile_ada "${srcfile}" "${binfile}-${scenario}" executable $flags] != ""} {
return -1
}
clean_restart ${testfile}-${scenario}
set bp_location [gdb_get_line_number "STOP" ${testdir}/foo.adb]
if {![runto "foo.adb:$bp_location"]} {
return
}
gdb_test "print string_p" \
"= \\(foo\\.string_access\\) 0x\[0-9a-zA-Z\]+"
gdb_test "print string_p(3..4)" "= \"ll\""
gdb_test "print null_string" "= \\(foo\\.string_access\\) 0x0"
gdb_test "print arr_ptr" "= \\(access foo\\.little_array\\) 0x\[0-9a-zA-Z\]+"
gdb_test "print arr_ptr(2)" "= 22"
gdb_test "print arr_ptr(3..4)" "= \\(3 => 23, 24\\)"
gdb_test "ptype arr_ptr" \
[string_to_regexp "type = access array (1 .. 10) of integer"]
gdb_test "ptype arr_ptr.all" \
[string_to_regexp "type = array (1 .. 10) of integer"]
gdb_test "ptype string_access" "= access array \\(<>\\) of character"
# GNAT >= 12.0 has the needed fix here.
set xfail_expected 0
if {$scenario == "minimal" && ![test_compiler_info {gcc-1[2-9]-*}]} {
set xfail_expected 1
}
gdb_test_multiple "print pa_ptr.all" "" {
-re -wrap " = \\(10, 20, 30, 40, 50, 60, 62, 63, -23, 42\\)" {
pass $gdb_test_name
}
-re -wrap " = \[0-9\]+" {
if { $xfail_expected } {
xfail $gdb_test_name
} else {
fail $gdb_test_name
}
}
}
set xfail_cannot_subscript_re \
"cannot subscript or call something of type `foo__packed_array_ptr'"
gdb_test_multiple "print pa_ptr(3)" "" {
-re -wrap " = 30" {
pass $gdb_test_name
}
-re -wrap $xfail_cannot_subscript_re {
if { $xfail_expected } {
xfail $gdb_test_name
} else {
fail $gdb_test_name
}
}
}
set xfail_attempt_to_index_re \
"Attempt to index or call something other than an array or function"
gdb_test_multiple "print pa_ptr.all(3)" "" {
-re -wrap " = 30" {
pass $gdb_test_name
}
-re -wrap $xfail_attempt_to_index_re {
if { $xfail_expected } {
xfail $gdb_test_name
} else {
fail $gdb_test_name
}
}
}
}