If a target does not support making function calls from GDB then in a
number of test files, we currently report an XFAIL and skip some, or all
of the tests. This commit changes the XFAIL to an UNSUPPORTED as this
seems more appropriate in these cases.
Some of the tests used bug ID 2416 to be reported in the XFAIL. In the
current GDB bugzilla bug 2416 has nothing to do with calling target
functions from GDB.
gdb/testsuite/ChangeLog:
* gdb.base/call-ar-st.exp: Report unsupported rather than xfail
for unsupported target features.
* gdb.base/call-rt-st.exp: Likewise.
* gdb.base/call-sc.exp: Likewise.
* gdb.base/call-signal-resume.exp: Likewise.
* gdb.base/call-strs.exp: Likewise.
* gdb.base/callexit.exp: Likewise.
* gdb.base/callfuncs.exp: Likewise.
* gdb.base/nodebug.exp: Likewise.
* gdb.base/printcmds.exp: Likewise.
* gdb.base/ptype.exp: Likewise.
* gdb.base/structs.exp: Likewise.
* gdb.base/unwindonsignal.exp: Likewise.
* gdb.cp/gdb2495.exp: Likewise.
* gdb.cp/templates.exp: Likewise.
* gdb.cp/virtfunc.exp: Likewise.
* gdb.threads/hand-call-in-threads.exp: Likewise.
* gdb.threads/interrupted-hand-call.exp: Likewise.
* gdb.threads/thread-unwindonsignal.exp: Likewise.
This patch removes all special cases for HP-UX, for which support has
been removed earlier, that I found in the testsuite. Note that the hppa
architecture != HP-UX, since other OSes can run on hppa, so I tried to
leave everything that is not HP-UX specific.
Two complete tests were completely HP-UX specific, so I removed them.
I ran the testsuite on Linux x86-64, native and native-gdbserver, and
noticed no regressions.
gdb/testsuite/ChangeLog:
* gdb.asm/asm-source.exp: Remove HP-UX references.
* gdb.base/annota1.exp: Likewise.
* gdb.base/annota3.exp: Likewise.
* gdb.base/attach.exp: Likewise.
* gdb.base/bigcore.exp: Likewise.
* gdb.base/break.exp: Likewise.
* gdb.base/call-ar-st.exp: Likewise.
* gdb.base/callfuncs.exp: Likewise.
* gdb.base/catch-fork-static.exp: Likewise.
* gdb.base/display.exp: Likewise.
* gdb.base/foll-exec-mode.exp: Likewise.
* gdb.base/foll-exec.exp: Likewise.
* gdb.base/foll-fork.exp: Likewise.
* gdb.base/foll-vfork.exp: Likewise.
* gdb.base/funcargs.exp: Likewise.
* gdb.base/hbreak2.exp: Likewise.
* gdb.base/inferior-died.exp: Likewise.
* gdb.base/interrupt.exp: Likewise.
* gdb.base/multi-forks.exp: Likewise.
* gdb.base/nodebug.exp: Likewise.
* gdb.base/sepdebug.exp: Likewise.
* gdb.base/solib1.c: Likewise.
* gdb.base/step-test.exp: Likewise.
* gdb.mi/non-stop.c: Likewise.
* gdb.mi/pthreads.c: Likewise.
* gdb.multi/bkpt-multi-exec.ex: Likewise.
* gdb.threads/pthreads.c: Likewise.
* gdb.threads/staticthreads.exp: Likewise.
* lib/future.exp: Likewise.
* lib/gdb.exp: Likewise.
* gdb.base/so-indr-cl.c: Remove.
* gdb.base/so-indr-cl.exp: Likewise.
* gdb.base/solib.c: Likewise.
* gdb.base/solib.exp: Likewise.
* gdb.base/solib2.c: Likewise.
This does most of the mechanical removal. IOW, the easy part.
This doesn't touch procfs.c as that'd be a harder excision,
potentially affecting Solaris.
mips-tdep.c is left alone. E.g., I didn't delete the GDB_OSABI_IRIX
enum value, nor references to it in mips-tdep.c. Some comments
mentioning IRIX ABIs may still be relevant and I wouldn't know what to
do with them. in That can always be done on a separate pass,
preferably by someone who can test on MIPS.
I didn't remove a reference to IRIX in testsuite/lib/future.exp, as I
believe that code is imported from DejaGNU.
Built and tested on x86_64 Fedora 20, with --enable-targets=all.
Tested that building for --target=mips-sgi-irix6 on x86_64 Fedora 20
fails with:
checking for default auto-load directory... $debugdir:$datadir/auto-load
checking for default auto-load safe-path... $debugdir:$datadir/auto-load
*** Configuration mips-sgi-irix6 is obsolete.
*** Support has been REMOVED.
make[1]: *** [configure-gdb] Error 1
make[1]: Leaving directory `/home/pedro/gdb/mygit/build-irix'
make: *** [all] Error 2
gdb/
2014-10-10 Pedro Alves <palves@redhat.com>
* Makefile.in (ALL_TARGET_OBS): Remove mips-irix-tdep.o and solib-irix.o.
(ALLDEPFILES): Remove mips-irix-tdep.c and solib-irix.c.
(HFILES_NO_SRCDIR): Remove solib-irix.h.
* NEWS: Mention that support for mips-sgi-irix5* mips-sgi-irix6*
and been removed.
* config/mips/irix5.mh, config/mips/irix6.mh: Delete files.
* configure.ac: Remove references to IRIX.
* configure.host: Add *-*-irix* to the obsolete hosts section.
Remove all other references to irix.
* irix5-nat.c, mips-irix-tdep.c, solib-irix.c, solib-irix.h:
Delete files.
gdb/testsuite/
2014-10-10 Pedro Alves <palves@redhat.com>
* gdb.base/bigcore.exp: Remove references to IRIX.
* gdb.base/funcargs.exp: Likewise.
* gdb.base/interrupt.exp: Likewise.
* gdb.base/mips_pro.exp: Likewise.
* gdb.base/nodebug.exp: Likewise.
* gdb.base/setvar.exp: Likewise.
* lib/gdb.exp (gdb_compile_shlib): Remove mips-sgi-irix* case.
Two modifications:
1. The addition of 2013 to the copyright year range for every file;
2. The use of a single year range, instead of potentially multiple
year ranges, as approved by the FSF.
* gdb.base/maint.exp: Expect "." prefix.
* gdb.base/nodebug.exp: Expect "." Likewise.
* gdb.base/sepsymtab.exp: Expect "." Likewise.
* gdb.base/watchpoint-cond-gone.exp: Likewise.
* gdb.base/watchpoint.exp: Expect a software watch to be created for
POWER server processors.
errors unique.
* testsuite/gdb.base/nodebug.exp: Whack out all -g options
explicitly.
* v850-tdep.c (v850_init_extra_frame_info v850_frame_chain): Fix
sign bugs with scanning prologues. Get a little smarter about
calculating the length of uninteresting instructions.
clear_xfail for "p t_float_values2(3.14159,float_val2)" for gcc
compiled test.
* gdb.base/opaque.exp (setup_xfail_on_opaque_pointer):
Add mips-sgi-irix5* xfail for not gcc compiled.
* gdb.base/Makefile.in (nodebug.o): Also create nodebug.ci.
* gdb.base/nodebug.exp: Add mips-sgi-irix5 xfail when not gcc compiled for
"p top", "whatis top", "p middle", and "whatis middle".
* gdb.base/whatis.exp: Add mips-sgi-irix* xfail for
"whatis signed char" for not gcc compiled.
* gdb.base/setvar.exp: Add mips-sgi-irix4* xfail (works on irix5) for
"set variable signed char=-1 (-1)" and
"set variable signed char=0xFF (0xFF)" for not gcc compiled.
* gdb.base/funcargs.exp (float_and_integral_args):
Add mips-sgi-irix5* xfail for "run to call2a" for not gcc compiled.
Add mips-sgi-irix* xfail when not gcc compiled for
"continue to call2b".
Add mips-sgi-irix4* xfail (works with irix5) when gcc compiled for
"continue to call2g".
(discard_and_shuffle): Add mips-sgi-irix5* xfail whn not gcc compiled for
"backtrace from call6a"
(shuffle_round_robin): Add mips-sgi-irix* xfail when not gcc compiled for
"backtrace from call7k".
Add mips-sgi-irix5* xfail when not gcc compiled for
"backtrace from call7a".
(localvars_after_alloca): Fix gdb_test cmds for
"print * after runto ...".
Remove rs6000-*-* xfails for
"print i after runto localvars_after_alloca" and
"print l after runto localvars_after_alloca"
for all compilers.
* gdb.base/exprs.exp: Add mips-sgi-irix4* xfails (works with irix5),
when not compiled with gcc, for:
"print signed char == (minus)",
"print signed char != (minus)",
"print signed char < (minus)",
"print signed char > (minus)".
* gdb.base/callfuncs.exp (do_function_calls):
Add mips-sgi-irix* xfail, when compiled with native compiler, for
"call inferior func with struct - returns char *".
* gdb.base/return.exp (return_tests): Change xfail for
"correct value returned double test" to include Solaris 2.4.
* gdb.base/funcargs.exp (float_and_integral_args):
Add sparc-sun-solaris2* xfail for "print f1 after run to call2a".
only \r\n, not .*. The test can pass .* as the last thing in
$pattern if that is what it wants. In addition to providing this
flexibility, this change should speed up pattern matching in cases
where the pattern already ended with .* (there were a number of
them). This change also helps catch bad patterns--in the old
scheme the typo "char \*" instead of "char \\*" would pass. Now
it is caught.
* Many .exp files: Update callers.
remove them.
* gdb.base/nodebug.exp: Accept "function" in addition to "text
variable and "variable" in addition to "data variable".
* gdb.base/nodebug.exp: xfail datalocal and bsslocal tests for AIX.