FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove some dead code

Browse source 
print_block_frame_labels has been commented out since 2010.
I don't think we need it; this patch removes it.

2020-04-29  Tom Tromey  <tom@tromey.com>

	* stack.c (print_block_frame_labels): Remove.
This commit is contained in:
Tom Tromey 2020-04-29 08:10:28 -06:00
parent dfa85db14c
commit fc49bc7237
2 changed files with 4 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

4
gdb/ChangeLog
View file

@ -1,3 +1,7 @@
2020-04-29 Tom Tromey <tom@tromey.com>
* stack.c (print_block_frame_labels): Remove.
2020-04-29 Hannes Domani <ssbssa@yahoo.de> 2020-04-29 Hannes Domani <ssbssa@yahoo.de>
PR gdb/17320 PR gdb/17320

50
gdb/stack.c
View file

@ -2257,56 +2257,6 @@ iterate_over_block_locals (const struct block *b,
} }
} }
/* Same, but print labels. */
#if 0
/* Commented out, as the code using this function has also been
commented out. FIXME:brobecker/2009-01-13: Find out why the code
was commented out in the first place. The discussion introducing
this change (2007-12-04: Support lexical blocks and function bodies
that occupy non-contiguous address ranges) did not explain why
this change was made. */
static int
print_block_frame_labels (struct gdbarch *gdbarch, struct block *b,
int *have_default, struct ui_file *stream)
{
struct block_iterator iter;
struct symbol *sym;
int values_printed = 0;
ALL_BLOCK_SYMBOLS (b, iter, sym)
{
if (strcmp (sym->linkage_name (), "default") == 0)
{
if (*have_default)
continue;
*have_default = 1;
}
if (SYMBOL_CLASS (sym) == LOC_LABEL)
{
struct symtab_and_line sal;
struct value_print_options opts;
sal = find_pc_line (SYMBOL_VALUE_ADDRESS (sym), 0);
values_printed = 1;
fputs_filtered (sym->print_name (), stream);
get_user_print_options (&opts);
if (opts.addressprint)
{
fprintf_filtered (stream, " ");
fputs_filtered (paddress (gdbarch, SYMBOL_VALUE_ADDRESS (sym)),
stream);
}
fprintf_filtered (stream, " in file %s, line %d\n",
sal.symtab->filename, sal.line);
}
}
return values_printed;
}
#endif
/* Iterate over all the local variables in block B, including all its /* Iterate over all the local variables in block B, including all its
superblocks, stopping when the top-level block is reached. */ superblocks, stopping when the top-level block is reached. */