FreeChainXenon/binutils-gdb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gdb: remove unpush_target free function

Browse source 
unpush_target unpushes the passed-in target from the current inferior's
target stack.  Calling it is therefore an implicit dependency on the
current global inferior.  Remove that function and make the callers use
the inferior::unpush_target method directly.  This sometimes allows
using the inferior from the context rather than the global current
inferior.

target_unpusher::operator() now needs to be implemented in target.c,
otherwise target.h and inferior.h both need to include each other, and
that wouldn't work.

gdb/ChangeLog:

	* target.h (unpush_target): Remove, update all callers
	to use `inferior::unpush_target` instead.
	(struct target_unpusher) <operator()>: Just declare.
	* target.c (unpush_target): Remove.
	(target_unpusher::operator()): New.

Change-Id: Ia5172dfb3f373e0a75b991885b50322ca2142a8c
This commit is contained in:
Simon Marchi 2021-03-23 09:50:32 -04:00
parent 70e958370c
commit fadf6add30
17 changed files with 36 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

6
gdb/linux-thread-db.c
View file

@ -1364,7 +1364,7 @@ thread_db_target::detach (inferior *inf, int from_tty)
/* NOTE: From this point on, inferior_ptid is null_ptid. */
/* Detach the thread_db target from this inferior. */
unpush_target (this);
inf->unpush_target (this);
}
ptid_t
@ -1398,7 +1398,7 @@ thread_db_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus,
/* New image, it may or may not end up using thread_db. Assume
not unless we find otherwise. */
delete_thread_db_info (beneath, ptid.pid ());
unpush_target (this);
current_inferior ()->unpush_target (this);
return ptid;
}
@ -1420,7 +1420,7 @@ thread_db_target::mourn_inferior ()
target_beneath->mourn_inferior ();
/* Detach the thread_db target from this inferior. */
unpush_target (this);
current_inferior ()->unpush_target (this);
}
struct callback_data